Melissa Jost
e03395b386
misc: Check for Change-Id in GitHub Actions
...
This adds a check to our continous integration tests that ensures
that every single commit in a pull request has a Change-Id, and
instructs you to add one if that check fails. This ensures all
commits on GitHub are still compatible with Gerrit.
Change-Id: I3fd753da5ab3ca6d6334a8e0eb574433aa1ca589
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/72118
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Maintainer: Jason Lowe-Power <power.jg@gmail.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Richard Cooper <richard.cooper@arm.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
2023-07-07 14:44:51 +00:00
Bobby R. Bruce
b271367a35
misc: Adjust compiler tests and CI tests
...
This adds a job level timeout for the compiler tests, allows
them to run weekly instead of daily, adds a workflow
dispatch option, and changes the
'latests-compilers-all-gem5-builds' jobs to run only the .opt
variant. It also adds a ready for review option
to the CI tests to run when someone converts a draft
pull request.
Change-Id: Id32b5f7da90745d18de2e550bd48d32ba45fb4d9
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71725
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
2023-06-27 21:18:26 +00:00
Bobby R. Bruce
55cecfc3e8
misc: Remove 'run-name' from workflow yaml files
...
This field is not necessary and was not a helpful description of the
run.
Change-Id: I078481920833fb36099e6c30295c0b60ac0ee3a0
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71505
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2023-06-13 17:49:30 +00:00
Bobby R. Bruce
2024546951
misc: Update GitHub Actions Workflow names
...
Change-Id: Iaf4cbdf7a8edd2b9ae00308ae41f6fa805ab9446
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71504
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Maintainer: Jason Lowe-Power <power.jg@gmail.com >
2023-06-13 17:49:30 +00:00
Bobby R. Bruce
5ca9541037
misc: Add 'synchronize' as CI Test action. Remove 'reopen'
...
'synchronize' will re-run the tests everytime the pull-request is
updated, inclusive of rebasing. 'reopen' seems pointless as reopening
does not change the pull-request functionality.
Change-Id: I24c2686e19a8b0901323e9bd794142994dc2a87c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71503
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
2023-06-13 17:49:30 +00:00
Melissa Jost
9c1603119c
misc: Increase timeout for GitHub Actions
...
This increases the timeout for our compiler tests, and for
the very-long runs in our weekly tests.
Change-Id: I027d2e98ce5596430ffcb20ef484e1cd7d4f644b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71501
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2023-06-13 02:18:13 +00:00
Melissa Jost
2e2f869901
misc: Adjust timeout for compiler tests
...
This updates the timeout for the compiler tests to run per step
as opposed to by job, as well as increases this limit from
4 hours to 6 hours.
Change-Id: I6b0fe5561f74e450cd79205a96084dd27ccccead
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71458
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Maintainer: Jason Lowe-Power <power.jg@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
2023-06-10 05:57:57 +00:00
Melissa Jost
cc564c8931
misc: Add weekly tests to Github workflows
...
This introduces the very-long tests from our weekly tests to be
able to run within GitHub.
Change-Id: I5f5b4c521b47272cb27640c572a869c26c04b95a
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71401
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
2023-06-09 02:18:48 +00:00
Melissa Jost
27492d9d18
misc: Update GitHub yaml files
...
This introduces a few fixes to the yaml files, such as fixing
the failing SystemC tests by removing an extra Docker container,
declaring the Python version for our compiler tests, fixing
typos in the GPU daily tests, and adjusting the timeout values
for our compiler tests and unittests.
Change-Id: I3b4f2220750138783717b3678b0d8676155cb2a1
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71400
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Maintainer: Matt Sinclair <mattdsinclair@gmail.com >
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com >
2023-06-09 02:18:41 +00:00
Melissa Jost
ad0a2d1bea
misc: Adding GitHub workflow files
...
This changes adds all of the workflows that will be run as we
move to using GitHub. It includes our compiler tests, our
nightly runs, and the continuous integration tests to be
run on every pull request.
Change-Id: I54c79aca7c0603337bd9fca443a0e2ffef603b0e
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71298
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2023-06-06 13:36:26 +00:00
Bobby R. Bruce
5fa484e2e0
misc: Merge the v22.1 release staging into stable
2022-12-30 19:53:52 +00:00
Bobby R. Bruce
61aabd516e
misc: Update RELEASE-NOTES.md for v22.1.0.0
...
Change-Id: I28753f24742ca156e19ac2af4fb302f9de20e852
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66391
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Reviewed-by: Matthew Poremba <matthew.poremba@amd.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br >
2022-12-30 19:30:06 +00:00
Melissa Jost
55d8219717
tests: Remove get_runtime_isa() from parsec_disk_run.py
...
This change removes the call to get_runtime_isa(), as it has
been deprecated.
Change-Id: Ie1b0b5fb456fd8ed504a531841fe4ea8e211502c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66611
Maintainer: Boris Shingarov <shingarov@labware.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Boris Shingarov <shingarov@labware.com >
Tested-by: kokoro <noreply+kokoro@google.com >
2022-12-17 11:37:13 +00:00
Bobby R. Bruce
81cb7c05b4
misc: Update .mailmap
...
This commit updates the mailmap since the initial commit in mid-July
2020: https://gem5-review.googlesource.com/c/public/gem5/+/29672 .
`sort -u` has been run on this file so some previous entries have been
moved.
Change-Id: I46df1e9675f6f7057b680ca2abbcebdffd50462a
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66531
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2022-12-08 18:11:17 +00:00
Bobby R. Bruce
c765cfb64b
configs: Alter x86-npb-benchmarks.py to exit after WORKEND
...
While the config script will still function without exiting the SimLoop
after the "WORKEND" exit event, there's no need for the simulation to
continue beyond this point.
Change-Id: I60691215e9516fa1eeb8b8502f2bc5a09de2969b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66515
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
2022-12-07 18:56:01 +00:00
Bobby R. Bruce
5d475506d7
configs: Fix x86-gapbs-benchmarks.py example
...
With https://gem5-review.googlesource.com/c/public/gem5/+/64791 we
updated the configs/example/gem5_library to utilize the `m5.simulate`
module. The GAPBS benchmark example uses the "WORKBEGIN" and "WORKEND"
exit events to specify the ROI. The patch incorrectly assumed an "EXIT"
exit event were used.
As such, the
"test-gem5-library-example-x86-gapbs-benchmarks-ALL-x86_64-opt-MESI_Two_Level"
test was not properly running, causing the Nightly test to fail:
https://jenkins.gem5.org/job/nightly/444 . This patch fixes this error.
Change-Id: I207fe3563c8d9c59bcb79428fe62d2d2bbccd013
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66514
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2022-12-07 18:56:01 +00:00
Bobby R. Bruce
1e73beb620
python: Remove 'scheduleTickExit' in favor of 'exitSimLoop'
...
The commit https://gem5-review.googlesource.com/c/public/gem5/+/66231
added an API to m5 for scheduling to-tick exit events. This added the
function `schedule_tick_exit`. It was later pointed out that this
`schedule_tick_exit` event is redundant given the existance of
`exitSimLoop`. This patch therefore removes `schedule_tick_exit` in
favor of `exitSimLoop`.
Change-Id: Ibecf00b98256a5da2868427d766bdc93f03c3f97
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66511
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2022-12-06 22:41:58 +00:00
Bobby R. Bruce
e200ea1510
ext: Update ext/sst/README.md for v22.1 release
...
Change-Id: I3221bbc4e4bf1d7a2bd7516873c7bfcf08bebde5
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65924
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
620e5243e7
tests: Update presubmit.sh to use v22-1 docker images
...
Change-Id: I7b800f794af699281f17d6c484393c1646e3de4e
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65923
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
a3fd9631cc
util-gem5art: Fix incorrect type of size in createArtifact
...
The typing here was `int` but had a default value of `None`. The correct
type is therefore `Optional[int]`.
Change-Id: Ibaf63151196b15f68e643fa5c1b290439d6618c8
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66371
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
1c422628bc
tests: Update weekly test docker image tags to v22-1
...
Change-Id: I6a7ff942234f65b763d2974deb740942bfc2cc17
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65922
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
38778c5a17
tests: Abstract the docker image tag for Weekly tests
...
This abstraction allows us to more easily change the tags between
different gem5 releases and/or between stable and the develop branch.
Change-Id: Iad49cabac9b4000e8570162d3e12453c6d097ee2
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65921
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
1e5bd5b89a
tests: Update nightly test docker image tags to v22-1
...
Change-Id: I3d1fa67a89594050cb8069541004763ac5ba66a4
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65920
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
1c79a469ba
tests: Abstract the docker image tag for Nightly tests
...
This abstraction allows us to more easily change the tags between
different gem5 releases and/or between stable and the develop branch.
Change-Id: Ieb38e9a333ef8592b586014a3a9220f4a18c64e3
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65919
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
d1c72cecb3
tests: Update the compiler-tests.sh to use the v22-1 images
...
This keeps the running of the compiler tests consistent by using a fixed
version of the compiler images.
Change-Id: I6e8d8313939696ed22f22e55f9c274c0105ce236
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65918
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
ed6d80c273
util-docker: Add v22-1 tag to docker-compose.yaml
...
Change-Id: I91088efe4e0bcee9b9f83d5208a14932821a17c4
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65917
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
3df8be981b
util-docker: Update gcn-gpu Docker to use v22-1 ROCM patch
...
Change-Id: I21b530babe095861eb80fdfefd12d8e127ffa3c2
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65916
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
7185c9ea19
stdlib: Update the gem5 resources' version to "v22.1"
...
This is required to ensure the correct version of the resources are
obtained for this version of gem5.
Change-Id: If316081c776d510ec9a2f7ff9e077a1f837d2d2e
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65915
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
da2c70af6f
python,tests: Update Resource URL path to v22-1
...
This change ensures the stable branch obtains the right resources for
the correct version of gem5.
Change-Id: Ie4e90529460d5058a7696d1c1d8f9678563be7bb
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65914
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
363d65206a
base: Update the version to v22.1.0.0
...
Change-Id: I4d511a8052cfa5b23e8fecff5e3565b7cfea1763
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65913
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
2022-12-05 20:25:53 +00:00
Bobby R. Bruce
7dd61c8659
scons: Remove -Werror for the gem5 v22.1 release
...
While gem5 compiles on all our supported compilers, removing the -Werror
flag on the stable branch ensures that, as new compilers are released
with stricter warnings, gem5 remains compilable.
Change-Id: Ib6d4f86d9c7e60f23eba843e444cdd7812cdde41
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65912
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2022-12-05 20:25:53 +00:00
Giacomo Travaglini
23a406e811
arch-arm: Setup TC/ISA at construction time 2nd attempt
...
This partly reverts commit ec75787aefgiacomo.travaglini@arm.com >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66291
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Andreas Sandberg <andreas.sandberg@arm.com >
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
2022-12-05 20:25:33 +00:00
Melissa Jost
6f3f6c16f3
stdlib, configs: Updating configs/example/gem5_library
...
This commit updates all of the older tests in this directory to
use the Simulator to run instead of m5.simulate()
Change-Id: I2a81d5c2f27c89e8c03abb0203ca3e58a6688672
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/64791
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66332
2022-12-02 17:24:04 +00:00
Bobby R. Bruce
005049f548
stdlib,python: Allow setting of to tick exits via m5
...
This commit adds the following functions to the `m5` python module:
- setMaxTick(tick) -> None
- getMaxTick() -> int
- getTicksUntilMax() -> int
- scheduleTickExitFromCurrent(tick, exit_string) -> None
- scheduleTickExitAbsolute(tick, exit_string) -> None
Until this patch the only way to set an exit at a particular tick was
via `simulate.run` which would reschedule the maximum tick. This
functionality has been explicity exposed via the new `setMaxTick`
function. However, as this is only rescheduling the maximum tick, it
stops scheduling exits at multiple different ticks.
To get around this problem the `scheduleTickExit` functions have been
added. These allow a user to schedule multiple exit events. The
functions contain a `exit_string` parameter that provides the string
the simulator is to return when the specified tick is met. By default
this string is "Tick exit reached" which is used by the stdlib
Simulator module to declare a new `SCHEDULED_TICK` exit event (Note:
this has been deliberatly kept seperate from the `MAX_TICK` exit event.
This commit serves as an attempt to decouple these are two concepts).
Tests are provided in this patch to ensure these new functions work as
intended.
Additional notes:
- The `simulate` function has been fixed to match the documentation. If
the `num_cycles` is -1 then the maximum ticks is set to MaxTicks.
Otherwise the max ticks is set to `curTicks() + num_cycles`. The
functionality of this function will remain unchanged to the end-user.
- Full integration into the Simulator module is not complete as of this
patch. Users must us the m5 python module to set these exit events.
Change-Id: I6c92b31dd409dc866152224600ea8166cfcba38b
Issue-on: https://gem5.atlassian.net/browse/GEM5-1131
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66231
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
Maintainer: Jason Lowe-Power <power.jg@gmail.com >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66331
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2022-12-02 17:24:04 +00:00
Matthew Poremba
ea3f13ff3b
configs: Set CPU vendor to M5 Simulator in apu_se.py
...
Other vendor strings causes, for some reason, bad addresses to be
computed when running the GPU model. This change reverts back to M5
Simulator only for apu_se.py.
Change-Id: I5992b4e31569f5c0e5e49e523908c8fa0602f845
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66171
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
2022-11-28 23:02:55 +00:00
Bobby R. Bruce
ee9e07474b
tests: Delete build directory before running KVM in nightly
...
The nightly tests failed here:
https://jenkins.gem5.org/job/nightly/430/ . What seems to have happened
is the ALL/gem5.opt us compiled within the Docker container but then,
for the KVM tests, there is an attempt to recompile on the host, which
causes compilation problems. The safest strategy here is delete the
build directory prior to running the KVM tests.
In latest versions of our test infrastructure, the KVM tests should be
run completely separately (i.e., in different Jenkin's jobs) to avoid
this.
Change-Id: Id7d18c0504dd324f7a0e5e9a7809463520969dda
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65911
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65977
2022-11-28 18:52:51 +00:00
Bobby R. Bruce
d51ce0db94
configs: Add missing _pre_instantiate call in "run_lupv.py"
...
As of this change:
https://gem5-review.googlesource.com/c/public/gem5/+/65051 , the
`_pre_instantiate` function must be called prior to `m5.instantiate`
when using the stdlib without the Simulator module.
Change-Id: Id5cec3b643d556b0f742719596abb53533b84cbd
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65871
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65976
2022-11-28 18:52:51 +00:00
Bobby R. Bruce
753470e8fa
tests: Update riscvmatched tests to use ALL/gem5.opt
...
Where possible we are trying to use the ALL/gem5.opt compilation of
gem5. This change updates the riscvmatched tests to this.
Change-Id: I1c5f1d86cdf5cf29b8964f8a894a3476a7cb290a
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65854
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65975
2022-11-28 18:52:51 +00:00
Bobby R. Bruce
793076f2bd
configs,stdlib,tests: Update riscvmatched-fs.py to-init
...
The "test-gem5-library-example-riscvmatched-fs" test, which runs
"configs/example/gem5_library/riscvmatched-fs.py", was running the
script in full. This takes a very long time. Given we already have boot
tests for RISCV, it's better to just run this configuration to just the
end of the Linux boot (significantly faster than a full OS boot). This
patch adds this feature to the config script and modifies the test to
utilize it.
Change-Id: I1e37a26aab5e9a127ebd64590be79fbc16fe53aa
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65853
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65974
2022-11-28 18:52:51 +00:00
Bobby R. Bruce
373b8658f4
configs,stdlib: Fix import in riscvmatched-fs.py
...
Change-Id: I2ff4139457d32336f40c6655231064a12c4d8694
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65852
Tested-by: kokoro <noreply+kokoro@google.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65973
2022-11-28 18:52:51 +00:00
Bobby R. Bruce
f34f582dcf
stdlib,configs: Update riscvmatched-fs example docstring
...
This documentation string provided in the
"config/example/gem5_library/riscvmatched-fs.py" was minimal. This patch
adds more detail.
Change-Id: I0f203ea6952fc72a078594d7c30853bd426017ff
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65851
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65972
2022-11-28 18:52:51 +00:00
Bobby R. Bruce
9696cb517a
arch-arm: Revert 'Setup TC/ISA at construction time..'
...
Reverts:
dd2f1fb2f8https://gem5-review.googlesource.com/c/public/gem5/+/65174
and
47bd56ee71https://gem5-review.googlesource.com/c/public/gem5/+/65291
The 47bd56eedd2f1fb2https://gem5-review.googlesource.com/c/public/gem5/+/65732
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65971
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
2022-11-28 18:52:51 +00:00
Bobby R. Bruce
98f3d779b7
arch-x86: X86ISA default vector_string to HygonGenuine
...
This commit,
https://gem5-review.googlesource.com/c/public/gem5/+/64831 , changed the
default 'vendor_string' for the 'X86ISA' SimObject from 'M5 Simulator'
and 'AuthenticAMD'. Unforunately due to an issue highlighted here:
https://gem5.atlassian.net/browse/GEM5-1300 we cannot use the
'AuthenticAMD'. Therefore, this change updates the default vector_string
to HygonGenuine.
The HygonGenuine is simple but works.
Change-Id: I21421da8ae73e76d9daaf2fdd0b3238d5b309172
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65492
Tested-by: kokoro <noreply+kokoro@google.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65611
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com >
2022-11-28 18:52:51 +00:00
Matthew Poremba
04767ddc62
dev-amdgpu: Fix SDMA ring buffer wrap around
...
The current SDMA wrap around handling only considers the ring buffer
location as seen by the GPU. Eventually when the end of the SDMA ring
buffer is reached, the driver waits until the rptr written back to the
host catches up to what the driver sees before wrapping around back to
the beginning of the buffer. This writeback currently does not happen at
all, causing hangs for applications with a lot of SDMA commands.
This changeset first fixes the sizes of the queues, especially RLC
queues, so that the wrap around occurs in the correct place. Second, we
now store the rptr writeback address and the absoluate (unwrapped) rptr
value in each SDMA queue. The absolulte rptr is what the driver sends to
the device and what it expects to be written back.
This was tested with an application which basically does a few hundred
thousand hipMemcpy() calls in a loop. It should also fix the issue with
pannotia BC in fullsystem mode.
Change-Id: I53ebdcc6b02fb4eb4da435c9a509544066a97069
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65351
Maintainer: Jason Lowe-Power <power.jg@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com >
Maintainer: Matt Sinclair <mattdsinclair@gmail.com >
(cherry picked from commit c8d687b05chttps://gem5-review.googlesource.com/c/public/gem5/+/65451
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Matthew Poremba <matthew.poremba@amd.com >
2022-11-11 00:11:21 +00:00
Matthew Poremba
729a9399e4
arch-vega: Fix SOPK instruction sign extends
...
See: https://gem5-review.googlesource.com/c/public/gem5/+/37495
Same patch but for vega. This fixes issues with lulesh and probably
rodinia - heartwall as well in fullsystem.
Change-Id: I3af36bb9b60d32dc96cc3b439bb1167be1b0945d
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65432
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com >
Maintainer: Matt Sinclair <mattdsinclair@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
(cherry picked from commit 8693d725e2https://gem5-review.googlesource.com/c/public/gem5/+/65453
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Matthew Poremba <matthew.poremba@amd.com >
2022-11-11 00:11:05 +00:00
Matthew Poremba
56c359c41b
dev-amdgpu: Handle ring buffer wrap for PM4 queue
...
Change-Id: I27bc274327838add709423b072d437c4e727a714
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65431
Maintainer: Matt Sinclair <mattdsinclair@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com >
(cherry picked from commit 623e2d3dachttps://gem5-review.googlesource.com/c/public/gem5/+/65452
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Matthew Poremba <matthew.poremba@amd.com >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
2022-11-11 00:10:59 +00:00
Jasjeet Rangi
f172c41c68
stdlib: Fix get_isa_from_str() exception behavior in isas.py
...
When given an input string that does not match any valid ISA, the
get_isa_from_str() function should call get_isas_str_set() to to print
the valid ISA strings in the exception. The current behavior is to
recursively call get_isa_from_str() with no input, which prevents
the correct exception from being raised. This change causes the
correct exception to be raised for invalid inputs.
Change-Id: I92bfe862bbd99ce0b63bfc124e539fab3b175e0c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65411
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Maintainer: Bobby Bruce <bbruce@ucdavis.edu >
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
2022-11-09 18:37:14 +00:00
Matthew Poremba
8d63c9fc06
gpu-compute: Add granulated SGPR computation for gfx9
...
The granulated SGPR size is used when the number of SGPRs is unknown.
The computation for this has changed since gfx8 and is commented as a
TODO in a comment.
This changeset implements the change and also checks for an invalid SGPR
count. According to LLVM code this could happen "due to a compiler bug
or when using inline asm.":
https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AMDGPU/
AMDGPUAsmPrinter.cpp#L723
Change-Id: Ie487a53940b323a0002341075e0f81af4147a7d8
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65252
Maintainer: Matt Sinclair <mattdsinclair@gmail.com >
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
2022-11-08 21:34:11 +00:00
Matthew Poremba
f6dc5c6aa4
gpu-compute: Chunkify AMDKernelCode read from device
...
The AMDKernelCode object can span potentially span two pages. Currently
the copy loop from device memory only translates once at the base
address.
This changeset translates one cache line at a time before copying and
has the ancillary benefit for cleaning up this code a bit.
Change-Id: I602bc12d8f8c5d3a3e57ab3f42f7dd3df58dc144
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65251
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Maintainer: Jason Lowe-Power <power.jg@gmail.com >
2022-11-08 21:34:11 +00:00
Hoa Nguyen
553096ee53
stdlib: Make the Matched board a package
...
So that the board and its components can be reused.
Change-Id: Idae1a4493fbb4d826ac8da76532692a985f8025f
Signed-off-by: Hoa Nguyen <hoanguyen@ucdavis.edu >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65331
Maintainer: Jason Lowe-Power <power.jg@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
2022-11-08 05:32:32 +00:00
