Commit Graph

20367 Commits

Author SHA1 Message Date
Nicolas Boichat
3ea7a792b0 fastmodel: Add option to retry licence server connection.
We're seeing some occasional connection timeouts in CI, possibly
when we aggressively hit the license server, so let's add a
parameter to retry the connection a few times.

Also, print the time required to connect to the server to help
debug issues.

Change-Id: I804af28f79f893fcdca615d7bf82dd9b8686a74c
2023-08-15 10:47:32 +00:00
Bobby R. Bruce
41dcd3c5d5 misc: Add continue-on-error to matrix runs (#175)
This sets continue-on-error to true on any scheduled test that uses a
matrix so we can have all sets of tests run regardless if one of them
fails or not.
2023-08-11 07:39:25 -07:00
Bobby R. Bruce
fa918f61d1 tests: Move replacement policy and simulator config files (#173)
Moving these files should address the failures in the daily tests.
2023-08-11 07:39:06 -07:00
Bobby R. Bruce
cfea9afae3 misc: Update MAINTAINERS.yaml (#155)
- Updates the list of current gem5 Maintainers.
- Updates the MAINATAINERS.yaml comments to reflect gem5's contribution
policy and maintainer responsibilities since moving to GitHub.
- Updates the subsystem maintainers, based on maintainer's stated
preferences.
- Adds the optional 'expert' field to subsystems.
2023-08-11 02:05:26 -07:00
Melissa Jost
b08bc5ff56 misc: Add continue-on-error to matrix runs
This sets continue-on-error to true on any scheduled test that
uses a matrix so we can have all sets of tests run regardless
if one of them fails or not.

Change-Id: I8f6137ebdf62a5cecd582387316c330c8a1401ca
2023-08-10 16:58:22 -07:00
Melissa Jost
912b7c06dd tests: Move replacement policy and simulator config files
Moving these files should address the failures in the daily
tests.

Change-Id: I438adba1a45bdf6083651b6b3f610c8bbe4ebdf0
2023-08-10 16:38:20 -07:00
Bobby R. Bruce
6ca9435961 misc: Add Matt P. as maintainer to requested tags
Change-Id: Ifffb34acbf9ebf313e5bc09ebbfd2a44a017359a
2023-08-10 15:52:00 -07:00
Bobby R. Bruce
a41c6f8d84 misc: Remove PMC/Maintainers list from MAINTAINERS.yaml
Change-Id: I772fa31d0aeea5534355731d841cf2d118fa0df4
2023-08-10 15:48:13 -07:00
Bobby R. Bruce
557d532bc3 misc: Add Jason Lowe-Power as website expert
Change-Id: I52ebce434732bb921efc040397a9aa9538a6d1d9
2023-08-10 15:46:02 -07:00
Bobby R. Bruce
77e63b6a6c cpu-o3: bugfix of rename squash when SMT (#172)
In an SMT CPU, upon a squash, the mis-predicted(squashing) instructions
can still be executing at IEW and own phys registers. If these registers
are added back to the rename freelist on this Tick, the registers may be
renamed to be used by other SMT thread(s). This causes register
ownership hazards, which may eventually freeze the CPU. This problem
seems to date back to 2014
(https://www.mail-archive.com/gem5-users@gem5.org/msg10180.html).

This patch delays the freelist update to avoid the hazard.

I tested that this patch does not cause any performance impact for my
set of benchmarks on default non-SMT O3CPU.
2023-08-10 15:29:51 -07:00
Jason Lowe-Power
b88e60ff28 cpu: Fix segment fault when using debug flags Branch (#169) 2023-08-10 08:33:48 -07:00
He, Wenjian
03c2b4692c cpu-o3: bugfix of rename squash when SMT
In an SMT CPU, upon a squash, the phys regs used by
mispredicted instructions can still be owned by executing
instructions in IEW. If the regs are added back to freelist
on this tick, the reg may be renamed to be used by another
SMT thread. This causes reg ownership hazard, which may
eventually freeze the CPU.

This patch delays the freelist update to avoid the hazard.

Change-Id: I993b3c7d357269f01146db61fc8a7b83a989ea45
2023-08-10 21:43:09 +08:00
Roger Chang
f54777419d cpu: Fix ?: error due to different type
Change-Id: I35c50fbba047fe05cc0cc29c631002a9b68795fd
2023-08-10 14:36:26 +08:00
rogerchang23424
81e3bfcdc3 cpu: Update src/cpu/pred/bpred_unit.cc
Change-Id: I0cf177676d0f9fb9db4b127d5507ba66904739c4
Co-authored-by: Jason Lowe-Power <jason@lowepower.com>
2023-08-10 14:36:12 +08:00
Roger Chang
97e55fc173 cpu: Fix segment fault when using debug flags Branch
Change-Id: I36624b93f53aa101a57d51f3b917696cb2809136
2023-08-10 07:36:50 +08:00
Bobby R. Bruce
4cac85cb80 arch-riscv: Add checking CSR condition for RVV instructions (#170)
If status.vs == OFF, the RVV instruction should raise Illegal
Instruction according to RISC-V V spec. If RVV is not implemented, all
of the RVV instruction need to raise exception.
2023-08-09 13:47:56 -07:00
Roger Chang
42c2ed6c2d arch-riscv: Add condition for setting misa and mstatus CSR
Change-Id: I7e03b60d0de32fe8169dd79ded485d560aca64aa
2023-08-09 19:32:04 +08:00
Roger Chang
43adc5309a arch-riscv: Add Illegal Instruction Fault Condition for RVV Config
Check the status.vs and misa.rvv CSR registers before executing
RVV instructions

Change-Id: I0355b94ea8ee4018be11a75aab8c19b10cb36126
2023-08-09 19:31:58 +08:00
Roger Chang
85549842c7 arch-riscv: Add Illegal Instruction Fault Condition for Mem RVV
Check the status.vs and misa.rvv CSR registers before executing
RVV instructions

Change-Id: If1f6a440713612b9a044de4f320997e99722c06c
2023-08-09 19:22:32 +08:00
Roger Chang
c18e43a0ab arch-riscv: Add Illegal Instruction Fault Condition for Arith RVV
Check the status.vs and misa.rvv CSR registers before executing
RVV instructions

Change-Id: Idc143e1ba90320254926de9fa7a7b343bb96ba88
2023-08-09 19:20:53 +08:00
Bobby R. Bruce
572c6bc1bb misc: Update where runners are cleaned in workflow files (#163)
This moves the clean runner step in our yaml files to be at the
beginning of a job, so that if a runner goes down and is unable to clean
at the end, we can ensure that
subsequent jobs still run as expected.

Change-Id: Iba52694aefe03c550ad0bfdb5b5f938305273988
2023-08-08 12:42:24 -07:00
Bobby R. Bruce
faed0d3f6d tests: Temporarily cease using PARSEC disk image in tests (#164)
Due to a 60GB limit on the VMs the gem5 project's GitHub Actions
self-hosted Runners execute within, we cannot run tests which need to
download the gem5 Resource's PARSEC disk image (v1.0.0,
http://resources.gem5.org/resources/x86-parsec?version=1.0.0). This
image, 33GB, is too big and causes our runners to run out of disk space
and fail.

These changes can be reverted when we are able to increase the size of
our VMs.
2023-08-08 00:24:25 -07:00
Bobby R. Bruce
dc31883a2d tests: Update resource downloading test to skip x86-parsec
The x86-parsec gem5 Resource (v1.0.0,
http://resources.gem5.org/resources/x86-parsec?version=1.0.0) is 33GB.
The gem5 GitHub Actions self-hosted runners do not have enough Disk
Space in the VMs they are run to download this. Ergo we skip it.

Change-Id: I290fe265f03ceca65b2bed87e9f4a4ad601e0fc1
2023-08-07 15:30:09 -07:00
Bobby R. Bruce
b86bc7b1ed tests: Add '--skip' arg to "download_check.py"
This argument allows the passing of IDs of resources which should be
skipped for this check.

Note: A current limitation here is you cannot specify the version of a
resource. Passing the ID of a resource to this will skip the downloading
for all versions of that resource.

Change-Id: Ifdb7c2b71553126fd52a3d286897ed5dd8e98f7c
2023-08-07 15:30:09 -07:00
Bobby R. Bruce
f21c5d0d78 tests: Disable PARSEC benchmark tests
These tests are disabled due our GitHub Actions self-hosted Runners
having a 60GB of disk space. The PARSEC Disk Image Resource (v1.0.0,
http://resources.gem5.org/resources/x86-parsec?version=1.0.0) is 33GB
and is simply too big to download and unzip for these tests.

These tests can be reenabled when this issue is resolved.

Change-Id: I9a63aa1903cea3ce7942bdc85bcd0b24761d2f29
2023-08-07 15:30:08 -07:00
Melissa Jost
8b6912f331 misc: Update where runners are cleaned in workflow files
This moves the clean runner step in our yaml files to be at the
beginning of a job, so that if a runner goes down and is
unable to clean at the end, we can ensure that
subsequent jobs still run as expected.

Change-Id: Iba52694aefe03c550ad0bfdb5b5f938305273988
2023-08-07 15:05:32 -07:00
Bobby R. Bruce
5200d9ca3d misc: Refactor weekly-tests.yaml (#160)
This adds a matrix to the weekly tests in order to make the file
cleaner.
2023-08-07 14:39:21 -07:00
Melissa Jost
bc2cabbeb5 Merge branch 'develop' into clean-weeklies 2023-08-07 11:32:18 -07:00
Melissa Jost
eb541da32c misc: Refactor weekly-tests.yaml
This adds a matrix to the weekly tests in order to make the file
cleaner.

Change-Id: I830a0bf8b7d0406e9c377fedf2a7edfa5beabf40
2023-08-07 11:30:44 -07:00
Bobby R. Bruce
4114114bed tests: Refactor test configs (#156)
The yaml file changes made here will need to be copied to develop for
our scheduled tests to run properly. In addition, the original comments
on this can be seen here:
https://gem5-review.googlesource.com/c/public/gem5/+/70340/2
2023-08-07 11:18:18 -07:00
Melissa Jost
effca10cb4 tests: Add switcheroo.py to fs configs directory
There was another missing file in the configs for the fs tests,
so this should allow the switcheroo tests to pass.

Change-Id: Ic4e26cceeb9209f176158b80eaaba88b47968c39
2023-08-04 17:57:51 -07:00
Melissa Jost
bd6a1f5b4b Merge branch 'develop' into refactor-test-configs 2023-08-04 14:54:30 -07:00
Bobby R. Bruce
3d39bc160c misc: Fix daily tests (#158)
The dailies timed out as they were running the entire directory of tests
due to a wrong variable name being used. In addition, the names of tests
were adjusted to include the matrix type so the artifacts won't
overwrite each other
2023-08-04 14:38:12 -07:00
Melissa Jost
4376e5fa9f tests: Add checkpoint.py to fs tests directory
The configs directory for the fs tests was missing the
checkpoint.py file, causing some of the CI tests to fail.

Change-Id: Ifbd775ad658f96d06bea7bee554fe3bedcf5a5b5
2023-08-04 14:19:49 -07:00
Jason Lowe-Power
7a9f7f51ae arch-riscv: Implemented zicbom/zicboz extensions for RISC V (#137) 2023-08-04 11:39:34 -07:00
Jason Lowe-Power
ed44df5d02 util: fix cpt upgrader for rvv changes in PR #83 (#115)
Solves issue #106 by updating the cpts with the necessary vector
registers.
2023-08-04 11:35:28 -07:00
Adrià Armejach
f777cc143c util: fix cpt upgrader for rvv changes in PR #83
* Solves issue #106 by updating the cpts with the necessary vector
    registers.

Change-Id: Ifeda90e96097f0b0a65338c6b22a8258c932c585

util: clear vector_element field

Change-Id: I6c9ec4e71f66722b26de030fa139cd626bdb24dc
2023-08-04 13:59:23 +02:00
zmckevitt
14c25a383c arch-riscv: Implemented zicbom/zicboz extensions for RISC V
Change-Id: I79d0e6059a2dbb5a0057c4f7489b999f9e803684
2023-08-04 10:05:15 +08:00
Bobby R. Bruce
6e39f2097d tests: download_check.py to rm each resource after check (#152)
"tests/gem5/configs/download_check.py" is used by the
"test-resource-downloading" test (defined in
"tests/gem5/gem5-resources/test_download_resources.py" and ran as part
of the "very-long" suite).

Prior to this change "download_check.py" would download each resource,
check it's md5, then at the end of the script remove all the downloaded
resources. This is inefficient on disk space and was causing our
"very-long" suite of tests to require a machines with a lot of disk
space to run.

This change alters 'download_check.py" to remove each resource after the
md5 check. Thus, only one resource is ever downloaded and present at any
given time during the running of this script.
2023-08-03 17:28:58 -07:00
Melissa Jost
e7c8a12349 misc: Fix daily tests
The dailies timed out as they were running the entire directory
of tests due to a wrong variable named being used.  In addition,
the names of tests were adjusted to include the matrix type so
the artifacts won't overwrite each other

Change-Id: Iaa1be8e0cfcbf9d64f1a674590bfe2bf1f0dae90
2023-08-03 17:00:07 -07:00
Jason Lowe-Power
0ff485f7d0 stdlib, resources: fixed style issue in isa.hh (#149)
Changed "rv_type" to "rvType".

Change-Id: I7432a87d7a37324777385707854aefba2475b98c
2023-08-03 16:52:52 -07:00
Bobby R. Bruce
2bef8efb94 stdlib, resources: Fixed keyerror: 'is_zipped' bug (#153)
Change-Id: I68fffd880983ebc225ec6fc8c7f8d509759b581d
2023-08-03 16:01:07 -07:00
Melissa Jost
298b1fafb4 misc: Update test names in daily and weekly yaml files
Updates the directories in which tests are run in accordance
with the refactoring of the testing directory

Change-Id: I93f5c5b0236c5180da04deb425ec2ed6804fa003
2023-08-03 15:57:24 -07:00
Bobby R. Bruce
23f78159ec misc: Add 'experts' field to MAINTAINERS.yaml
This field was added to give gem5 community members a change to register
that they have expertise in a particular subsystem but do not much to
assign themselves the responsibilities of a subsystem maintainer.

Those who have registered interest on being an subsystem expert have
been added.

Change-Id: I8f532e381e8e42257b2a68ac48204131479d8cd0
2023-08-03 14:58:56 -07:00
Bobby R. Bruce
3f1518a1c2 misc: Update subsystem maintainers in MAINTAINERS.yaml
This change incorporates changes to the set of maintainers and the
maintainers assigned to each subsystem based on individual maintainers'
preferences.

Change-Id: Ic2c39907763282e89936fa0d90e3c1a105a0d917
2023-08-03 14:58:49 -07:00
Bobby R. Bruce
5e6095fecc misc: Update MAINTAINERS.yaml documentation comment
This comment is updated to reflect new gem5 policy and its move to
GitHub and a Pull Request contribution model.

Change-Id: Iec909ffa0cca254fdbe56ce3165cb948cdd0cbce
2023-08-03 14:58:40 -07:00
Harshil Patel
23f5535ef5 Merge branch 'develop' into riscv-fix-style 2023-08-03 13:32:53 -07:00
Harshil Patel
5cfac2cc94 stdlib: Fixed stype issue pcstate.hh
- Changed _rv_type to _rvType.
- Changed rv_type to rvType.

Change-Id: I27bdf342b038f5ebae78b104a29892684265584a
2023-08-03 13:04:17 -07:00
Harshil Patel
a25ca04851 stdlib, resources: Fixed keyerror: 'is_zipped' bug
Change-Id: I68fffd880983ebc225ec6fc8c7f8d509759b581d
2023-08-03 10:59:11 -07:00
Bobby R. Bruce
0855c58538 tests: download_check.py to rm each resource after check
"tests/gem5/configs/download_check.py" is used by the
"test-resource-downloading" test (defined in
"tests/gem5/gem5-resources/test_download_resources.py" and ran as part
of the "very-long" suite).

Prior to this change "download_check.py" would download each resource,
check it's md5, then at the end of the script remove all the downloaded
resources. This is inefficient on disk space and was causing our
"very-long" suite of tests to require a machines with a lot of disk
space to run.

This change alters 'download_check.py" to remove each resource after the
md5 check. Thus, only one resource is ever downloaded and present at any
given time during the running of this script.

Change-Id: I38fce100ab09f66c256ccddbcb6f29763839ac40
2023-08-03 10:48:44 -07:00