d1d6b4cb9e
Initiate_MaitainCoherence would not trigger a writeback if tbe.dataMaybeDirtyUpstream is set due to the assumption that the upstream cache would writeback any dirty data. However this is not the case if we use this action finalize a CleanUnique, e.g.: - L1-A has data in SC - L1-B has data in SD - L2 has data in RUSD (L2 is an exclusive cache) - L1-A sends CleanUnique to L2 - L2 invalidates L1-B and receives dirty data. - L2 acks the CleanUnique; L1-A is now UC - L2 has the dirty data but drops it because dataMaybeDirtyUpstream - L1-A doesn't modify the data and eventually evicts it with WriteEvict - Data from WriteEvicts are dropped at the HNF and we lose the line This patch removes the tbe.dataMaybeDirtyUpstream check. Instead it only skips the WriteBack if an upstream cache is in SD state, when it's guaranteed it will writeback the dirty data. JIRA: https://gem5.atlassian.net/browse/GEM5-1195 Change-Id: I6722bc25068b0c44afcf261abc8824f1d80c09f9 Signed-off-by: Tiago Mück <tiago.muck@arm.com> Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/57392 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Daecheol You <daecheol.you@samsung.com> Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Maintainer: Jason Lowe-Power <power.jg@gmail.com>
This is the gem5 simulator. The main website can be found at http://www.gem5.org A good starting point is http://www.gem5.org/about, and for more information about building the simulator and getting started please see http://www.gem5.org/documentation and http://www.gem5.org/documentation/learning_gem5/introduction. To build gem5, you will need the following software: g++ or clang, Python (gem5 links in the Python interpreter), SCons, zlib, m4, and lastly protobuf if you want trace capture and playback support. Please see http://www.gem5.org/documentation/general_docs/building for more details concerning the minimum versions of these tools. Once you have all dependencies resolved, type 'scons build/<CONFIG>/gem5.opt' where CONFIG is one of the options in build_opts like ARM, NULL, MIPS, POWER, SPARC, X86, Garnet_standalone, etc. This will build an optimized version of the gem5 binary (gem5.opt) with the the specified configuration. See http://www.gem5.org/documentation/general_docs/building for more details and options. The main source tree includes these subdirectories: - build_opts: pre-made default configurations for gem5 - build_tools: tools used internally by gem5's build process. - configs: example simulation configuration scripts - ext: less-common external packages needed to build gem5 - include: include files for use in other programs - site_scons: modular components of the build system - src: source code of the gem5 simulator - system: source for some optional system software for simulated systems - tests: regression tests - util: useful utility programs and files To run full-system simulations, you may need compiled system firmware, kernel binaries and one or more disk images, depending on gem5's configuration and what type of workload you're trying to run. Many of those resources can be downloaded from http://resources.gem5.org, and/or from the git repository here: https://gem5.googlesource.com/public/gem5-resources/ If you have questions, please send mail to gem5-users@gem5.org Enjoy using gem5 and please share your modifications and extensions.