derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

arch-arm: Set UNCACHEABLE flag in Request in SE mode (#515)

Browse Source 
As pointed out by [1], Arm doesn't seem to respect the cacheability
attribute when mapping uncacheable memory. This is because the request
is not tagged as uncacheable during SE translation With this patch we
are checking for the cacheability attribute before finalizing
translation

[1]: https://github.com/gem5/gem5/issues/509

Change-Id: I42df0e119af61763971d5766ae764a540055781b

Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
This commit is contained in:
Giacomo Travaglini
2023-10-30 10:43:22 +00:00
committed by GitHub
parent 06bf783a85
commit d131ff488e
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/arch/arm/mmu.cc
View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2010-2013, 2016-2022 Arm Limited
* Copyright (c) 2010-2013, 2016-2023 Arm Limited
* All rights reserved
*
* The license below extends only to copyright in the software and shall
@@ -263,14 +263,17 @@ MMU::translateSe(const RequestPtr &req, ThreadContext *tc, Mode mode,
}
}
Addr paddr;
Process *p = tc->getProcessPtr();
if (!p->pTable->translate(vaddr, paddr))
if (const auto pte = p->pTable->lookup(vaddr); !pte) {
return std::make_shared<GenericPageTableFault>(vaddr_tainted);
req->setPaddr(paddr);
} else {
req->setPaddr(pte->paddr + p->pTable->pageOffset(vaddr));
return finalizePhysical(req, tc, mode);
if (pte->flags & EmulationPageTable::Uncacheable)
req->setFlags(Request::UNCACHEABLE);
return finalizePhysical(req, tc, mode);
}
}
Fault