derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

base: Stop "using namespace Debug" in DPRINTF style macros.

Browse Source 
This is apparently not relied on by anything, and could lead to
surprising name lookups since it's not obvious that name lookup is
different in DPRINTF.

Change-Id: Ic2084ac14b85babe49c9d759575b3b03cb432061
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/44985
Reviewed-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br>
Maintainer: Giacomo Travaglini <giacomo.travaglini@arm.com>
Tested-by: kokoro <noreply+kokoro@google.com>
This commit is contained in:
Gabe Black
2021-04-29 19:40:25 -07:00
parent 1cd7e3471d
commit 82d85ed1ec
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/base/trace.hh
View File

@@ -169,14 +169,12 @@ const std::string &name();
#if TRACING_ON
#define DDUMP(x, data, count) do { \
using namespace Debug; \
if (M5_UNLIKELY(DTRACE(x))) \
Trace::getDebugLogger()->dump( \
curTick(), name(), data, count, #x); \
} while (0)
#define DPRINTF(x, ...) do { \
using namespace Debug; \
if (M5_UNLIKELY(DTRACE(x))) { \
Trace::getDebugLogger()->dprintf_flag( \
curTick(), name(), #x, __VA_ARGS__); \
@@ -184,7 +182,6 @@ const std::string &name();
} while (0)
#define DPRINTFS(x, s, ...) do { \
using namespace Debug; \
if (M5_UNLIKELY(DTRACE(x))) { \
Trace::getDebugLogger()->dprintf_flag( \
curTick(), s->name(), #x, __VA_ARGS__); \
@@ -192,7 +189,6 @@ const std::string &name();
} while (0)
#define DPRINTFR(x, ...) do { \
using namespace Debug; \
if (M5_UNLIKELY(DTRACE(x))) { \
Trace::getDebugLogger()->dprintf_flag( \
(Tick)-1, std::string(), #x, __VA_ARGS__); \