From 82d85ed1ecf23a19aec7404750c0a555759dc5ef Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Thu, 29 Apr 2021 19:40:25 -0700 Subject: [PATCH] base: Stop "using namespace Debug" in DPRINTF style macros. This is apparently not relied on by anything, and could lead to surprising name lookups since it's not obvious that name lookup is different in DPRINTF. Change-Id: Ic2084ac14b85babe49c9d759575b3b03cb432061 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/44985 Reviewed-by: Giacomo Travaglini Reviewed-by: Daniel Carvalho Maintainer: Giacomo Travaglini Tested-by: kokoro --- src/base/trace.hh | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/base/trace.hh b/src/base/trace.hh index 86dec09773..36fcee4217 100644 --- a/src/base/trace.hh +++ b/src/base/trace.hh @@ -169,14 +169,12 @@ const std::string &name(); #if TRACING_ON #define DDUMP(x, data, count) do { \ - using namespace Debug; \ if (M5_UNLIKELY(DTRACE(x))) \ Trace::getDebugLogger()->dump( \ curTick(), name(), data, count, #x); \ } while (0) #define DPRINTF(x, ...) do { \ - using namespace Debug; \ if (M5_UNLIKELY(DTRACE(x))) { \ Trace::getDebugLogger()->dprintf_flag( \ curTick(), name(), #x, __VA_ARGS__); \ @@ -184,7 +182,6 @@ const std::string &name(); } while (0) #define DPRINTFS(x, s, ...) do { \ - using namespace Debug; \ if (M5_UNLIKELY(DTRACE(x))) { \ Trace::getDebugLogger()->dprintf_flag( \ curTick(), s->name(), #x, __VA_ARGS__); \ @@ -192,7 +189,6 @@ const std::string &name(); } while (0) #define DPRINTFR(x, ...) do { \ - using namespace Debug; \ if (M5_UNLIKELY(DTRACE(x))) { \ Trace::getDebugLogger()->dprintf_flag( \ (Tick)-1, std::string(), #x, __VA_ARGS__); \