derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

configs: Remove unused argument from create_mem_intf

Browse Source 
The number of memory controllers is not actually used by the
create_mem_intf function

Change-Id: I8663b38938de9b62b778679c1bc5c7c6e15a60da
Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/42075
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
Maintainer: Jason Lowe-Power <power.jg@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>
This commit is contained in:
Giacomo Travaglini
2021-03-04 11:13:07 +00:00
parent 605399893c
commit 60f7618a0f
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
configs/common/MemConfig.py
View File

@@ -37,7 +37,7 @@ import m5.objects
from common import ObjectList
from common import HMC
def create_mem_intf(intf, r, i, nbr_mem_ctrls, intlv_bits, intlv_size,
def create_mem_intf(intf, r, i, intlv_bits, intlv_size,
xor_low_bit):
"""
Helper function for creating a single memoy controller from the given
@@ -199,7 +199,7 @@ def config_mem(options, system):
for i in range(nbr_mem_ctrls):
if opt_mem_type and (not opt_nvm_type or range_iter % 2 != 0):
# Create the DRAM interface
dram_intf = create_mem_intf(intf, r, i, nbr_mem_ctrls,
dram_intf = create_mem_intf(intf, r, i,
intlv_bits, intlv_size, opt_xor_low_bit)
# Set the number of ranks based on the command-line
@@ -223,8 +223,9 @@ def config_mem(options, system):
mem_ctrls.append(mem_ctrl)
elif opt_nvm_type and (not opt_mem_type or range_iter % 2 == 0):
nvm_intf = create_mem_intf(n_intf, r, i, nbr_mem_ctrls,
nvm_intf = create_mem_intf(n_intf, r, i,
intlv_bits, intlv_size, opt_xor_low_bit)
# Set the number of ranks based on the command-line
# options if it was explicitly set
if issubclass(n_intf, m5.objects.NVMInterface) and \

2
configs/ruby/Ruby.py
View File

@@ -136,7 +136,7 @@ def setup_memory_controllers(system, ruby, dir_cntrls, options):
for r in system.mem_ranges:
mem_type = ObjectList.mem_list.get(options.mem_type)
dram_intf = MemConfig.create_mem_intf(mem_type, r, index,
options.num_dirs, int(math.log(options.num_dirs, 2)),
int(math.log(options.num_dirs, 2)),
intlv_size, options.xor_low_bit)
if issubclass(mem_type, DRAMInterface):
mem_ctrl = m5.objects.MemCtrl(dram = dram_intf)