misc: Remove unused params() definitions

Lots of times the params() helper has been defined but not used

Change-Id: Id71829aca71341d46964d8f071099342b946b62f
Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/41613
Tested-by: kokoro <noreply+kokoro@google.com>

src/arch/arm/fastmodel/iris/interrupts.hh

@@ -38,7 +38,7 @@ namespace Iris
 class Interrupts : public BaseInterrupts
 {
   public:
-    PARAMS(IrisInterrupts);
+    using Params = IrisInterruptsParams;
 
     Interrupts(const Params &p) : BaseInterrupts(p) {}
 

src/arch/arm/freebsd/se_workload.hh

@@ -46,7 +46,7 @@ namespace ArmISA
 class EmuFreebsd : public SEWorkload
 {
   public:
-    PARAMS(ArmEmuFreebsd);
+    using Params = ArmEmuFreebsdParams;
 
     EmuFreebsd(const Params &p) : SEWorkload(p) {}
 

src/arch/arm/interrupts.hh

@@ -73,8 +73,7 @@ class Interrupts : public BaseInterrupts
     uint64_t intStatus;
 
   public:
-
-    PARAMS(ArmInterrupts);
+    using Params = ArmInterruptsParams;
 
     Interrupts(const Params &p) : BaseInterrupts(p)
     {

src/arch/arm/linux/se_workload.hh

@@ -40,7 +40,8 @@ namespace ArmISA
 class EmuLinux : public SEWorkload
 {
   public:
-    PARAMS(ArmEmuLinux);
+    using Params = ArmEmuLinuxParams;
+
     EmuLinux(const Params &p) : SEWorkload(p) {}
 
     struct BaseSyscallABI {};

src/arch/arm/nativetrace.hh

@@ -96,7 +96,7 @@ class ArmNativeTrace : public NativeTrace
     bool stopOnPCError;
 
   public:
-    PARAMS(ArmNativeTrace);
+    using Params = ArmNativeTraceParams;
 
     ArmNativeTrace(const Params &p) :
         NativeTrace(p), stopOnPCError(p.stop_on_pc_error)

src/arch/arm/se_workload.hh

@@ -38,7 +38,8 @@ namespace ArmISA
 class SEWorkload : public ::SEWorkload
 {
   public:
-    PARAMS(ArmSEWorkload);
+    using Params = ArmSEWorkloadParams;
+
     SEWorkload(const Params &p) : ::SEWorkload(p) {}
 
     ::Loader::Arch getArch() const override { return ::Loader::Arm64; }

src/arch/arm/tlb.hh

@@ -204,7 +204,7 @@ class TLB : public BaseTLB
     int rangeMRU; //On lookup, only move entries ahead when outside rangeMRU
 
   public:
-    PARAMS(ArmTLB);
+    using Params = ArmTLBParams;
     TLB(const Params &p);
     TLB(const Params &p, int _size, TableWalker *_walker);
 

src/arch/generic/interrupts.hh

@@ -41,7 +41,7 @@ class BaseInterrupts : public SimObject
     ThreadContext *tc = nullptr;
 
   public:
-    PARAMS(BaseInterrupts);
+    using Params = BaseInterruptsParams;
 
     BaseInterrupts(const Params &p) : SimObject(p) {}
 

src/arch/mips/interrupts.hh

@@ -47,7 +47,7 @@ namespace MipsISA
 class Interrupts : public BaseInterrupts
 {
   public:
-    PARAMS(MipsInterrupts);
+    using Params = MipsInterruptsParams;
 
     Interrupts(const Params &p) : BaseInterrupts(p) {}
 

src/arch/mips/isa.hh

@@ -54,7 +54,7 @@ namespace MipsISA
         // The MIPS name for this file is CP0 or Coprocessor 0
         typedef ISA CP0;
 
-        PARAMS(MipsISA);
+        using Params = MipsISAParams;
 
       protected:
         // Number of threads and vpes an individual ISA state can handle

src/arch/mips/linux/se_workload.hh

@@ -44,7 +44,7 @@ class EmuLinux : public SEWorkload
     static SyscallDescTable<SyscallABI> syscallDescs;
 
   public:
-    PARAMS(MipsEmuLinux);
+    using Params = MipsEmuLinuxParams;
 
     EmuLinux(const Params &p) : SEWorkload(p) {}
 

src/arch/mips/se_workload.hh

@@ -40,7 +40,7 @@ namespace MipsISA
 class SEWorkload : public ::SEWorkload
 {
   public:
-    PARAMS(MipsSEWorkload);
+    using Params = MipsSEWorkloadParams;
 
     SEWorkload(const Params &p) : ::SEWorkload(p) {}
 

src/arch/power/interrupts.hh

@@ -41,7 +41,7 @@ namespace PowerISA {
 class Interrupts : public BaseInterrupts
 {
   public:
-    PARAMS(PowerInterrupts);
+    using Params = PowerInterruptsParams;
 
     Interrupts(const Params &p) : BaseInterrupts(p) {}
 

src/arch/power/isa.hh

@@ -52,8 +52,6 @@ class ISA : public BaseISA
     RegVal miscRegs[NumMiscRegs];
 
   public:
-    PARAMS(PowerISA);
-
     void clear() {}
 
   public:
@@ -128,6 +126,8 @@ class ISA : public BaseISA
         return reg;
     }
 
+    using Params = PowerISAParams;
+
     ISA(const Params &p);
 };
 

src/arch/power/linux/se_workload.hh

@@ -45,7 +45,7 @@ class EmuLinux : public SEWorkload
     static SyscallDescTable<SEWorkload::SyscallABI> syscallDescs;
 
   public:
-    PARAMS(PowerEmuLinux);
+    using Params = PowerEmuLinuxParams;
 
     EmuLinux(const Params &p) : SEWorkload(p) {}
 

src/arch/power/se_workload.hh

@@ -40,7 +40,7 @@ namespace PowerISA
 class SEWorkload : public ::SEWorkload
 {
   public:
-    PARAMS(PowerSEWorkload);
+    using Params = PowerSEWorkloadParams;
     SEWorkload(const Params &p) : ::SEWorkload(p) {}
 
     ::Loader::Arch getArch() const override { return ::Loader::Power; }

src/arch/riscv/interrupts.hh

@@ -57,7 +57,7 @@ class Interrupts : public BaseInterrupts
     std::bitset<NumInterruptTypes> ie;
 
   public:
-    PARAMS(RiscvInterrupts);
+    using Params = RiscvInterruptsParams;
 
     Interrupts(const Params &p) : BaseInterrupts(p), ip(0), ie(0) {}
 

src/arch/riscv/isa.hh

@@ -76,7 +76,7 @@ class ISA : public BaseISA
     bool hpmCounterEnabled(int counter) const;
 
   public:
-    PARAMS(RiscvISA);
+    using Params = RiscvISAParams;
 
     void clear();
 

src/arch/riscv/linux/se_workload.hh

@@ -49,7 +49,7 @@ class EmuLinux : public SEWorkload
     static SyscallDescTable<SEWorkload::SyscallABI> syscallDescs32;
 
   public:
-    PARAMS(RiscvEmuLinux);
+    using Params = RiscvEmuLinuxParams;
 
     EmuLinux(const Params &p) : SEWorkload(p) {}
 

src/arch/riscv/pagetable_walker.hh

@@ -191,7 +191,7 @@ namespace RiscvISA
             tlb = _tlb;
         }
 
-        PARAMS(RiscvPagetableWalker);
+        using Params = RiscvPagetableWalkerParams;
 
         Walker(const Params &params) :
             ClockedObject(params), port(name() + ".port", this),

src/arch/riscv/se_workload.hh

@@ -40,7 +40,7 @@ namespace RiscvISA
 class SEWorkload : public ::SEWorkload
 {
   public:
-    PARAMS(RiscvSEWorkload);
+    using Params = RiscvSEWorkloadParams;
 
     SEWorkload(const Params &p) : ::SEWorkload(p) {}
 

src/arch/sparc/interrupts.hh

@@ -61,7 +61,7 @@ class Interrupts : public BaseInterrupts
 
   public:
 
-    PARAMS(SparcInterrupts);
+    using Params = SparcInterruptsParams;
 
     Interrupts(const Params &p) : BaseInterrupts(p)
     {

src/arch/sparc/isa.hh

@@ -221,7 +221,7 @@ class ISA : public BaseISA
         return readMiscRegNoEffect(MISCREG_MMU_P_CONTEXT);
     }
 
-    PARAMS(SparcISA);
+    using Params = SparcISAParams;
 
     ISA(const Params &p);
 };

src/arch/sparc/linux/se_workload.hh

@@ -50,7 +50,7 @@ class EmuLinux : public SEWorkload
     void syscall32(ThreadContext *tc);
 
   public:
-    PARAMS(SparcEmuLinux);
+    using Params = SparcEmuLinuxParams;
 
     EmuLinux(const Params &p);
 

src/arch/x86/fs_workload.hh

@@ -71,7 +71,7 @@ void installSegDesc(ThreadContext *tc, SegmentRegIndex seg,
 class FsWorkload : public KernelWorkload
 {
   public:
-    PARAMS(X86FsWorkload);
+    using Params = X86FsWorkloadParams;
     FsWorkload(const Params &p);
 
   public:

src/arch/x86/interrupts.hh

@@ -190,7 +190,7 @@ class Interrupts : public BaseInterrupts
     /*
      * Params stuff.
      */
-    PARAMS(X86LocalApic);
+    using Params = X86LocalApicParams;
 
     void setThreadContext(ThreadContext *_tc) override;
 

src/arch/x86/isa.hh

@@ -57,7 +57,7 @@ namespace X86ISA
       public:
         void clear();
 
-        PARAMS(X86ISA);
+        using Params = X86ISAParams;
 
         ISA(const Params &p);
 

src/arch/x86/linux/se_workload.hh

@@ -52,7 +52,7 @@ namespace X86ISA
 class EmuLinux : public SEWorkload
 {
   public:
-    PARAMS(X86EmuLinux);
+    using Params = X86EmuLinuxParams;
 
     EmuLinux(const Params &p);
 

src/arch/x86/pagetable_walker.hh

@@ -193,7 +193,7 @@ namespace X86ISA
             tlb = _tlb;
         }
 
-        PARAMS(X86PagetableWalker);
+        using Params = X86PagetableWalkerParams;
 
         Walker(const Params &params) :
             ClockedObject(params), port(name() + ".port", this),

src/dev/arm/gic_v2.hh

@@ -475,7 +475,7 @@ class GicV2 : public BaseGic, public BaseGicRegisters
     int pendingDelayedInterrupts;
 
   public:
-    PARAMS(GicV2);
+    using Params = GicV2Params;
     GicV2(const Params &p);
     ~GicV2();
 

src/dev/arm/pl111.hh

@@ -356,7 +356,7 @@ class Pl111: public AmbaDmaDevice
     bool enableCapture;
 
   public:
-    PARAMS(Pl111);
+    using Params = Pl111Params;
     Pl111(const Params &p);
     ~Pl111();
 

src/dev/arm/realview.hh

@@ -63,7 +63,7 @@ class RealView : public Platform
     BaseGic *gic;
 
   public:
-    PARAMS(RealView);
+    using Params = RealViewParams;
 
     /**
      * Constructor for the Tsunami Class.

src/dev/arm/rtc_pl031.hh

@@ -97,7 +97,7 @@ class PL031 : public AmbaIntDevice
     void resyncMatch();
 
   public:
-    PARAMS(PL031);
+    using Params = PL031Params;
 
     /**
       * The constructor for RealView just registers itself with the MMU.

src/dev/arm/timer_a9global.hh

@@ -149,7 +149,7 @@ class A9GlobalTimer : public BasicPioDevice
     Timer global_timer;
 
   public:
-    PARAMS(A9GlobalTimer);
+    using Params = A9GlobalTimerParams;
 
     /**
       * The constructor for RealView just registers itself with the MMU.

src/dev/arm/timer_sp804.hh

@@ -135,7 +135,7 @@ class Sp804 : public AmbaPioDevice
     Timer timer1;
 
   public:
-    PARAMS(Sp804);
+    using Params = Sp804Params;
 
     /**
       * The constructor for RealView just registers itself with the MMU.

src/dev/arm/vgic.hh

@@ -186,7 +186,7 @@ class VGic : public PioDevice
     struct std::array<vcpuIntData, VGIC_CPU_MAX>  vcpuData;
 
   public:
-    PARAMS(VGic);
+    using Params = VGicParams;
     VGic(const Params &p);
     ~VGic();
 

src/dev/baddev.hh

@@ -49,7 +49,7 @@ class BadDevice : public BasicPioDevice
     std::string devname;
 
   public:
-    PARAMS(BadDevice);
+    using Params = BadDeviceParams;
 
     /**
      * Constructor for the Baddev Class.

src/dev/io_device.hh

@@ -128,7 +128,7 @@ class PioDevice : public ClockedObject
     virtual Tick write(PacketPtr pkt) = 0;
 
   public:
-    PARAMS(PioDevice);
+    using Params = PioDeviceParams;
     PioDevice(const Params &p);
     virtual ~PioDevice();
 

src/dev/mips/malta_cchip.hh

@@ -76,7 +76,7 @@ class MaltaCChip : public BasicPioDevice
     //uint64_t itint;
 
   public:
-    PARAMS(MaltaCChip);
+    using Params = MaltaCChipParams;
 
     /**
      * Initialize the Malta CChip by setting all of the

src/dev/net/dist_etherlink.hh

@@ -215,7 +215,7 @@ class DistEtherLink : public SimObject
     Tick linkDelay;
 
   public:
-    PARAMS(DistEtherLink);
+    using Params = DistEtherLinkParams;
     DistEtherLink(const Params &p);
     ~DistEtherLink();
 

src/dev/net/etherbus.hh

@@ -55,7 +55,7 @@ class EtherBus : public SimObject
     EtherDump *dump;
 
   public:
-    PARAMS(EtherBus);
+    using Params = EtherBusParams;
     EtherBus(const Params &p);
     virtual ~EtherBus() {}
 

src/dev/net/etherdevice.hh

@@ -45,7 +45,7 @@ class EtherInt;
 class EtherDevice : public PciDevice
 {
   public:
-    PARAMS(EtherDevice);
+    using Params = EtherDeviceParams;
     EtherDevice(const Params &params)
         : PciDevice(params),
           etherDeviceStats(this)
@@ -140,7 +140,7 @@ class EtherDevice : public PciDevice
 class EtherDevBase : public EtherDevice
 {
   public:
-    PARAMS(EtherDevBase);
+    using Params = EtherDevBaseParams;
     EtherDevBase(const Params &params)
         : EtherDevice(params)
     {}

src/dev/net/etherlink.hh

@@ -140,7 +140,7 @@ class EtherLink : public SimObject
     Interface *interface[2];
 
   public:
-    PARAMS(EtherLink);
+    using Params = EtherLinkParams;
     EtherLink(const Params &p);
     virtual ~EtherLink();
 

src/dev/net/etherswitch.hh

@@ -51,7 +51,7 @@
 class EtherSwitch : public SimObject
 {
   public:
-    PARAMS(EtherSwitch);
+    using Params = EtherSwitchParams;
 
     EtherSwitch(const Params &p);
     ~EtherSwitch();

src/dev/net/ethertap.hh

@@ -56,7 +56,7 @@ class EtherTapInt;
 class EtherTapBase : public SimObject
 {
   public:
-    PARAMS(EtherTapBase);
+    using Params = EtherTapBaseParams;
     EtherTapBase(const Params &p);
     virtual ~EtherTapBase();
 
@@ -130,7 +130,7 @@ class TapListener;
 class EtherTapStub : public EtherTapBase
 {
   public:
-    PARAMS(EtherTapStub);
+    using Params = EtherTapStubParams;
     EtherTapStub(const Params &p);
     ~EtherTapStub();
 
@@ -159,7 +159,7 @@ class EtherTapStub : public EtherTapBase
 class EtherTap : public EtherTapBase
 {
   public:
-    PARAMS(EtherTap);
+    using Params = EtherTapParams;
     EtherTap(const Params &p);
     ~EtherTap();
 

src/dev/serial/uart.hh

@@ -51,7 +51,7 @@ class Uart : public BasicPioDevice
     SerialDevice *device;
 
   public:
-    PARAMS(Uart);
+    using Params = UartParams;
     Uart(const Params &p, Addr pio_size);
 
     /**

src/dev/serial/uart8250.hh

@@ -209,7 +209,7 @@ class Uart8250 : public Uart
     EventFunctionWrapper rxIntrEvent;
 
   public:
-    PARAMS(Uart8250);
+    using Params = Uart8250Params;
     Uart8250(const Params &p);
 
     Tick read(PacketPtr pkt) override;

src/dev/sparc/dtod.hh

@@ -49,7 +49,7 @@ class DumbTOD : public BasicPioDevice
     uint64_t todTime;
 
   public:
-    PARAMS(DumbTOD);
+    using Params = DumbTODParams;
     DumbTOD(const Params &p);
 
     Tick read(PacketPtr pkt) override;

src/dev/sparc/mm_disk.hh

@@ -47,7 +47,7 @@ class MmDisk : public BasicPioDevice
     uint8_t diskData[SectorSize];
 
   public:
-    PARAMS(MmDisk);
+    using Params = MmDiskParams;
     MmDisk(const Params &p);
 
     Tick read(PacketPtr pkt) override;

src/dev/x86/i8042.hh

@@ -117,7 +117,7 @@ class I8042 : public BasicPioDevice
     uint8_t readDataOut();
 
   public:
-    PARAMS(I8042);
+    using Params = I8042Params;
 
     I8042(const Params &p);
 

src/dev/x86/i82094aa.hh

@@ -85,7 +85,7 @@ class I82094AA : public BasicPioDevice
     IntRequestPort<I82094AA> intRequestPort;
 
   public:
-    PARAMS(I82094AA);
+    using Params = I82094AAParams;
 
     I82094AA(const Params &p);
 

src/dev/x86/i8237.hh

@@ -92,7 +92,7 @@ class I8237 : public BasicPioDevice
     void setMaskBit(Register &reg, const uint8_t &command);
 
   public:
-    PARAMS(I8237);
+    using Params = I8237Params;
 
     I8237(const Params &p);
 

src/dev/x86/i8254.hh

@@ -66,7 +66,7 @@ class I8254 : public BasicPioDevice
     void counterInterrupt(unsigned int num);
 
   public:
-    PARAMS(I8254);
+    using Params = I8254Params;
 
     Port &
     getPort(const std::string &if_name, PortID idx=InvalidPortID) override

src/dev/x86/i8259.hh

@@ -81,7 +81,7 @@ class I8259 : public BasicPioDevice
     void handleEOI(int line);
 
   public:
-    PARAMS(I8259);
+    using Params = I8259Params;
 
     I8259(const Params &p);
 

src/dev/x86/south_bridge.hh

@@ -55,7 +55,7 @@ class SouthBridge : public SimObject
     X86ISA::I82094AA * ioApic;
 
   public:
-    PARAMS(SouthBridge);
+    using Params = SouthBridgeParams;
     SouthBridge(const Params &p);
 };
 

src/dev/x86/speaker.hh

@@ -54,7 +54,7 @@ class Speaker : public BasicPioDevice
     I8254 * timer;
 
   public:
-    PARAMS(PcSpeaker);
+    using Params = PcSpeakerParams;
 
     Speaker(const Params &p) : BasicPioDevice(p, 1),
         latency(p.pio_latency), controlVal(0), timer(p.i8254)

src/gpu-compute/lds_state.hh

@@ -259,7 +259,7 @@ class LdsState: public ClockedObject
                        unsigned *numBankAccesses);
 
   public:
-    PARAMS(LdsState);
+    using Params = LdsStateParams;
 
     LdsState(const Params &params);
 

src/mem/comm_monitor.hh

@@ -63,7 +63,7 @@ class CommMonitor : public SimObject
   public: // Construction & SimObject interfaces
 
     /** Parameters of communication monitor */
-    PARAMS(CommMonitor);
+    using Params = CommMonitorParams;
 
     /**
      * Constructor based on the Python params

src/mem/mem_checker_monitor.hh

@@ -52,7 +52,7 @@ class MemCheckerMonitor : public SimObject
   public:
 
     /** Parameters of memchecker monitor */
-    PARAMS(MemCheckerMonitor);
+    using Params = MemCheckerMonitorParams;
 
     /**
      * Constructor based on the Python params

src/mem/qos/policy_pf.hh

@@ -58,7 +58,7 @@ namespace QoS {
  */
 class PropFairPolicy : public Policy
 {
-    PARAMS(QoSPropFairPolicy);
+    using Params = QoSPropFairPolicyParams;
 
   public:
     PropFairPolicy(const Params &);

src/mem/ruby/network/fault_model/FaultModel.hh

@@ -53,7 +53,7 @@
 class FaultModel : public SimObject
 {
   public:
-    PARAMS(FaultModel);
+    using Params = FaultModelParams;
     FaultModel(const Params &p);
 
     /************************************************************************/

src/sim/clocked_object.hh

@@ -234,7 +234,7 @@ class ClockedObject : public SimObject, public Clocked
     ClockedObject(const ClockedObjectParams &p);
 
     /** Parameters of ClockedObject */
-    PARAMS(ClockedObject);
+    using Params = ClockedObjectParams;
 
     void serialize(CheckpointOut &cp) const override;
     void unserialize(CheckpointIn &cp) override;

src/sim/se_workload.hh

@@ -34,7 +34,7 @@
 class SEWorkload : public Workload
 {
   public:
-    PARAMS(SEWorkload);
+    using Params = SEWorkloadParams;
 
     SEWorkload(const Params &p);