derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

configs: Fix component classic cache prefetchers

Browse Source 
The prefetchers were instatiated as class variables instead of
instance variables. This change fixes the problem

Change-Id: I7263c9e7ddb138d2f9ad10024ea7f0e7d860dda9
Signed-off-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49430
Reviewed-by: Bobby R. Bruce <bbruce@ucdavis.edu>
Maintainer: Bobby R. Bruce <bbruce@ucdavis.edu>
Tested-by: kokoro <noreply+kokoro@google.com>
This commit is contained in:
Jason Lowe-Power
2021-08-19 13:25:10 -07:00
committed by Jason Lowe-Power
parent 0e5aa3da42
commit 182f79c3da
3 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
components_library/cachehierarchies/classic/caches/l1dcache.py
View File

@@ -28,7 +28,7 @@ from ....utils.override import *
from m5.objects import Cache, BasePrefetcher, StridePrefetcher
from typing import Optional
from typing import Optional, Type
class L1DCache(Cache):
@@ -46,7 +46,7 @@ class L1DCache(Cache):
mshrs: Optional[int] = 16,
tgts_per_mshr: Optional[int] = 20,
writeback_clean: Optional[bool] = True,
prefetcher: BasePrefetcher = StridePrefetcher(),
PrefetcherCls: Type[BasePrefetcher] = StridePrefetcher,
):
super(L1DCache, self).__init__()
self.size = size
@@ -57,4 +57,4 @@ class L1DCache(Cache):
self.mshrs = mshrs
self.tgts_per_mshr = tgts_per_mshr
self.writeback_clean = writeback_clean
self.prefetcher = prefetcher
self.prefetcher = PrefetcherCls()

6
components_library/cachehierarchies/classic/caches/l1icache.py
View File

@@ -24,7 +24,7 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
from typing import Optional
from typing import Optional, Type
from m5.objects import Cache, BasePrefetcher, StridePrefetcher
@@ -46,7 +46,7 @@ class L1ICache(Cache):
mshrs: Optional[int] = 16,
tgts_per_mshr: Optional[int] = 20,
writeback_clean: Optional[bool] = True,
prefetcher: BasePrefetcher = StridePrefetcher(),
PrefetcherCls: Type[BasePrefetcher] = StridePrefetcher,
):
super(L1ICache, self).__init__()
self.size = size
@@ -57,4 +57,4 @@ class L1ICache(Cache):
self.mshrs = mshrs
self.tgts_per_mshr = tgts_per_mshr
self.writeback_clean = writeback_clean
self.prefetcher = prefetcher
self.prefetcher = PrefetcherCls()

6
components_library/cachehierarchies/classic/caches/l2cache.py
View File

@@ -28,7 +28,7 @@ from ....utils.override import *
from m5.objects import Cache, BasePrefetcher, StridePrefetcher
from typing import Optional
from typing import Optional, Type
class L2Cache(Cache):
@@ -46,7 +46,7 @@ class L2Cache(Cache):
mshrs: Optional[int] = 20,
tgts_per_mshr: Optional[int] = 12,
writeback_clean: Optional[bool] = True,
prefetcher: BasePrefetcher = StridePrefetcher(),
PrefetcherCls: Type[BasePrefetcher] = StridePrefetcher,
):
super(L2Cache, self).__init__()
self.size = size
@@ -57,4 +57,4 @@ class L2Cache(Cache):
self.mshrs = mshrs
self.tgts_per_mshr = tgts_per_mshr
self.writeback_clean = writeback_clean
self.prefetcher = prefetcher
self.prefetcher = PrefetcherCls()