dcf242d838
The is a bug in the GPUCoalescer which occurs in the following situation: 1) An instruction crosses a page boundary causing multiple TLB requests to be sent. 2) The TLB responses arrive at different times, causing the vector memory requests to be sent at different times. 3) The first vector memory request completes before the second vector memory request arrives at the coalescer. This caused the coalescer to consider the instruction sequence number done and return its token. Then the second request would arrive and complete sending back another token. Eventually this increases the token count beyond the maximum tripping an assert. This change keeps track of the number of per-lane requests which are expected to be sent in the vector memory request by looking at the exec mask of the instruction. The token is not returned until the expected number of per-lane requests have been coalesced. This fixes "#7" in the list of issues in JIRA-300. There are also style fixes for local variables in code nearby the changes in this CL. Change-Id: I152fd9397920ad82ba6079112908387e71ff3cce JIRA: https://gem5.atlassian.net/browse/GEM5-300 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/35176 Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com> Reviewed-by: Kyle Roarty <kyleroarty1716@gmail.com> Maintainer: Matt Sinclair <mattdsinclair@gmail.com> Tested-by: kokoro <noreply+kokoro@google.com>
This is the gem5 simulator. The main website can be found at http://www.gem5.org A good starting point is http://www.gem5.org/about, and for more information about building the simulator and getting started please see http://www.gem5.org/documentation and http://www.gem5.org/documentation/learning_gem5/introduction. To build gem5, you will need the following software: g++ or clang, Python (gem5 links in the Python interpreter), SCons, SWIG, zlib, m4, and lastly protobuf if you want trace capture and playback support. Please see http://www.gem5.org/documentation/general_docs/building for more details concerning the minimum versions of the aforementioned tools. Once you have all dependencies resolved, type 'scons build/<ARCH>/gem5.opt' where ARCH is one of ARM, NULL, MIPS, POWER, SPARC, or X86. This will build an optimized version of the gem5 binary (gem5.opt) for the the specified architecture. See http://www.gem5.org/documentation/general_docs/building for more details and options. The basic source release includes these subdirectories: - configs: example simulation configuration scripts - ext: less-common external packages needed to build gem5 - src: source code of the gem5 simulator - system: source for some optional system software for simulated systems - tests: regression tests - util: useful utility programs and files To run full-system simulations, you will need compiled system firmware (console and PALcode for Alpha), kernel binaries and one or more disk images. If you have questions, please send mail to gem5-users@gem5.org Enjoy using gem5 and please share your modifications and extensions.