2be95c4470
Rather than make each ISA include boilerplate to ignore a SyscallReturn's value when it's marked as suppressed or needing a retry, put that code into the SyscallDesc::doSyscall method instead. That has two benefits. First, it removes a decent amount of code duplication which is nice from a maintenance perspective. Second, it puts the SyscallDesc in charge of figuring out what to do once a system call implementation finishes. That will let it schedule a retry of the system call for instance, without worrying about what the ISA is doing with the SyscallReturn behind its back. Jira Issue: https://gem5.atlassian.net/browse/GEM5-1123 Change-Id: I3732a98c8e0d0b2b94d61313960aa0782c0b971f Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/54023 Maintainer: Gabe Black <gabe.black@gmail.com> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
95 lines
3.0 KiB
C++
95 lines
3.0 KiB
C++
/*
|
|
* Copyright 2020 Google Inc.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are
|
|
* met: redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer;
|
|
* redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution;
|
|
* neither the name of the copyright holders nor the names of its
|
|
* contributors may be used to endorse or promote products derived from
|
|
* this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef __ARCH_POWER_SE_WORKLOAD_HH__
|
|
#define __ARCH_POWER_SE_WORKLOAD_HH__
|
|
|
|
#include "arch/power/regs/int.hh"
|
|
#include "arch/power/regs/misc.hh"
|
|
#include "arch/power/remote_gdb.hh"
|
|
#include "params/PowerSEWorkload.hh"
|
|
#include "sim/se_workload.hh"
|
|
#include "sim/syscall_abi.hh"
|
|
#include "sim/syscall_desc.hh"
|
|
|
|
namespace gem5
|
|
{
|
|
|
|
namespace PowerISA
|
|
{
|
|
|
|
class SEWorkload : public gem5::SEWorkload
|
|
{
|
|
public:
|
|
using Params = PowerSEWorkloadParams;
|
|
SEWorkload(const Params &p, Addr page_shift) :
|
|
gem5::SEWorkload(p, page_shift)
|
|
{}
|
|
|
|
void
|
|
setSystem(System *sys) override
|
|
{
|
|
gem5::SEWorkload::setSystem(sys);
|
|
gdb = BaseRemoteGDB::build<RemoteGDB>(system);
|
|
}
|
|
|
|
loader::Arch getArch() const override { return loader::Power; }
|
|
|
|
struct SyscallABI : public GenericSyscallABI64
|
|
{
|
|
static const std::vector<int> ArgumentRegs;
|
|
};
|
|
};
|
|
|
|
} // namespace PowerISA
|
|
|
|
GEM5_DEPRECATED_NAMESPACE(GuestABI, guest_abi);
|
|
namespace guest_abi
|
|
{
|
|
|
|
template <>
|
|
struct Result<PowerISA::SEWorkload::SyscallABI, SyscallReturn>
|
|
{
|
|
static void
|
|
store(ThreadContext *tc, const SyscallReturn &ret)
|
|
{
|
|
PowerISA::Cr cr = tc->readIntReg(PowerISA::INTREG_CR);
|
|
if (ret.successful()) {
|
|
cr.cr0.so = 0;
|
|
} else {
|
|
cr.cr0.so = 1;
|
|
}
|
|
tc->setIntReg(PowerISA::INTREG_CR, cr);
|
|
tc->setIntReg(PowerISA::ReturnValueReg, ret.encodedValue());
|
|
}
|
|
};
|
|
|
|
} // namespace guest_abi
|
|
} // namespace gem5
|
|
|
|
#endif // __ARCH_POWER_SE_WORKLOAD_HH__
|