92132b2984
The stdio fgetc returns the character read as an unsigned char cast to an int. The reason why it gets casted from unsigned char to int is because EOF is defined as a negative value (usually -1). At the moment in the atomicio.test we store the int in a char. However the C standard states that the sign of a char is implementation specific. This makes the test non portable: an architecture/ABI which which is considering a char as a unsigned char won't compile since a unsigned value will always be != -1 (EOF). This is the error message you would get on a aarch64 host /w gcc/5.4.0 build/ARM/base/atomicio.test.cc:121:48: error: comparison is always true due to limited range of data type [-Werror=type-limits] Change-Id: I120e44b5204d98e643f19b8dd6fa2762342a6e64 Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com> Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/25384 Reviewed-by: Ciro Santilli <ciro.santilli@arm.com> Reviewed-by: Jason Lowe-Power <jason@lowepower.com> Tested-by: kokoro <noreply+kokoro@google.com>
This is the gem5 simulator. The main website can be found at http://www.gem5.org A good starting point is http://www.gem5.org/about, and for more information about building the simulator and getting started please see http://www.gem5.org/documentation and http://www.gem5.org/documentation/learning_gem5/introduction. To build gem5, you will need the following software: g++ or clang, Python (gem5 links in the Python interpreter), SCons, SWIG, zlib, m4, and lastly protobuf if you want trace capture and playback support. Please see http://www.gem5.org/documentation/general_docs/building for more details concerning the minimum versions of the aforementioned tools. Once you have all dependencies resolved, type 'scons build/<ARCH>/gem5.opt' where ARCH is one of ALPHA, ARM, NULL, MIPS, POWER, SPARC, or X86. This will build an optimized version of the gem5 binary (gem5.opt) for the the specified architecture. See http://www.gem5.org/documentation/general_docs/building for more details and options. The basic source release includes these subdirectories: - configs: example simulation configuration scripts - ext: less-common external packages needed to build gem5 - src: source code of the gem5 simulator - system: source for some optional system software for simulated systems - tests: regression tests - util: useful utility programs and files To run full-system simulations, you will need compiled system firmware (console and PALcode for Alpha), kernel binaries and one or more disk images. If you have questions, please send mail to gem5-users@gem5.org Enjoy using gem5 and please share your modifications and extensions.