c4aaf373aa
This should help reduce warning spew when building with newer compilers. The pybind11::module type has been renamed pybind11::module_ to avoid conflicts with c++20 modules, according to the pybind11 changelog, so this CL also updates gem5 source to use the new type. There is supposedly an alias pybind11::module which is for compatibility, but we still get linker errors without changing to pybind11::module_. Change-Id: I0acb36215b33e3a713866baec43f5af630c356ee Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40255 Maintainer: Bobby R. Bruce <bbruce@ucdavis.edu> Reviewed-by: Bobby R. Bruce <bbruce@ucdavis.edu> Tested-by: kokoro <noreply+kokoro@google.com>
45 lines
1.4 KiB
Bash
Executable File
45 lines
1.4 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Script to check include/test code for common pybind11 code style errors.
|
|
#
|
|
# This script currently checks for
|
|
#
|
|
# 1. missing space between keyword and parenthesis, e.g.: for(, if(, while(
|
|
# 2. Missing space between right parenthesis and brace, e.g. 'for (...){'
|
|
# 3. opening brace on its own line. It should always be on the same line as the
|
|
# if/while/for/do statement.
|
|
#
|
|
# Invoke as: tools/check-style.sh <filenames>
|
|
#
|
|
|
|
check_style_errors=0
|
|
IFS=$'\n'
|
|
|
|
|
|
found="$(grep '\<\(if\|for\|while\|catch\)(\|){' $@ -rn --color=always)"
|
|
if [ -n "$found" ]; then
|
|
echo -e '\033[31;01mError: found the following coding style problems:\033[0m'
|
|
check_style_errors=1
|
|
echo "$found" | sed -e 's/^/ /'
|
|
fi
|
|
|
|
found="$(awk '
|
|
function prefix(filename, lineno) {
|
|
return " \033[35m" filename "\033[36m:\033[32m" lineno "\033[36m:\033[0m"
|
|
}
|
|
function mark(pattern, string) { sub(pattern, "\033[01;31m&\033[0m", string); return string }
|
|
last && /^\s*{/ {
|
|
print prefix(FILENAME, FNR-1) mark("\\)\\s*$", last)
|
|
print prefix(FILENAME, FNR) mark("^\\s*{", $0)
|
|
last=""
|
|
}
|
|
{ last = /(if|for|while|catch|switch)\s*\(.*\)\s*$/ ? $0 : "" }
|
|
' $(find include -type f) $@)"
|
|
if [ -n "$found" ]; then
|
|
check_style_errors=1
|
|
echo -e '\033[31;01mError: braces should occur on the same line as the if/while/.. statement. Found issues in the following files:\033[0m'
|
|
echo "$found"
|
|
fi
|
|
|
|
exit $check_style_errors
|