derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Eliminate unused PacketPtr from BaseCache's

Browse Source 
RequestEvent and ResponseEvent.
Compiles but not tested.

--HG--
extra : convert_revision : cc791e7adea5b0406e986a0076edba51856b9105
This commit is contained in:
Steve Reinhardt
2007-05-13 23:09:10 -07:00
parent df3fc36fa9
commit fecae03a0b
2 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/mem/cache/base_cache.cc vendored
View File

@@ -229,7 +229,6 @@ BaseCache::RequestEvent::RequestEvent(CachePort *_cachePort, Tick when)
: Event(&mainEventQueue, CPU_Tick_Pri), cachePort(_cachePort)
{
this->setFlags(AutoDelete);
pkt = NULL;
schedule(when);
}
@@ -266,7 +265,7 @@ BaseCache::RequestEvent::process()
return;
}
pkt = cachePort->cache->getPacket();
PacketPtr pkt = cachePort->cache->getPacket();
MSHR* mshr = (MSHR*) pkt->senderState;
//Copy the packet, it may be modified/destroyed elsewhere
PacketPtr copyPkt = new Packet(*pkt);
@@ -288,7 +287,6 @@ BaseCache::RequestEvent::process()
DPRINTF(CachePort, "%s still more MSHR requests to send\n",
cachePort->name());
//Still more to issue, rerequest in 1 cycle
pkt = NULL;
this->schedule(curTick+1);
}
}
@@ -296,7 +294,7 @@ BaseCache::RequestEvent::process()
{
//CSHR
assert(cachePort->cache->doSlaveRequest());
pkt = cachePort->cache->getCoherencePacket();
PacketPtr pkt = cachePort->cache->getCoherencePacket();
MSHR* cshr = (MSHR*) pkt->senderState;
bool success = cachePort->sendTiming(pkt);
cachePort->cache->sendCoherenceResult(pkt, cshr, success);
@@ -308,7 +306,6 @@ BaseCache::RequestEvent::process()
DPRINTF(CachePort, "%s still more CSHR requests to send\n",
cachePort->name());
//Still more to issue, rerequest in 1 cycle
pkt = NULL;
this->schedule(curTick+1);
}
}
@@ -323,7 +320,6 @@ BaseCache::RequestEvent::description()
BaseCache::ResponseEvent::ResponseEvent(CachePort *_cachePort)
: Event(&mainEventQueue, CPU_Tick_Pri), cachePort(_cachePort)
{
pkt = NULL;
}
void
@@ -331,7 +327,7 @@ BaseCache::ResponseEvent::process()
{
assert(cachePort->transmitList.size());
assert(cachePort->transmitList.front().first <= curTick);
pkt = cachePort->transmitList.front().second;
PacketPtr pkt = cachePort->transmitList.front().second;
cachePort->transmitList.pop_front();
if (!cachePort->transmitList.empty()) {
Tick time = cachePort->transmitList.front().first;

2
src/mem/cache/base_cache.hh vendored
View File

@@ -120,7 +120,6 @@ class BaseCache : public MemObject
struct RequestEvent : public Event
{
CachePort *cachePort;
PacketPtr pkt;
RequestEvent(CachePort *_cachePort, Tick when);
void process();
@@ -130,7 +129,6 @@ class BaseCache : public MemObject
struct ResponseEvent : public Event
{
CachePort *cachePort;
PacketPtr pkt;
ResponseEvent(CachePort *_cachePort);
void process();