derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dev: move dprint of reg name before register read/write (#1684)

Browse Source 
Originally, the debug print for read/write to specific register name
will happen after reg.read() and reg.write(). However, there might be
other debug print or warning inside reg.read(), reg.write() which would
be confusing if this debug log happen after all other debug print inside
reg.read(), reg.write().

Creating this commit to change the order.
This commit is contained in:
Harry Chiang
2024-10-22 17:12:38 +08:00
committed by GitHub
parent 16217f843f
commit fce42880b9
1 changed files with 14 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/dev/reg_bank.hh
View File

@@ -1040,7 +1040,6 @@ class RegisterBank : public RegisterBankBase
if (it == _offsetMap.end() || it->first > addr)
it--;
std::ostringstream ss;
while (done != bytes) {
RegisterBase &reg = it->second.get();
const Addr reg_off = addr - it->first;
@@ -1049,13 +1048,17 @@ class RegisterBank : public RegisterBankBase
if (reg_bytes != reg.size()) {
if (_debug_flag) {
ccprintf(ss, "Read register %s, byte offset %d, size %d\n",
reg.name(), reg_off, reg_bytes);
::gem5::trace::getDebugLogger()->dprintf_flag(
curTick(), name(), _debug_flag->name(),
"Read register %s, byte offset %d, size %d\n",
reg.name(), reg_off, reg_bytes);
}
reg.read(ptr + done, reg_off, reg_bytes);
} else {
if (_debug_flag) {
ccprintf(ss, "Read register %s\n", reg.name());
::gem5::trace::getDebugLogger()->dprintf_flag(
curTick(), name(), _debug_flag->name(),
"Read register %s\n", reg.name());
}
reg.read(ptr + done);
}
@@ -1064,11 +1067,6 @@ class RegisterBank : public RegisterBankBase
addr += reg_bytes;
++it;
}
if (_debug_flag) {
::gem5::trace::getDebugLogger()->dprintf_flag(
curTick(), name(), _debug_flag->name(), "%s", ss.str());
}
}
virtual void
@@ -1086,7 +1084,6 @@ class RegisterBank : public RegisterBankBase
if (it == _offsetMap.end() || it->first > addr)
it--;
std::ostringstream ss;
while (done != bytes) {
RegisterBase &reg = it->second.get();
const Addr reg_off = addr - it->first;
@@ -1095,13 +1092,17 @@ class RegisterBank : public RegisterBankBase
if (reg_bytes != reg.size()) {
if (_debug_flag) {
ccprintf(ss, "Write register %s, byte offset %d, size %d\n",
reg.name(), reg_off, reg_size);
::gem5::trace::getDebugLogger()->dprintf_flag(
curTick(), name(), _debug_flag->name(),
"Write register %s, byte offset %d, size %d\n",
reg.name(), reg_off, reg_size);
}
reg.write(ptr + done, reg_off, reg_bytes);
} else {
if (_debug_flag) {
ccprintf(ss, "Write register %s\n", reg.name());
::gem5::trace::getDebugLogger()->dprintf_flag(
curTick(), name(), _debug_flag->name(),
"Write register %s\n", reg.name());
}
reg.write(ptr + done);
}
@@ -1111,10 +1112,6 @@ class RegisterBank : public RegisterBankBase
++it;
}
if (_debug_flag) {
::gem5::trace::getDebugLogger()->dprintf_flag(
curTick(), name(), _debug_flag->name(), "%s", ss.str());
}
}
// By default, reset all the registers in the bank.