derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mem: Explicitly specify the endianness in the abstract memory.

Browse Source 
The accessors are used for debugging output. If we're using an ISA
where there's an endianness, we use that explicitly, falling back to a
binary dump if the size isn't supported. If not, then we just dump the
data without interpretation regardless of size.

Change-Id: Ib050c4c876ee41f17cfd14ad657150bf6ab1de39
Reviewed-on: https://gem5-review.googlesource.com/c/13464
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Maintainer: Gabe Black <gabeblack@google.com>
This commit is contained in:
Gabe Black
2018-10-12 05:11:20 -07:00
parent 095d7fba32
commit eb8989ec76
1 changed files with 20 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
src/mem/abstract_mem.cc
View File

@@ -289,38 +289,29 @@ AbstractMemory::checkLockedAddrList(PacketPtr pkt)
return allowStore;
}
static inline void
tracePacket(System *sys, const char *label, PacketPtr pkt)
{
int size = pkt->getSize();
#if THE_ISA != NULL_ISA
if (size == 1 || size == 2 || size == 4 || size == 8) {
DPRINTF(MemoryAccess,"%s from %s of size %i on address %#x data "
"%#x %c\n", label, sys->getMasterName(pkt->req->masterId()),
size, pkt->getAddr(), pkt->getUintX(TheISA::GuestByteOrder),
pkt->req->isUncacheable() ? 'U' : 'C');
return;
}
#endif
DPRINTF(MemoryAccess, "%s from %s of size %i on address %#x %c\n",
label, sys->getMasterName(pkt->req->masterId()),
size, pkt->getAddr(), pkt->req->isUncacheable() ? 'U' : 'C');
DDUMP(MemoryAccess, pkt->getConstPtr<uint8_t>(), pkt->getSize());
}
#if TRACING_ON
#define CASE(A, T) \
case sizeof(T): \
DPRINTF(MemoryAccess,"%s from %s of size %i on address 0x%x data " \
"0x%x %c\n", A, system()->getMasterName(pkt->req->masterId()),\
pkt->getSize(), pkt->getAddr(), pkt->get<T>(), \
pkt->req->isUncacheable() ? 'U' : 'C'); \
break
#define TRACE_PACKET(A) \
do { \
switch (pkt->getSize()) { \
CASE(A, uint64_t); \
CASE(A, uint32_t); \
CASE(A, uint16_t); \
CASE(A, uint8_t); \
default: \
DPRINTF(MemoryAccess, "%s from %s of size %i on address 0x%x %c\n",\
A, system()->getMasterName(pkt->req->masterId()), \
pkt->getSize(), pkt->getAddr(), \
pkt->req->isUncacheable() ? 'U' : 'C'); \
DDUMP(MemoryAccess, pkt->getConstPtr<uint8_t>(), pkt->getSize()); \
} \
} while (0)
# define TRACE_PACKET(A) tracePacket(system(), A, pkt)
#else
#define TRACE_PACKET(A)
# define TRACE_PACKET(A)
#endif
void