derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

learning-gem5: fix int_links warning

Browse Source 
Update the Part 3 config file examples in learning gem5 to resolve a
warning with int_links.  Some files were initializing self.int_links vector
to an empty list of SimObjects.  This causes a warning.

The fix resolves this by initializing self.int_links to a pre-declared
int_links variable.

Change-Id: Iaa38a4db9cc42a949879d571d1372f0b0a456f11
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/60829
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com>
Maintainer: Jason Lowe-Power <power.jg@gmail.com>
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
This commit is contained in:
Jarvis Jia
2022-06-28 21:16:32 -05:00
committed by Jarvis JIA
parent e54efbd8e9
commit eb85b173dd
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
configs/learning_gem5/part3/msi_caches.py
View File

@@ -234,11 +234,12 @@ class MyNetwork(SimpleNetwork):
# Make an "internal" link (internal to the network) between every pair
# of routers.
link_count = 0
self.int_links = []
int_links = []
for ri in self.routers:
for rj in self.routers:
if ri == rj: continue # Don't connect a router to itself!
link_count += 1
self.int_links.append(SimpleIntLink(link_id = link_count,
int_links.append(SimpleIntLink(link_id = link_count,
src_node = ri,
dst_node = rj))
self.int_links = int_links

5
configs/learning_gem5/part3/ruby_caches_MI_example.py
View File

@@ -219,11 +219,12 @@ class MyNetwork(SimpleNetwork):
# Make an "internal" link (internal to the network) between every pair
# of routers.
link_count = 0
self.int_links = []
int_links = []
for ri in self.routers:
for rj in self.routers:
if ri == rj: continue # Don't connect a router to itself!
link_count += 1
self.int_links.append(SimpleIntLink(link_id = link_count,
int_links.append(SimpleIntLink(link_id = link_count,
src_node = ri,
dst_node = rj))
self.int_links = int_links