From eb85b173ddb6cdb6c38056e2847a5b1230600a8b Mon Sep 17 00:00:00 2001 From: Jarvis Jia Date: Tue, 28 Jun 2022 21:16:32 -0500 Subject: [PATCH] learning-gem5: fix int_links warning Update the Part 3 config file examples in learning gem5 to resolve a warning with int_links. Some files were initializing self.int_links vector to an empty list of SimObjects. This causes a warning. The fix resolves this by initializing self.int_links to a pre-declared int_links variable. Change-Id: Iaa38a4db9cc42a949879d571d1372f0b0a456f11 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/60829 Tested-by: kokoro Reviewed-by: Matt Sinclair Maintainer: Jason Lowe-Power Reviewed-by: Jason Lowe-Power --- configs/learning_gem5/part3/msi_caches.py | 5 +++-- configs/learning_gem5/part3/ruby_caches_MI_example.py | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/configs/learning_gem5/part3/msi_caches.py b/configs/learning_gem5/part3/msi_caches.py index 957adf2baf..c6d1531ab0 100644 --- a/configs/learning_gem5/part3/msi_caches.py +++ b/configs/learning_gem5/part3/msi_caches.py @@ -234,11 +234,12 @@ class MyNetwork(SimpleNetwork): # Make an "internal" link (internal to the network) between every pair # of routers. link_count = 0 - self.int_links = [] + int_links = [] for ri in self.routers: for rj in self.routers: if ri == rj: continue # Don't connect a router to itself! link_count += 1 - self.int_links.append(SimpleIntLink(link_id = link_count, + int_links.append(SimpleIntLink(link_id = link_count, src_node = ri, dst_node = rj)) + self.int_links = int_links diff --git a/configs/learning_gem5/part3/ruby_caches_MI_example.py b/configs/learning_gem5/part3/ruby_caches_MI_example.py index b67e6b1791..38540d5065 100644 --- a/configs/learning_gem5/part3/ruby_caches_MI_example.py +++ b/configs/learning_gem5/part3/ruby_caches_MI_example.py @@ -219,11 +219,12 @@ class MyNetwork(SimpleNetwork): # Make an "internal" link (internal to the network) between every pair # of routers. link_count = 0 - self.int_links = [] + int_links = [] for ri in self.routers: for rj in self.routers: if ri == rj: continue # Don't connect a router to itself! link_count += 1 - self.int_links.append(SimpleIntLink(link_id = link_count, + int_links.append(SimpleIntLink(link_id = link_count, src_node = ri, dst_node = rj)) + self.int_links = int_links