derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mem-cache: Fix non-virtual base destructor of Repl Entry

Browse Source 
ReplaceableEntry contains a virtual method, yet its destructor
was not virtual, causing errors in some compilers.

Change-Id: I13deec843f4007d9deb924882a8d98ff6a89c84f
Signed-off-by: Daniel R. Carvalho <odanrc@yahoo.com.br>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/19808
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Maintainer: Nikos Nikoleris <nikos.nikoleris@arm.com>
Tested-by: kokoro <noreply+kokoro@google.com>
This commit is contained in:
Daniel R. Carvalho
2019-08-03 12:04:14 +02:00
committed by Daniel Carvalho
parent 598f704d51
commit e33b3aa669
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/mem/cache/replacement_policies/replaceable_entry.hh vendored
View File

@@ -63,12 +63,15 @@ class ReplaceableEntry
*/
uint32_t _way;
public:
/**
* Replacement data associated to this entry.
* It must be instantiated by the replacement policy before being used.
*/
std::shared_ptr<ReplacementData> replacementData;
public:
ReplaceableEntry() = default;
virtual ~ReplaceableEntry() = default;
/**
* Replacement data associated to this entry.
* It must be instantiated by the replacement policy before being used.
*/
std::shared_ptr<ReplacementData> replacementData;
/**
* Set both the set and way. Should be called only once.