derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sim-se: minor refactor for ProcessParams::create

Browse Source 
Remove the nullptr initialization and change the message
for object file failure.

Change-Id: I14b80b47b65893c55810e7f715c1b8fc643c5125
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/19949
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>
Tested-by: kokoro <noreply+kokoro@google.com>
This commit is contained in:
Brandon Potter
2019-08-08 15:23:01 -04:00
committed by Brandon Potter
parent 29082ef5ce
commit dc5255f1d2
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sim/process.cc
View File

@@ -529,8 +529,6 @@ Process::absolutePath(const std::string &filename, bool host_filesystem)
Process *
ProcessParams::create()
{
Process *process = nullptr;
// If not specified, set the executable parameter equal to the
// simulated system's zeroth command line parameter
if (executable == "") {
@@ -538,9 +536,9 @@ ProcessParams::create()
}
ObjectFile *obj_file = createObjectFile(executable);
fatal_if(!obj_file, "Can't load object file %s", executable);
fatal_if(!obj_file, "Cannot load object file %s.", executable);
process = ObjectFile::tryLoaders(this, obj_file);
Process *process = ObjectFile::tryLoaders(this, obj_file);
fatal_if(!process, "Unknown error creating process object.");
return process;