misc: Delete the now unnecessary create methods.

Most create() methods are no longer necessary. This change deletes them,
and occasionally moves some code from them into the constructors they
call.

Change-Id: Icbab29ba280144b892f9b12fac9e29a0839477e5
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/36536
Reviewed-by: Gabe Black <gabe.black@gmail.com>
Maintainer: Gabe Black <gabe.black@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>

src/mem/cache/base.cc

@@ -2498,9 +2498,3 @@ WriteAllocator::updateMode(Addr write_addr, unsigned write_size,
     }
     nextAddr = write_addr + write_size;
 }
-
-WriteAllocator*
-WriteAllocatorParams::create() const
-{
-    return new WriteAllocator(*this);
-}

src/mem/cache/cache.cc

@@ -67,6 +67,8 @@ Cache::Cache(const CacheParams &p)
     : BaseCache(p, p.system->cacheLineSize()),
       doFastWrites(true)
 {
+    assert(p.tags);
+    assert(p.replacement_policy);
 }
 
 void
@@ -1429,12 +1431,3 @@ Cache::sendMSHRQueuePacket(MSHR* mshr)
 
     return BaseCache::sendMSHRQueuePacket(mshr);
 }
-
-Cache*
-CacheParams::create() const
-{
-    assert(tags);
-    assert(replacement_policy);
-
-    return new Cache(*this);
-}

src/mem/cache/compressors/base_delta.cc

@@ -72,39 +72,3 @@ Base16Delta8::Base16Delta8(const Params &p)
 }
 
 } // namespace Compressor
-
-Compressor::Base64Delta8*
-Base64Delta8Params::create() const
-{
-    return new Compressor::Base64Delta8(*this);
-}
-
-Compressor::Base64Delta16*
-Base64Delta16Params::create() const
-{
-    return new Compressor::Base64Delta16(*this);
-}
-
-Compressor::Base64Delta32*
-Base64Delta32Params::create() const
-{
-    return new Compressor::Base64Delta32(*this);
-}
-
-Compressor::Base32Delta8*
-Base32Delta8Params::create() const
-{
-    return new Compressor::Base32Delta8(*this);
-}
-
-Compressor::Base32Delta16*
-Base32Delta16Params::create() const
-{
-    return new Compressor::Base32Delta16(*this);
-}
-
-Compressor::Base16Delta8*
-Base16Delta8Params::create() const
-{
-    return new Compressor::Base16Delta8(*this);
-}

src/mem/cache/compressors/cpack.cc

@@ -50,9 +50,3 @@ CPack::addToDictionary(DictionaryEntry data)
 }
 
 } // namespace Compressor
-
-Compressor::CPack*
-CPackParams::create() const
-{
-    return new Compressor::CPack(*this);
-}

src/mem/cache/compressors/fpc.cc

@@ -95,9 +95,3 @@ FPC::instantiateDictionaryCompData() const
 }
 
 } // namespace Compressor
-
-Compressor::FPC*
-FPCParams::create() const
-{
-    return new Compressor::FPC(*this);
-}

src/mem/cache/compressors/fpcd.cc

@@ -55,9 +55,3 @@ FPCD::addToDictionary(DictionaryEntry data)
 }
 
 } // namespace Compressor
-
-Compressor::FPCD*
-FPCDParams::create() const
-{
-    return new Compressor::FPCD(*this);
-}

src/mem/cache/compressors/multi.cc

@@ -202,9 +202,3 @@ Multi::MultiStats::regStats()
 }
 
 } // namespace Compressor
-
-Compressor::Multi*
-MultiCompressorParams::create() const
-{
-    return new Compressor::Multi(*this);
-}

src/mem/cache/compressors/perfect.cc

@@ -73,9 +73,3 @@ Perfect::decompress(const CompressionData* comp_data,
 }
 
 } // namespace Compressor
-
-Compressor::Perfect*
-PerfectCompressorParams::create() const
-{
-    return new Compressor::Perfect(*this);
-}

src/mem/cache/compressors/repeated_qwords.cc

@@ -78,9 +78,3 @@ RepeatedQwords::compress(const std::vector<Chunk>& chunks,
 }
 
 } // namespace Compressor
-
-Compressor::RepeatedQwords*
-RepeatedQwordsCompressorParams::create() const
-{
-    return new Compressor::RepeatedQwords(*this);
-}

src/mem/cache/compressors/zero.cc

@@ -76,9 +76,3 @@ Zero::compress(const std::vector<Chunk>& chunks, Cycles& comp_lat,
 }
 
 } // namespace Compressor
-
-Compressor::Zero*
-ZeroCompressorParams::create() const
-{
-    return new Compressor::Zero(*this);
-}

src/mem/cache/noncoherent_cache.cc

@@ -59,6 +59,8 @@
 NoncoherentCache::NoncoherentCache(const NoncoherentCacheParams &p)
     : BaseCache(p, p.system->cacheLineSize())
 {
+    assert(p.tags);
+    assert(p.replacement_policy);
 }
 
 void
@@ -347,12 +349,3 @@ NoncoherentCache::evictBlock(CacheBlk *blk)
 
     return pkt;
 }
-
-NoncoherentCache*
-NoncoherentCacheParams::create() const
-{
-    assert(tags);
-    assert(replacement_policy);
-
-    return new NoncoherentCache(*this);
-}

src/mem/cache/prefetch/access_map_pattern_matching.cc

@@ -264,15 +264,3 @@ AMPM::calculatePrefetch(const PrefetchInfo &pfi,
 }
 
 } // namespace Prefetcher
-
-Prefetcher::AccessMapPatternMatching*
-AccessMapPatternMatchingParams::create() const
-{
-    return new Prefetcher::AccessMapPatternMatching(*this);
-}
-
-Prefetcher::AMPM*
-AMPMPrefetcherParams::create() const
-{
-    return new Prefetcher::AMPM(*this);
-}

src/mem/cache/prefetch/bop.cc

@@ -261,9 +261,3 @@ BOP::notifyFill(const PacketPtr& pkt)
 }
 
 } // namespace Prefetcher
-
-Prefetcher::BOP*
-BOPPrefetcherParams::create() const
-{
-   return new Prefetcher::BOP(*this);
-}

src/mem/cache/prefetch/delta_correlating_prediction_tables.cc

@@ -158,15 +158,3 @@ DCPT::calculatePrefetch(const PrefetchInfo &pfi,
 }
 
 } // namespace Prefetcher
-
-Prefetcher::DeltaCorrelatingPredictionTables*
-DeltaCorrelatingPredictionTablesParams::create() const
-{
-   return new Prefetcher::DeltaCorrelatingPredictionTables(*this);
-}
-
-Prefetcher::DCPT*
-DCPTPrefetcherParams::create() const
-{
-    return new Prefetcher::DCPT(*this);
-}

src/mem/cache/prefetch/indirect_memory.cc

@@ -255,9 +255,3 @@ IndirectMemory::checkAccessMatchOnActiveEntries(Addr addr)
 }
 
 } // namespace Prefetcher
-
-Prefetcher::IndirectMemory*
-IndirectMemoryPrefetcherParams::create() const
-{
-    return new Prefetcher::IndirectMemory(*this);
-}

src/mem/cache/prefetch/irregular_stream_buffer.cc

@@ -209,9 +209,3 @@ IrregularStreamBuffer::addStructuralToPhysicalEntry(
 }
 
 } // namespace Prefetcher
-
-Prefetcher::IrregularStreamBuffer*
-IrregularStreamBufferPrefetcherParams::create() const
-{
-    return new Prefetcher::IrregularStreamBuffer(*this);
-}

src/mem/cache/prefetch/multi.cc

@@ -80,9 +80,3 @@ Multi::getPacket()
 }
 
 } // namespace Prefetcher
-
-Prefetcher::Multi*
-MultiPrefetcherParams::create() const
-{
-    return new Prefetcher::Multi(*this);
-}

src/mem/cache/prefetch/pif.cc

@@ -244,9 +244,3 @@ PIF::addEventProbeRetiredInsts(SimObject *obj, const char *name)
 }
 
 } // namespace Prefetcher
-
-Prefetcher::PIF*
-PIFPrefetcherParams::create() const
-{
-    return new Prefetcher::PIF(*this);
-}

src/mem/cache/prefetch/sbooe.cc

@@ -133,9 +133,3 @@ SBOOE::calculatePrefetch(const PrefetchInfo &pfi,
 }
 
 } // namespace Prefetcher
-
-Prefetcher::SBOOE*
-SBOOEPrefetcherParams::create() const
-{
-    return new Prefetcher::SBOOE(*this);
-}

src/mem/cache/prefetch/signature_path.cc

@@ -317,9 +317,3 @@ SignaturePath::auxiliaryPrefetcher(Addr ppn, stride_t current_block,
 }
 
 } // namespace Prefetcher
-
-Prefetcher::SignaturePath*
-SignaturePathPrefetcherParams::create() const
-{
-    return new Prefetcher::SignaturePath(*this);
-}

src/mem/cache/prefetch/signature_path_v2.cc

@@ -129,9 +129,3 @@ SignaturePathV2::handlePageCrossingLookahead(signature_t signature,
 }
 
 } // namespace Prefetcher
-
-Prefetcher::SignaturePathV2*
-SignaturePathPrefetcherV2Params::create() const
-{
-    return new Prefetcher::SignaturePathV2(*this);
-}

src/mem/cache/prefetch/slim_ampm.cc

@@ -48,9 +48,3 @@ SlimAMPM::calculatePrefetch(const PrefetchInfo &pfi,
 }
 
 } // namespace Prefetcher
-
-Prefetcher::SlimAMPM*
-SlimAMPMPrefetcherParams::create() const
-{
-    return new Prefetcher::SlimAMPM(*this);
-}

src/mem/cache/prefetch/spatio_temporal_memory_streaming.cc

@@ -247,9 +247,3 @@ STeMS::reconstructSequence(
 }
 
 } // namespace Prefetcher
-
-Prefetcher::STeMS*
-STeMSPrefetcherParams::create() const
-{
-   return new Prefetcher::STeMS(*this);
-}

src/mem/cache/prefetch/stride.cc

@@ -202,15 +202,3 @@ StridePrefetcherHashedSetAssociative::extractTag(const Addr addr) const
 }
 
 } // namespace Prefetcher
-
-Prefetcher::StridePrefetcherHashedSetAssociative*
-StridePrefetcherHashedSetAssociativeParams::create() const
-{
-    return new Prefetcher::StridePrefetcherHashedSetAssociative(*this);
-}
-
-Prefetcher::Stride*
-StridePrefetcherParams::create() const
-{
-    return new Prefetcher::Stride(*this);
-}

src/mem/cache/prefetch/tagged.cc

@@ -56,9 +56,3 @@ Tagged::calculatePrefetch(const PrefetchInfo &pfi,
 }
 
 } // namespace Prefetcher
-
-Prefetcher::Tagged*
-TaggedPrefetcherParams::create() const
-{
-   return new Prefetcher::Tagged(*this);
-}

src/mem/cache/replacement_policies/bip_rp.cc

@@ -57,9 +57,3 @@ BIP::reset(const std::shared_ptr<ReplacementData>& replacement_data) const
 }
 
 } // namespace ReplacementPolicy
-
-ReplacementPolicy::BIP*
-BIPRPParams::create() const
-{
-    return new ReplacementPolicy::BIP(*this);
-}

src/mem/cache/replacement_policies/brrip_rp.cc

@@ -145,9 +145,3 @@ BRRIP::instantiateEntry()
 }
 
 } // namespace ReplacementPolicy
-
-ReplacementPolicy::BRRIP*
-BRRIPRPParams::create() const
-{
-    return new ReplacementPolicy::BRRIP(*this);
-}

src/mem/cache/replacement_policies/fifo_rp.cc

@@ -92,9 +92,3 @@ FIFO::instantiateEntry()
 }
 
 } // namespace ReplacementPolicy
-
-ReplacementPolicy::FIFO*
-FIFORPParams::create() const
-{
-    return new ReplacementPolicy::FIFO(*this);
-}

src/mem/cache/replacement_policies/lfu_rp.cc

@@ -90,9 +90,3 @@ LFU::instantiateEntry()
 }
 
 } // namespace ReplacementPolicy
-
-ReplacementPolicy::LFU*
-LFURPParams::create() const
-{
-    return new ReplacementPolicy::LFU(*this);
-}

src/mem/cache/replacement_policies/lru_rp.cc

@@ -94,9 +94,3 @@ LRU::instantiateEntry()
 }
 
 } // namespace ReplacementPolicy
-
-ReplacementPolicy::LRU*
-LRURPParams::create() const
-{
-    return new ReplacementPolicy::LRU(*this);
-}

src/mem/cache/replacement_policies/mru_rp.cc

@@ -99,9 +99,3 @@ MRU::instantiateEntry()
 }
 
 } // namespace ReplacementPolicy
-
-ReplacementPolicy::MRU*
-MRURPParams::create() const
-{
-    return new ReplacementPolicy::MRU(*this);
-}

src/mem/cache/replacement_policies/random_rp.cc

@@ -93,9 +93,3 @@ Random::instantiateEntry()
 }
 
 } // namespace ReplacementPolicy
-
-ReplacementPolicy::Random*
-RandomRPParams::create() const
-{
-    return new ReplacementPolicy::Random(*this);
-}

src/mem/cache/replacement_policies/second_chance_rp.cc

@@ -134,9 +134,3 @@ SecondChance::instantiateEntry()
 }
 
 } // namespace ReplacementPolicy
-
-ReplacementPolicy::SecondChance*
-SecondChanceRPParams::create() const
-{
-    return new ReplacementPolicy::SecondChance(*this);
-}

src/mem/cache/replacement_policies/tree_plru_rp.cc

@@ -212,9 +212,3 @@ TreePLRU::instantiateEntry()
 }
 
 } // namespace ReplacementPolicy
-
-ReplacementPolicy::TreePLRU*
-TreePLRURPParams::create() const
-{
-    return new ReplacementPolicy::TreePLRU(*this);
-}

src/mem/cache/replacement_policies/weighted_lru_rp.cc

@@ -122,9 +122,3 @@ WeightedLRU::invalidate(const std::shared_ptr<ReplacementData>&
 }
 
 } // namespace ReplacementPolicy
-
-ReplacementPolicy::WeightedLRU*
-WeightedLRURPParams::create() const
-{
-    return new ReplacementPolicy::WeightedLRU(*this);
-}

src/mem/cache/tags/base_set_assoc.cc

@@ -54,6 +54,9 @@ BaseSetAssoc::BaseSetAssoc(const Params &p)
      sequentialAccess(p.sequential_access),
      replacementPolicy(p.replacement_policy)
 {
+    // There must be a indexing policy
+    fatal_if(!p.indexing_policy, "An indexing policy is required");
+
     // Check parameters
     if (blkSize < 4 || !isPowerOf2(blkSize)) {
         fatal("Block size must be at least 4 and a power of 2");
@@ -90,12 +93,3 @@ BaseSetAssoc::invalidate(CacheBlk *blk)
     // Invalidate replacement data
     replacementPolicy->invalidate(blk->replacementData);
 }
-
-BaseSetAssoc *
-BaseSetAssocParams::create() const
-{
-    // There must be a indexing policy
-    fatal_if(!indexing_policy, "An indexing policy is required");
-
-    return new BaseSetAssoc(*this);
-}

src/mem/cache/tags/compressed_tags.cc

@@ -204,9 +204,3 @@ CompressedTags::anyBlk(std::function<bool(CacheBlk &)> visitor)
     }
     return false;
 }
-
-CompressedTags *
-CompressedTagsParams::create() const
-{
-    return new CompressedTags(*this);
-}

src/mem/cache/tags/fa_lru.cc

@@ -279,12 +279,6 @@ FALRU::moveToTail(FALRUBlk *blk)
     }
 }
 
-FALRU *
-FALRUParams::create() const
-{
-    return new FALRU(*this);
-}
-
 void
 FALRU::CacheTracking::check(const FALRUBlk *head, const FALRUBlk *tail) const
 {

src/mem/cache/tags/indexing_policies/set_associative.cc

@@ -71,9 +71,3 @@ SetAssociative::getPossibleEntries(const Addr addr) const
 {
     return sets[extractSet(addr)];
 }
-
-SetAssociative*
-SetAssociativeParams::create() const
-{
-    return new SetAssociative(*this);
-}

src/mem/cache/tags/indexing_policies/skewed_associative.cc

@@ -216,9 +216,3 @@ SkewedAssociative::getPossibleEntries(const Addr addr) const
 
     return entries;
 }
-
-SkewedAssociative *
-SkewedAssociativeParams::create() const
-{
-    return new SkewedAssociative(*this);
-}

src/mem/cache/tags/sector_tags.cc

@@ -54,6 +54,9 @@ SectorTags::SectorTags(const SectorTagsParams &p)
       sectorShift(floorLog2(blkSize)), sectorMask(numBlocksPerSector - 1),
       sectorStats(stats, *this)
 {
+    // There must be a indexing policy
+    fatal_if(!p.indexing_policy, "An indexing policy is required");
+
     // Check parameters
     fatal_if(blkSize < 4 || !isPowerOf2(blkSize),
              "Block size must be at least 4 and a power of 2");
@@ -323,12 +326,3 @@ SectorTags::anyBlk(std::function<bool(CacheBlk &)> visitor)
     }
     return false;
 }
-
-SectorTags *
-SectorTagsParams::create() const
-{
-    // There must be a indexing policy
-    fatal_if(!indexing_policy, "An indexing policy is required");
-
-    return new SectorTags(*this);
-}