misc: Delete the now unnecessary create methods.

Most create() methods are no longer necessary. This change deletes them,
and occasionally moves some code from them into the constructors they
call.

Change-Id: Icbab29ba280144b892f9b12fac9e29a0839477e5
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/36536
Reviewed-by: Gabe Black <gabe.black@gmail.com>
Maintainer: Gabe Black <gabe.black@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>

src/dev/arm/a9scu.cc

@@ -103,9 +103,3 @@ A9SCU::write(PacketPtr pkt)
     pkt->makeAtomicResponse();
     return pioDelay;
 }
-
-A9SCU *
-A9SCUParams::create() const
-{
-    return new A9SCU(*this);
-}

src/dev/arm/amba_fake.cc

@@ -81,10 +81,3 @@ AmbaFake::write(PacketPtr pkt)
     pkt->makeAtomicResponse();
     return pioDelay;
 }
-
-
-AmbaFake *
-AmbaFakeParams::create() const
-{
-    return new AmbaFake(*this);
-}

src/dev/arm/base_gic.cc

@@ -194,15 +194,3 @@ ArmPPI::clear()
     _active = false;
     platform->gic->clearPPInt(intNum, targetContext());
 }
-
-ArmSPIGen *
-ArmSPIParams::create() const
-{
-    return new ArmSPIGen(*this);
-}
-
-ArmPPIGen *
-ArmPPIParams::create() const
-{
-    return new ArmPPIGen(*this);
-}

src/dev/arm/display.cc

@@ -42,9 +42,3 @@
 Display::Display(const DisplayParams &p)
   : SimObject(p)
 {}
-
-Display *
-DisplayParams::create() const
-{
-    return new Display(*this);
-}

src/dev/arm/energy_ctrl.cc

@@ -241,12 +241,6 @@ EnergyCtrl::unserialize(CheckpointIn &cp)
     }
 }
 
-EnergyCtrl *
-EnergyCtrlParams::create() const
-{
-    return new EnergyCtrl(*this);
-}
-
 void
 EnergyCtrl::startup()
 {

src/dev/arm/flash_device.cc

@@ -55,17 +55,6 @@
 #include "base/trace.hh"
 #include "debug/Drain.hh"
 
-/**
- * Create this device
- */
-
-FlashDevice*
-FlashDeviceParams::create() const
-{
-    return new FlashDevice(*this);
-}
-
-
 /**
  * Flash Device constructor and destructor
  */

src/dev/arm/fvp_base_pwr_ctrl.cc

@@ -310,9 +310,3 @@ FVPBasePwrCtrl::startCoreUp(ThreadContext *const tc)
     ArmISA::Reset().invoke(tc);
     tc->activate();
 }
-
-FVPBasePwrCtrl *
-FVPBasePwrCtrlParams::create() const
-{
-    return new FVPBasePwrCtrl(*this);
-}

src/dev/arm/generic_timer.cc

@@ -1584,27 +1584,3 @@ GenericTimerMem::timerCtrlWrite(Addr addr, size_t size, uint64_t data,
              "(0x%x:%i), assuming WI\n", addr, size);
     }
 }
-
-SystemCounter *
-SystemCounterParams::create() const
-{
-    return new SystemCounter(*this);
-}
-
-GenericTimer *
-GenericTimerParams::create() const
-{
-    return new GenericTimer(*this);
-}
-
-GenericTimerFrame *
-GenericTimerFrameParams::create() const
-{
-    return new GenericTimerFrame(*this);
-}
-
-GenericTimerMem *
-GenericTimerMemParams::create() const
-{
-    return new GenericTimerMem(*this);
-}

src/dev/arm/gic_v2.cc

@@ -1090,9 +1090,3 @@ GicV2::BankedRegs::unserialize(CheckpointIn &cp)
     UNSERIALIZE_ARRAY(intConfig, 2);
     UNSERIALIZE_ARRAY(intPriority, SGI_MAX + PPI_MAX);
 }
-
-GicV2 *
-GicV2Params::create() const
-{
-    return new GicV2(*this);
-}

src/dev/arm/gic_v2m.cc

@@ -64,18 +64,6 @@
 #include "mem/packet.hh"
 #include "mem/packet_access.hh"
 
-Gicv2m *
-Gicv2mParams::create() const
-{
-    return new Gicv2m(*this);
-}
-
-Gicv2mFrame *
-Gicv2mFrameParams::create() const
-{
-    return new Gicv2mFrame(*this);
-}
-
 Gicv2m::Gicv2m(const Params &p)
     : PioDevice(p), pioDelay(p.pio_delay), frames(p.frames), gic(p.gic)
 {

src/dev/arm/gic_v3.cc

@@ -294,9 +294,3 @@ Gicv3::unserialize(CheckpointIn & cp)
         cpuInterfaces[cpu_interface_id]->unserializeSection(cp,
             csprintf("cpuInterface.%i", cpu_interface_id));
 }
-
-Gicv3 *
-Gicv3Params::create() const
-{
-    return new Gicv3(*this);
-}

src/dev/arm/gic_v3_its.cc

@@ -1286,9 +1286,3 @@ Gicv3Its::moveAllPendingState(
 
     rd2->updateDistributor();
 }
-
-Gicv3Its *
-Gicv3ItsParams::create() const
-{
-    return new Gicv3Its(*this);
-}

src/dev/arm/gpu_nomali.cc

@@ -374,17 +374,3 @@ CustomNoMaliGpu::onReset()
     for (const auto &reg : idRegs)
         writeRegRaw(reg.first, reg.second);
 }
-
-
-
-NoMaliGpu *
-NoMaliGpuParams::create() const
-{
-    return new NoMaliGpu(*this);
-}
-
-CustomNoMaliGpu *
-CustomNoMaliGpuParams::create() const
-{
-    return new CustomNoMaliGpu(*this);
-}

src/dev/arm/hdlcd.cc

@@ -689,10 +689,3 @@ HDLcd::PixelPump::dumpSettings()
     inform("PixelPump vertical fron porch: %u", t.vFrontPorch);
     inform("PixelPump vertical fron porch: %u", t.vSync);
 }
-
-
-HDLcd *
-HDLcdParams::create() const
-{
-    return new HDLcd(*this);
-}

src/dev/arm/kmi.cc

@@ -219,9 +219,3 @@ Pl050::unserialize(CheckpointIn &cp)
     UNSERIALIZE_SCALAR(clkdiv);
     paramIn(cp, "raw_ints", rawInterrupts);
 }
-
-Pl050 *
-Pl050Params::create() const
-{
-    return new Pl050(*this);
-}

src/dev/arm/pci_host.cc

@@ -68,10 +68,3 @@ GenericArmPciHost::mapPciInterrupt(const PciBusAddr &addr, PciIntPin pin) const
         fatal("Unsupported PCI interrupt routing policy.");
     }
 }
-
-
-GenericArmPciHost *
-GenericArmPciHostParams::create() const
-{
-    return new GenericArmPciHost(*this);
-}

src/dev/arm/pl011.cc

@@ -325,9 +325,3 @@ Pl011::unserialize(CheckpointIn &cp)
     paramIn(cp, "imsc_serial", imsc);
     paramIn(cp, "rawInt_serial", rawInt);
 }
-
-Pl011 *
-Pl011Params::create() const
-{
-    return new Pl011(*this);
-}

src/dev/arm/pl111.cc

@@ -742,11 +742,3 @@ Pl111::getAddrRanges() const
     ranges.push_back(RangeSize(pioAddr, pioSize));
     return ranges;
 }
-
-Pl111 *
-Pl111Params::create() const
-{
-    return new Pl111(*this);
-}
-
-

src/dev/arm/realview.cc

@@ -82,9 +82,3 @@ RealView::clearPciInt(int line)
 {
     gic->clearInt(line);
 }
-
-RealView *
-RealViewParams::create() const
-{
-    return new RealView(*this);
-}

src/dev/arm/rtc_pl031.cc

@@ -237,11 +237,3 @@ PL031::unserialize(CheckpointIn &cp)
         schedule(matchEvent, event_time);
     }
 }
-
-
-
-PL031 *
-PL031Params::create() const
-{
-    return new PL031(*this);
-}

src/dev/arm/rv_ctrl.cc

@@ -313,21 +313,3 @@ RealViewTemperatureSensor::read() const
     // Report a dummy 25 degrees temperature
     return 25000000;
 }
-
-RealViewCtrl *
-RealViewCtrlParams::create() const
-{
-    return new RealViewCtrl(*this);
-}
-
-RealViewOsc *
-RealViewOscParams::create() const
-{
-    return new RealViewOsc(*this);
-}
-
-RealViewTemperatureSensor *
-RealViewTemperatureSensorParams::create() const
-{
-    return new RealViewTemperatureSensor(*this);
-}

src/dev/arm/smmu_v3.cc

@@ -826,9 +826,3 @@ SMMUv3::getPort(const std::string &name, PortID id)
         return ClockedObject::getPort(name, id);
     }
 }
-
-SMMUv3*
-SMMUv3Params::create() const
-{
-    return new SMMUv3(*this);
-}

src/dev/arm/smmu_v3_deviceifc.cc

@@ -259,9 +259,3 @@ SMMUv3DeviceInterface::drain()
     }
     return DrainState::Drained;
 }
-
-SMMUv3DeviceInterface*
-SMMUv3DeviceInterfaceParams::create() const
-{
-    return new SMMUv3DeviceInterface(*this);
-}

src/dev/arm/timer_a9global.cc

@@ -308,9 +308,3 @@ A9GlobalTimer::unserialize(CheckpointIn &cp)
 {
     global_timer.unserialize(cp);
 }
-
-A9GlobalTimer *
-A9GlobalTimerParams::create() const
-{
-    return new A9GlobalTimer(*this);
-}

src/dev/arm/timer_cpulocal.cc

@@ -439,9 +439,3 @@ CpuLocalTimer::unserialize(CheckpointIn &cp)
     for (int i = 0; i < sys->threads.size(); i++)
         localTimer[i]->unserializeSection(cp, csprintf("timer%d", i));
 }
-
-CpuLocalTimer *
-CpuLocalTimerParams::create() const
-{
-    return new CpuLocalTimer(*this);
-}

src/dev/arm/timer_sp804.cc

@@ -280,9 +280,3 @@ Sp804::unserialize(CheckpointIn &cp)
     timer0.unserializeSection(cp, "timer0");
     timer1.unserializeSection(cp, "timer1");
 }
-
-Sp804 *
-Sp804Params::create() const
-{
-    return new Sp804(*this);
-}

src/dev/arm/ufs_device.cc

@@ -752,17 +752,6 @@ UFSHostDevice::UFSHostDevice(const UFSHostDeviceParams &p) :
     setValues();
 }
 
-/**
- * Create the parameters of this device
- */
-
-UFSHostDevice*
-UFSHostDeviceParams::create() const
-{
-    return new UFSHostDevice(*this);
-}
-
-
 void
 UFSHostDevice::regStats()
 {

src/dev/arm/vgic.cc

@@ -552,9 +552,3 @@ VGic::vcpuIntData::unserialize(CheckpointIn &cp)
         paramIn(cp, "lr", LR[i]);
     }
 }
-
-VGic *
-VGicParams::create() const
-{
-    return new VGic(*this);
-}

src/dev/arm/vio_mmio.cc

@@ -273,10 +273,3 @@ MmioVirtIO::setInterrupts(uint32_t value)
         interrupt->clear();
     }
 }
-
-
-MmioVirtIO *
-MmioVirtIOParams::create() const
-{
-    return new MmioVirtIO(*this);
-}

src/dev/arm/watchdog_sp805.cc

@@ -259,9 +259,3 @@ Sp805::unserialize(CheckpointIn &cp)
         reschedule(timeoutEvent, when, true);
     }
 }
-
-Sp805 *
-Sp805Params::create() const
-{
-    return new Sp805(*this);
-}