misc: Delete the now unnecessary create methods.

Most create() methods are no longer necessary. This change deletes them,
and occasionally moves some code from them into the constructors they
call.

Change-Id: Icbab29ba280144b892f9b12fac9e29a0839477e5
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/36536
Reviewed-by: Gabe Black <gabe.black@gmail.com>
Maintainer: Gabe Black <gabe.black@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>

src/cpu/simple/atomic.cc

@@ -771,13 +771,3 @@ AtomicSimpleCPU::printAddr(Addr a)
 {
     dcachePort.printAddr(a);
 }
-
-////////////////////////////////////////////////////////////////////////
-//
-//  AtomicSimpleCPU Simulation Object
-//
-AtomicSimpleCPU *
-AtomicSimpleCPUParams::create() const
-{
-    return new AtomicSimpleCPU(*this);
-}

src/cpu/simple/noncaching.cc

@@ -42,6 +42,9 @@
 NonCachingSimpleCPU::NonCachingSimpleCPU(const NonCachingSimpleCPUParams &p)
     : AtomicSimpleCPU(p)
 {
+    assert(p.numThreads == 1);
+    fatal_if(!FullSystem && p.workload.size() != 1,
+             "only one workload allowed");
 }
 
 void
@@ -63,12 +66,3 @@ NonCachingSimpleCPU::sendPacket(RequestPort &port, const PacketPtr &pkt)
         return port.sendAtomic(pkt);
     }
 }
-
-NonCachingSimpleCPU *
-NonCachingSimpleCPUParams::create() const
-{
-    assert(numThreads == 1);
-    if (!FullSystem && workload.size() != 1)
-        fatal("only one workload allowed");
-    return new NonCachingSimpleCPU(*this);
-}

src/cpu/simple/probes/simpoint.cc

@@ -138,10 +138,3 @@ SimPoint::profile(const std::pair<SimpleThread*, StaticInstPtr>& p)
         }
     }
 }
-
-/** SimPoint SimObject */
-SimPoint*
-SimPointParams::create() const
-{
-    return new SimPoint(*this);
-}

src/cpu/simple/timing.cc

@@ -1290,14 +1290,3 @@ TimingSimpleCPU::htmSendAbortSignal(HtmFailureFaultCause cause)
 
     sendData(req, data, nullptr, true);
 }
-
-
-////////////////////////////////////////////////////////////////////////
-//
-//  TimingSimpleCPU Simulation Object
-//
-TimingSimpleCPU *
-TimingSimpleCPUParams::create() const
-{
-    return new TimingSimpleCPU(*this);
-}