misc: check address range in the SystemC example

Using a wrong offset or memory size may lead to segmentation faults.
This patch adds an address range check and produces an error message.

Change-Id: I79a72c05879266daf61a83367fe4ae386d1958a4
Reviewed-on: https://gem5-review.googlesource.com/3482
Maintainer: Jason Lowe-Power <jason@lowepower.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-by: Matthias Jung <jungma@eit.uni-kl.de>
This commit is contained in:
Christian Menard
2017-05-23 18:34:12 +02:00
parent 01921763a4
commit 9c29b5a433
2 changed files with 15 additions and 0 deletions

View File

@@ -65,6 +65,14 @@ Target::Target(sc_core::sc_module_name name,
dont_initialize();
}
void
Target::check_address(unsigned long long int addr)
{
if (addr < offset || addr >= offset + size)
SC_REPORT_FATAL("Target", "Address out of range. Did you set an "
"appropriate size and offset?");
}
void
Target::b_transport(tlm::tlm_generic_payload& trans, sc_time& delay)
{
@@ -75,6 +83,8 @@ Target::b_transport(tlm::tlm_generic_payload& trans, sc_time& delay)
unsigned int
Target::transport_dbg(tlm::tlm_generic_payload& trans)
{
check_address(trans.get_address());
tlm::tlm_command cmd = trans.get_command();
sc_dt::uint64 adr = trans.get_address() - offset;
unsigned char* ptr = trans.get_data_ptr();
@@ -203,6 +213,8 @@ Target::execute_transaction_process()
void
Target::execute_transaction(tlm::tlm_generic_payload& trans)
{
check_address(trans.get_address());
tlm::tlm_command cmd = trans.get_command();
sc_dt::uint64 adr = trans.get_address() - offset;
unsigned char* ptr = trans.get_data_ptr();

View File

@@ -91,6 +91,9 @@ struct Target: sc_module
/** Method process that runs on target_done_event */
void execute_transaction_process();
/** Helping function that checks if a requested address is with range */
void check_address(unsigned long long int addr);
/** Helping Variables **/
unsigned long long int size;
unsigned offset;