derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mem: Ensure trace captures packet fields before forwarding

Browse Source 
This patch fixes a bug in the CommMonitor caused by the packet being
modified before it is captured in the trace. By recording the fields
before passing the packet on, and then putting these values in the
trace we ensure that even if the packet is modified the trace captures
what the CommMonitor saw.
This commit is contained in:
Andreas Hansson
2013-02-19 05:56:05 -05:00
parent 21aa950318
commit 9947923c60
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/mem/comm_monitor.cc
View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2012 ARM Limited
* Copyright (c) 2012-2013 ARM Limited
* All rights reserved
*
* The license below extends only to copyright in the software and shall
@@ -162,6 +162,7 @@ CommMonitor::recvTimingReq(PacketPtr pkt)
// or even deleted when sendTiming() is called.
bool isRead = pkt->isRead();
bool isWrite = pkt->isWrite();
int cmd = pkt->cmdToIndex();
unsigned size = pkt->getSize();
Addr addr = pkt->getAddr();
bool needsResponse = pkt->needsResponse();
@@ -193,9 +194,9 @@ CommMonitor::recvTimingReq(PacketPtr pkt)
// trace.
Message::Packet pkt_msg;
pkt_msg.set_tick(curTick());
pkt_msg.set_cmd(pkt->cmdToIndex());
pkt_msg.set_addr(pkt->getAddr());
pkt_msg.set_size(pkt->getSize());
pkt_msg.set_cmd(cmd);
pkt_msg.set_addr(addr);
pkt_msg.set_size(size);
traceStream->write(pkt_msg);
}