derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dev: add a falsely removed if condition check in commit 03a00e5d3

Browse Source 
Also add brackets at the if blocks near by.

This error is found by -Werror=misleading-indentation in GCC 11.1.

Change-Id: Ib9139b66411d0fd9424e027ba508cd556032389e
Signed-off-by: Iru Cai <mytbk920423@gmail.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/44925
Reviewed-by: Gabe Black <gabe.black@gmail.com>
Maintainer: Gabe Black <gabe.black@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>
This commit is contained in:
Iru Cai
2021-04-28 14:33:10 +08:00
parent 2f8a8508fb
commit 90d56af474
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/dev/net/sinic.cc
View File

@@ -206,19 +206,23 @@ Device::read(PacketPtr pkt)
Addr index = daddr >> registers::VirtualShift;
Addr raddr = daddr & registers::VirtualMask;
if (!regValid(raddr))
if (!regValid(raddr)) {
panic("invalid register: cpu=%d vnic=%d da=%#x pa=%#x size=%d",
cpu, index, daddr, pkt->getAddr(), pkt->getSize());
}
const registers::Info &info = regInfo(raddr);
if (!info.read)
if (!info.read) {
panic("read %s (write only): "
"cpu=%d vnic=%d da=%#x pa=%#x size=%d",
info.name, cpu, index, daddr, pkt->getAddr(), pkt->getSize());
}
if (info.size != pkt->getSize()) {
panic("read %s (invalid size): "
"cpu=%d vnic=%d da=%#x pa=%#x size=%d",
info.name, cpu, index, daddr, pkt->getAddr(), pkt->getSize());
}
prepareRead(cpu, index);