stdlib,tests: Fix download_check.py

This was causing the Weekly tests to fail. The removing of the download
directory should only happen at the end. Prior to this patch it was
deleted and then referenced, which caused problems.

Change-Id: I134782e89a13f5c3cd5c1912ad53a701d0413d16
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/72159
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu>
Maintainer: Bobby Bruce <bbruce@ucdavis.edu>
Tested-by: kokoro <noreply+kokoro@google.com>

tests/gem5/configs/download_check.py

@@ -94,7 +94,6 @@ for id in ids:
         continue
 
     for resource_version in ids[id]:
-
         resource_json = get_resource_json_obj(
             resource_id=id,
             resource_version=resource_version,
@@ -129,8 +128,8 @@ for id in ids:
                 + f" gem5-resources ({resource_json['md5sum']}).{os.linesep}"
             )
 
-        # Remove the downloaded resource.
-    shutil.rmtree(download_path, ignore_errors=True)
+# Remove the downloaded resource.
+shutil.rmtree(args.download_directory, ignore_errors=True)
 
 # If errors exist, raise an exception highlighting them.
 if errors: