tests: remove protocol=None, add print statement back in

This commit removes the `protocol=None` argument in various
gem5_verify_config()s because protocol is set to None by
default. Also, two print statements that were taken out in
previous commits were put back in with different function calls.
This commit is contained in:
Erin Le
2024-11-18 16:05:12 -08:00
committed by Bobby R. Bruce
parent bcfa988a67
commit 82c8642954
8 changed files with 6 additions and 20 deletions

View File

@@ -87,7 +87,6 @@ arm_boot_test"
valid_isas=(constants.all_compiled_tag,),
valid_hosts=constants.supported_hosts,
length=length,
protocol=None,
)

View File

@@ -72,6 +72,5 @@ for isa in ("arm", "riscv", "x86"):
],
valid_isas=(constants.all_compiled_tag,),
valid_hosts=constants.supported_hosts,
protocol=None,
length=constants.long_tag,
)

View File

@@ -196,7 +196,6 @@ if False: # os.access("/dev/kvm", mode=os.R_OK | os.W_OK):
),
config_args=["--benchmark", "blackscholes", "--size", "simsmall"],
valid_isas=(constants.all_compiled_tag,),
protocol=None,
valid_hosts=(constants.host_x86_64_tag,),
length=constants.long_tag,
uses_kvm=True,
@@ -223,7 +222,6 @@ if os.access("/dev/kvm", mode=os.R_OK | os.W_OK):
"5000000000",
],
valid_isas=(constants.all_compiled_tag,),
protocol=None,
valid_hosts=(constants.host_x86_64_tag,),
length=constants.long_tag,
uses_kvm=True,
@@ -245,7 +243,6 @@ if os.access("/dev/kvm", mode=os.R_OK | os.W_OK):
),
config_args=["--benchmark", "gapbs-bfs-test"],
valid_isas=(constants.all_compiled_tag,),
protocol=None,
valid_hosts=(constants.host_x86_64_tag,),
length=constants.long_tag,
uses_kvm=True,

View File

@@ -56,10 +56,6 @@ from gem5.components.processors.simple_switchable_processor import (
)
from gem5.isas import ISA
from gem5.resources.resource import obtain_resource
# This function was removed in the change to compile all Ruby protocols in one
# build
# from gem5.runtime import get_runtime_coherence_protocol
from gem5.utils.requires import requires
parser = argparse.ArgumentParser(
@@ -207,8 +203,9 @@ motherboard.set_kernel_disk_workload(
# Begin running of the simulation. This will exit once the Linux system boot
# is complete.
print("Running with ISA: " + processor.get_isa().name)
# This function was removed
# print("Running with protocol: " + get_runtime_coherence_protocol().name)
print(
"Running with protocol: " + cache_hierarchy.get_coherence_protocol().name
)
print()
# Disable the gdb ports. Required for forking.

View File

@@ -75,7 +75,6 @@ def test_kvm_fork_run(cpu: str, num_cpus: int, mem_system: str, length: str):
],
valid_isas=(constants.all_compiled_tag,),
valid_hosts=(constants.host_x86_64_tag,),
protocol=None,
length=length,
uses_kvm=True,
)

View File

@@ -46,10 +46,6 @@ from gem5.components.processors.simple_switchable_processor import (
)
from gem5.isas import ISA
from gem5.resources.resource import obtain_resource
# This function was removed in the change to compile all Ruby protocols in one
# build
# from gem5.runtime import get_runtime_coherence_protocol
from gem5.simulate.exit_event import ExitEvent
from gem5.simulate.simulator import Simulator
from gem5.utils.requires import requires
@@ -189,8 +185,9 @@ motherboard.set_kernel_disk_workload(
# Begin running of the simulation. This will exit once the Linux system boot
# is complete.
print("Running with ISA: " + processor.get_isa().name)
# This function was removed
# print("Running with protocol: " + get_runtime_coherence_protocol().name)
print(
"Running with protocol: " + cache_hierarchy.get_coherence_protocol().name
)
print()
simulator = Simulator(

View File

@@ -73,7 +73,6 @@ def test_kvm_switch(cpu: str, num_cpus: int, mem_system: str, length: str):
],
valid_isas=(constants.all_compiled_tag,),
valid_hosts=(constants.host_x86_64_tag,),
protocol=None,
length=length,
uses_kvm=True,
)

View File

@@ -88,7 +88,6 @@ def test_boot(
+ additional_config_args,
valid_isas=(constants.all_compiled_tag,),
valid_hosts=constants.supported_hosts,
protocol=None,
length=length,
)