derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

arch-vega: Fix upsize cast error in newer compilers (#774)

Browse Source 
Newer compilers error on -Warray-length in the recent MI200 patches due
to casting from a 32-bit data type to a 64-bit type. Change it to cast
the 32-bit integer first then 64-bit integer latter to remove the
warning.

Rerun of validation tests on the three instructions passed.

Change-Id: I0309e5f7b5b8cc8ce1651660ddddb120fa6e7666
This commit is contained in:
Matthew Poremba
2024-01-16 09:41:23 -08:00
committed by GitHub
parent 6a9e80c54c
commit 70376d43a3
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/arch/amdgpu/vega/insts/instructions.cc
View File

@@ -46147,10 +46147,10 @@ namespace VegaISA
*reinterpret_cast<float*>(&s1h),
*reinterpret_cast<float*>(&s2h));
uint64_t result1 = *reinterpret_cast<uint64_t*>(&dword1);
uint64_t result2 = *reinterpret_cast<uint64_t*>(&dword2);
uint32_t result1 = *reinterpret_cast<uint32_t*>(&dword1);
uint32_t result2 = *reinterpret_cast<uint32_t*>(&dword2);
vdst[lane] = (result2 << 32) | result1;
vdst[lane] = (static_cast<uint64_t>(result2) << 32) | result1;
}
}
@@ -46206,10 +46206,10 @@ namespace VegaISA
float dword2 = *reinterpret_cast<float*>(&lower_dword)
* *reinterpret_cast<float*>(&upper_dword);
uint64_t result1 = *reinterpret_cast<uint64_t*>(&dword1);
uint64_t result2 = *reinterpret_cast<uint64_t*>(&dword2);
uint32_t result1 = *reinterpret_cast<uint32_t*>(&dword1);
uint32_t result2 = *reinterpret_cast<uint32_t*>(&dword2);
vdst[lane] = (result2 << 32) | result1;
vdst[lane] = (static_cast<uint64_t>(result2) << 32) | result1;
}
}
@@ -46265,10 +46265,10 @@ namespace VegaISA
float dword2 = *reinterpret_cast<float*>(&lower_dword)
+ *reinterpret_cast<float*>(&upper_dword);
uint64_t result1 = *reinterpret_cast<uint64_t*>(&dword1);
uint64_t result2 = *reinterpret_cast<uint64_t*>(&dword2);
uint32_t result1 = *reinterpret_cast<uint32_t*>(&dword1);
uint32_t result2 = *reinterpret_cast<uint32_t*>(&dword2);
vdst[lane] = (result2 << 32) | result1;
vdst[lane] = (static_cast<uint64_t>(result2) << 32) | result1;
}
}