derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpu-compute: Simplify LGKM decrementing for Flat instructions

Browse Source 
This commit makes it so LGKM count is decremented in a single place
(after completeAcc), which fixes a couple of potential bugs

1. Data is only written by completeAcc, not after initiateAcc. LGKM
count is supposed to be decremented after data is written.
2. LGKM count is now properly decremented for atomics without return

Change-Id: Ic791af3b42e04f7baaa0ce50cb2a2c6286c54f5a
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39396
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com>
Reviewed-by: Matthew Poremba <matthew.poremba@amd.com>
Maintainer: Matt Sinclair <mattdsinclair@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>
This commit is contained in:
Kyle Roarty
2021-01-19 14:00:58 -06:00
parent 927cd10cb4
commit 68fe6fa6cb
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/gpu-compute/global_memory_pipeline.cc
View File

@@ -130,7 +130,7 @@ GlobalMemPipeline::exec()
DPRINTF(GPUMem, "CU%d: WF[%d][%d]: Completing global mem instr %s\n",
m->cu_id, m->simdId, m->wfSlotId, m->disassemble());
m->completeAcc(m);
if (m->isFlat() && (m->isLoad() || m->isAtomicRet())) {
if (m->isFlat()) {
w->decLGKMInstsIssued();
}
w->decVMemInstsIssued();
@@ -196,10 +196,6 @@ GlobalMemPipeline::exec()
mp->disassemble(), mp->seqNum());
mp->initiateAcc(mp);
if (mp->isFlat() && mp->isStore()) {
mp->wavefront()->decLGKMInstsIssued();
}
if (mp->isStore() && mp->isGlobalSeg()) {
mp->wavefront()->decExpInstsIssued();
}