mem-cache: Remove blk_addr from Queue::trySatisfyFunctional
The blk_addr is pkt->getBlockAddr(), and therefore can be acquired internally, when needed, as long as the pkt is provided. Change-Id: I2780445d2a0cb9e27257961efc4f438cc19550e5 Signed-off-by: Daniel R. Carvalho <odanrc@yahoo.com.br> Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/17537 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com> Maintainer: Nikos Nikoleris <nikos.nikoleris@arm.com>
This commit is contained in:
committed by
Daniel Carvalho
parent
2d84dc46ba
commit
639b4006ff
4
src/mem/cache/base.cc
vendored
4
src/mem/cache/base.cc
vendored
@@ -649,8 +649,8 @@ BaseCache::functionalAccess(PacketPtr pkt, bool from_cpu_side)
|
||||
|
||||
bool done = have_dirty ||
|
||||
cpuSidePort.trySatisfyFunctional(pkt) ||
|
||||
mshrQueue.trySatisfyFunctional(pkt, blk_addr) ||
|
||||
writeBuffer.trySatisfyFunctional(pkt, blk_addr) ||
|
||||
mshrQueue.trySatisfyFunctional(pkt) ||
|
||||
writeBuffer.trySatisfyFunctional(pkt) ||
|
||||
memSidePort.trySatisfyFunctional(pkt);
|
||||
|
||||
DPRINTF(CacheVerbose, "%s: %s %s%s%s\n", __func__, pkt->print(),
|
||||
|
||||
4
src/mem/cache/queue.hh
vendored
4
src/mem/cache/queue.hh
vendored
@@ -181,11 +181,11 @@ class Queue : public Drainable
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
bool trySatisfyFunctional(PacketPtr pkt, Addr blk_addr)
|
||||
bool trySatisfyFunctional(PacketPtr pkt)
|
||||
{
|
||||
pkt->pushLabel(label);
|
||||
for (const auto& entry : allocatedList) {
|
||||
if (entry->matchBlockAddr(blk_addr, pkt->isSecure()) &&
|
||||
if (entry->matchBlockAddr(pkt) &&
|
||||
entry->trySatisfyFunctional(pkt)) {
|
||||
pkt->popLabel();
|
||||
return true;
|
||||
|
||||
Reference in New Issue
Block a user