derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mem: Remove units from stats description

Browse Source 
The change https://gem5-review.googlesource.com/c/public/gem5/+/40622
allows units to be shown in stats dump, the units in stats
descriptions are nolonger necessary. This change removes units
from stats descriptions. However, for units that are multiples
of a supported unit (e.g. MegaBytes), the units in the descriptions
are kept until unit prefixes are supported.

Change-Id: I4d87139290a8458e87da776e4328edbd6c224546
Signed-off-by: Hoa Nguyen <hoanguyen@ucdavis.edu>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40655
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br>
Maintainer: Jason Lowe-Power <power.jg@gmail.com>
This commit is contained in:
Hoa Nguyen
2021-02-04 15:24:43 -08:00
parent 67f5f1c3e3
commit 5aaa392f2e
6 changed files with 15 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/mem/abstract_mem.cc
View File

@@ -123,13 +123,13 @@ AbstractMemory::MemStats::MemStats(AbstractMemory &_mem)
ADD_STAT(numOther, UNIT_COUNT,
"Number of other requests responded to by this memory"),
ADD_STAT(bwRead, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Total read bandwidth from this memory (bytes/s)"),
"Total read bandwidth from this memory"),
ADD_STAT(bwInstRead, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Instruction read bandwidth from this memory (bytes/s)"),
"Instruction read bandwidth from this memory"),
ADD_STAT(bwWrite, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Write bandwidth from this memory (bytes/s)"),
"Write bandwidth from this memory"),
ADD_STAT(bwTotal, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Total bandwidth to/from this memory (bytes/s)")
"Total bandwidth to/from this memory")
{
}

5
src/mem/cache/compressors/base.cc vendored
View File

@@ -233,11 +233,10 @@ Base::BaseStats::BaseStats(Base& _compressor)
ADD_STAT(compressionSize, UNIT_COUNT,
"Number of blocks that were compressed to this power of two "
"size"),
ADD_STAT(compressionSizeBits, UNIT_BIT,
"Total compressed data size, in bits"),
ADD_STAT(compressionSizeBits, UNIT_BIT, "Total compressed data size"),
ADD_STAT(avgCompressionSizeBits,
UNIT_RATE(Stats::Units::Bit, Stats::Units::Count),
"Average compression size, in bits"),
"Average compression size"),
ADD_STAT(decompressions, UNIT_COUNT, "Total number of decompressions")
{
}

8
src/mem/comm_monitor.cc
View File

@@ -110,23 +110,23 @@ CommMonitor::MonitorStats::MonitorStats(Stats::Group *parent,
readBytes(0),
ADD_STAT(readBandwidthHist,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Histogram of read bandwidth per sample period (bytes/s)"),
"Histogram of read bandwidth per sample period"),
ADD_STAT(totalReadBytes, UNIT_BYTE, "Number of bytes read"),
ADD_STAT(averageReadBandwidth,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Average read bandwidth (bytes/s)",
"Average read bandwidth",
totalReadBytes / simSeconds),
writtenBytes(0),
ADD_STAT(writeBandwidthHist,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Histogram of write bandwidth (bytes/s)"),
"Histogram of write bandwidth"),
ADD_STAT(totalWrittenBytes,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Number of bytes written"),
ADD_STAT(averageWriteBandwidth,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Average write bandwidth (bytes/s)",
"Average write bandwidth",
totalWrittenBytes / simSeconds),
disableLatencyHists(params.disable_latency_hists),

4
src/mem/mem_ctrl.cc
View File

@@ -1249,10 +1249,10 @@ MemCtrl::CtrlStats::CtrlStats(MemCtrl &_ctrl)
"Per-requestor bytes write to memory"),
ADD_STAT(requestorReadRate,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Per-requestor bytes read from memory rate (Bytes/sec)"),
"Per-requestor bytes read from memory rate"),
ADD_STAT(requestorWriteRate,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Per-requestor bytes write to memory rate (Bytes/sec)"),
"Per-requestor bytes write to memory rate"),
ADD_STAT(requestorReadAccesses, UNIT_COUNT,
"Per-requestor read serviced memory accesses"),
ADD_STAT(requestorWriteAccesses, UNIT_COUNT,

4
src/mem/qos/mem_ctrl.cc
View File

@@ -285,9 +285,9 @@ MemCtrl::MemCtrlStats::MemCtrlStats(MemCtrl &mc)
"values"),
ADD_STAT(priorityMinLatency, UNIT_SECOND,
"per QoS priority minimum request to response latency (s)"),
"per QoS priority minimum request to response latency"),
ADD_STAT(priorityMaxLatency, UNIT_SECOND,
"per QoS priority maximum request to response latency (s)"),
"per QoS priority maximum request to response latency"),
ADD_STAT(numReadWriteTurnArounds, UNIT_COUNT,
"Number of turnarounds from READ to WRITE"),
ADD_STAT(numWriteReadTurnArounds, UNIT_COUNT,

3
src/mem/xbar.cc
View File

@@ -67,8 +67,7 @@ BaseXBar::BaseXBar(const BaseXBarParams &p)
ADD_STAT(pktCount, UNIT_COUNT,
"Packet count per connected requestor and responder"),
ADD_STAT(pktSize, UNIT_BYTE,
"Cumulative packet size per connected requestor and responder "
"(bytes)")
"Cumulative packet size per connected requestor and responder")
{
}