derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

arch-gcn3: Replace some instances of std::isnormal with std::fpclassify

Browse Source 
Affected instructions: V_DIV_SCALE_F64, V_CMP_CLASS_F64,
V_CMPX_CLASS_F64 and their VOPC, VOP3, F32 variants.

These instances of std::isnormal were being used to check for
subnormal (denorms) values. std::isnormal is not specific enough.
It returns true for normal values but false for NaN, Inf, 0.0, and
subnormals. std::fpclassify returns macros for each category of
floating point numbers. Now we only catch subnormals.

Change-Id: I8d8f4452ff58de71e7c8e0b2b5e73467b532e196
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/29967
Maintainer: Anthony Gutierrez <anthony.gutierrez@amd.com>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com>
This commit is contained in:
Travis Boraten
2019-05-01 01:11:08 -04:00
committed by Anthony Gutierrez
parent e1d10c3894
commit 4c1dc827bc
1 changed files with 23 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/arch/gcn3/insts/instructions.cc
View File

@@ -9439,7 +9439,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 4)) {
// is -denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& std::signbit(src0[lane])) {
vcc.setBit(lane, 1);
continue;
@@ -9463,7 +9463,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 7)) {
// is +denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& !std::signbit(src0[lane])) {
vcc.setBit(lane, 1);
continue;
@@ -9551,7 +9551,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 4)) {
// is -denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& std::signbit(src0[lane])) {
vcc.setBit(lane, 1);
continue;
@@ -9575,7 +9575,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 7)) {
// is +denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& !std::signbit(src0[lane])) {
vcc.setBit(lane, 1);
continue;
@@ -9664,7 +9664,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 4)) {
// is -denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& std::signbit(src0[lane])) {
vcc.setBit(lane, 1);
continue;
@@ -9688,7 +9688,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 7)) {
// is +denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& !std::signbit(src0[lane])) {
vcc.setBit(lane, 1);
continue;
@@ -9777,7 +9777,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 4)) {
// is -denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& std::signbit(src0[lane])) {
vcc.setBit(lane, 1);
continue;
@@ -9801,7 +9801,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 7)) {
// is +denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& !std::signbit(src0[lane])) {
vcc.setBit(lane, 1);
continue;
@@ -15550,7 +15550,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 4)) {
// is -denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& std::signbit(src0[lane])) {
sdst.setBit(lane, 1);
continue;
@@ -15574,7 +15574,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 7)) {
// is +denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& !std::signbit(src0[lane])) {
sdst.setBit(lane, 1);
continue;
@@ -15665,7 +15665,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 4)) {
// is -denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& std::signbit(src0[lane])) {
sdst.setBit(lane, 1);
continue;
@@ -15689,7 +15689,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 7)) {
// is +denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& !std::signbit(src0[lane])) {
sdst.setBit(lane, 1);
continue;
@@ -15780,7 +15780,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 4)) {
// is -denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& std::signbit(src0[lane])) {
sdst.setBit(lane, 1);
continue;
@@ -15804,7 +15804,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 7)) {
// is +denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& !std::signbit(src0[lane])) {
sdst.setBit(lane, 1);
continue;
@@ -15895,7 +15895,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 4)) {
// is -denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& std::signbit(src0[lane])) {
sdst.setBit(lane, 1);
continue;
@@ -15919,7 +15919,7 @@ namespace Gcn3ISA
}
if (bits(src1[lane], 7)) {
// is +denormal
if (!std::isnormal(src0[lane])
if (std::fpclassify(src0[lane]) == FP_SUBNORMAL
&& !std::signbit(src0[lane])) {
sdst.setBit(lane, 1);
continue;
@@ -29249,17 +29249,19 @@ namespace Gcn3ISA
if (src0[lane] == src1[lane]) {
vdst[lane] = std::ldexp(src0[lane], 128);
}
} else if (!std::isnormal(src1[lane])) {
} else if (std::fpclassify(src1[lane]) == FP_SUBNORMAL) {
vdst[lane] = std::ldexp(src0[lane], 128);
} else if (!std::isnormal(1.0 / src1[lane])
&& !std::isnormal(src2[lane] / src1[lane])) {
} else if (std::fpclassify(1.0 / src1[lane]) == FP_SUBNORMAL
&& std::fpclassify(src2[lane] / src1[lane])
== FP_SUBNORMAL) {
vcc.setBit(lane, 1);
if (src0[lane] == src1[lane]) {
vdst[lane] = std::ldexp(src0[lane], 128);
}
} else if (!std::isnormal(1.0 / src1[lane])) {
} else if (std::fpclassify(1.0 / src1[lane]) == FP_SUBNORMAL) {
vdst[lane] = std::ldexp(src0[lane], -128);
} else if (!std::isnormal(src2[lane] / src1[lane])) {
} else if (std::fpclassify(src2[lane] / src1[lane])
== FP_SUBNORMAL) {
vcc.setBit(lane, 1);
if (src0[lane] == src2[lane]) {
vdst[lane] = std::ldexp(src0[lane], 128);