derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

configs: Add mem_banks to Carrizo topology

Browse Source 
ROCm 4 iterates through the mem_banks to find an appropriate place to
allocate memory. Previously, Carrizo didn't have any mem_banks, which
resulted in the ROCm 4 runtime erroring out, as it didn't know where to
allocate memory.

The implementation is fairly similar to the implementation used for the
Fiji or Vega configs

Change-Id: I5bb4e89657d44c6cb690fd224ee1bf1d4d6cf2a5
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/46240
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Matthew Poremba <matthew.poremba@amd.com>
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com>
Reviewed-by: Bobby R. Bruce <bbruce@ucdavis.edu>
Maintainer: Matt Sinclair <mattdsinclair@gmail.com>
This commit is contained in:
Kyle Roarty
2021-05-11 16:34:12 -05:00
parent bc52e3d6c9
commit 466e2018a2
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
configs/example/hsaTopology.py
View File

@@ -36,7 +36,7 @@ from os import mkdir, makedirs, getpid, listdir, fsync
from os.path import join as joinpath
from os.path import isdir
from shutil import rmtree, copyfile
from m5.util.convert import toFrequency
from m5.util.convert import toFrequency, toMemorySize
def file_append(path, contents):
with open(joinpath(*path), 'a') as f:
@@ -422,12 +422,14 @@ def createCarrizoTopology(options):
# must have marketing name
file_append((node_dir, 'name'), 'Carrizo\n')
mem_banks_cnt = 1
# populate global node properties
# NOTE: SIMD count triggers a valid GPU agent creation
node_prop = 'cpu_cores_count %s\n' % options.num_cpus + \
'simd_count %s\n' \
% (options.num_compute_units * options.simds_per_cu) + \
'mem_banks_count 0\n' + \
'mem_banks_count %s\n' % mem_banks_cnt + \
'caches_count 0\n' + \
'io_links_count 0\n' + \
'cpu_core_id_base 16\n' + \
@@ -453,3 +455,14 @@ def createCarrizoTopology(options):
% int(toFrequency(options.CPUClock) / 1e6)
file_append((node_dir, 'properties'), node_prop)
for i in range(mem_banks_cnt):
mem_dir = joinpath(node_dir, f'mem_banks/{i}')
remake_dir(mem_dir)
mem_prop = f'heap_type 0\n' + \
f'size_in_bytes {toMemorySize(options.mem_size)}' + \
f'flags 0\n' + \
f'width 64\n' + \
f'mem_clk_max 1600\n'
file_append((mem_dir, 'properties'), mem_prop)