derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

arch-x86,cpu-kvm: Fix gem5.fast due to unused variable (#189)

Browse Source 
Detected via this failing workload:
https://github.com/gem5/gem5/actions/runs/5861958237

Ir caused the following compilation error to be thrown:

```
src/arch/x86/kvm/x86_cpu.cc:1462:22: error: unused variable ‘rv’ [-Werror=unused-variable]
 1462 |                 bool rv = isa->cpuid->doCpuid(tc, function, idx, cpuid);
      |                      ^~
```

`rv` is unused in the .fast compilation as it's only used in the
`assert` statement immediately after.

To fix this, the `[[maybe_unused]]` annotation is used.
This commit is contained in:
Bobby R. Bruce
2023-08-16 12:52:44 -07:00
committed by GitHub
parent f6b116d8a0 c835c9faa3
commit 3ff6fe0e90
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/arch/x86/kvm/x86_cpu.cc
View File

@@ -1459,7 +1459,8 @@ X86KvmCPU::updateCPUID()
m5_supported.push_back(makeKvmCpuid(function, idx, cpuid));
} else {
while (true) {
bool rv = isa->cpuid->doCpuid(tc, function, idx, cpuid);
[[maybe_unused]] bool rv = isa->cpuid->doCpuid(
tc, function, idx, cpuid);
assert(rv);
if (idx &&
@@ -1493,7 +1494,8 @@ X86KvmCPU::updateCPUID()
m5_supported.push_back(makeKvmCpuid(function, idx, cpuid));
} else {
while (true) {
bool rv = isa->cpuid->doCpuid(tc, function, idx, cpuid);
[[maybe_unused]] bool rv = isa->cpuid->doCpuid(
tc, function, idx, cpuid);
assert(rv);
if (idx &&