derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

arch: Fix a fatal_if in most of the arch's process classes.

Browse Source 
When switching an assert to a fatal while addressing recent review
feedback, I forgot to reverse the polarity of the condition, making
the fatal fire in exactly the opposite of the conditions it was meant
to.

Change-Id: Icf49864ef449052bbb0d427dca786006166575c4
Reviewed-on: https://gem5-review.googlesource.com/7381
Reviewed-by: Matthias Jung <jungma@eit.uni-kl.de>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>
This commit is contained in:
Gabe Black
2018-01-14 11:44:04 -08:00
parent 5320a97ced
commit 3e8d76e2e2
6 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/arch/alpha/process.cc
View File

@@ -52,7 +52,7 @@ AlphaProcess::AlphaProcess(ProcessParams *params, ObjectFile *objFile)
: Process(params, new FuncPageTable(params->name, params->pid, PageBytes),
objFile)
{
fatal_if(!params->useArchPT, "Arch page tables not implemented.");
fatal_if(params->useArchPT, "Arch page tables not implemented.");
Addr brk_point = objFile->dataBase() + objFile->dataSize() +
objFile->bssSize();
brk_point = roundUp(brk_point, PageBytes);

2
src/arch/arm/process.cc
View File

@@ -67,7 +67,7 @@ ArmProcess::ArmProcess(ProcessParams *params, ObjectFile *objFile,
objFile),
arch(_arch)
{
fatal_if(!params->useArchPT, "Arch page tables not implemented.");
fatal_if(params->useArchPT, "Arch page tables not implemented.");
}
ArmProcess32::ArmProcess32(ProcessParams *params, ObjectFile *objFile,

2
src/arch/mips/process.cc
View File

@@ -53,7 +53,7 @@ MipsProcess::MipsProcess(ProcessParams *params, ObjectFile *objFile)
: Process(params, new FuncPageTable(params->name, params->pid, PageBytes),
objFile)
{
fatal_if(!params->useArchPT, "Arch page tables not implemented.");
fatal_if(params->useArchPT, "Arch page tables not implemented.");
// Set up stack. On MIPS, stack starts at the top of kuseg
// user address space. MIPS stack grows down from here
Addr stack_base = 0x7FFFFFFF;

2
src/arch/power/process.cc
View File

@@ -53,7 +53,7 @@ PowerProcess::PowerProcess(ProcessParams *params, ObjectFile *objFile)
: Process(params, new FuncPageTable(params->name, params->pid, PageBytes),
objFile)
{
fatal_if(!params->useArchPT, "Arch page tables not implemented.");
fatal_if(params->useArchPT, "Arch page tables not implemented.");
// Set up break point (Top of Heap)
Addr brk_point = objFile->dataBase() + objFile->dataSize() +
objFile->bssSize();

2
src/arch/riscv/process.cc
View File

@@ -64,7 +64,7 @@ RiscvProcess::RiscvProcess(ProcessParams *params, ObjectFile *objFile) :
PageBytes),
objFile)
{
fatal_if(!params->useArchPT, "Arch page tables not implemented.");
fatal_if(params->useArchPT, "Arch page tables not implemented.");
const Addr stack_base = 0x7FFFFFFFFFFFFFFFL;
const Addr max_stack_size = 8 * 1024 * 1024;
const Addr next_thread_stack_base = stack_base - max_stack_size;

2
src/arch/sparc/process.cc
View File

@@ -60,7 +60,7 @@ SparcProcess::SparcProcess(ProcessParams *params, ObjectFile *objFile,
objFile),
StackBias(_StackBias)
{
fatal_if(!params->useArchPT, "Arch page tables not implemented.");
fatal_if(params->useArchPT, "Arch page tables not implemented.");
// Initialize these to 0s
fillStart = 0;
spillStart = 0;