derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

config: Default the indirect branch predictor to "None".

Browse Source 
Other scripts (like se.py) blindly try to apply the indirect predictor
if one is set. Because this option defaults to something, there's no
way (as far as I know) to purposefully select nothing, and so the
simulator crashes. Users shouldn't have to proactively prevent gem5
from killing itself regardless, so the default was changed to "None".

Change-Id: Ic3382b8065442d6705b1c6a656646598d9d5c322
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/23360
Reviewed-by: Ciro Santilli <ciro.santilli@arm.com>
Reviewed-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>
Tested-by: kokoro <noreply+kokoro@google.com>
This commit is contained in:
Gabe Black
2019-12-03 20:33:28 -08:00
parent 0e8ce8b12e
commit 2b103231ea
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
configs/common/Options.py
View File

@@ -183,8 +183,7 @@ def addCommonOptions(parser):
type of branch predictor to run with
(if not set, use the default branch predictor of
the selected CPU)""")
parser.add_option("--indirect-bp-type", type="choice",
default="SimpleIndirectPredictor",
parser.add_option("--indirect-bp-type", type="choice", default=None,
choices=ObjectList.indirect_bp_list.get_names(),
help = "type of indirect branch predictor to run with")
parser.add_option("--list-hwp-types",