mem: Use a const T & in write<> to avoid an unnecessary copy.

If the type T is complex/large, the it makes sense to access it in place
and not copy it and then not modify it.

Change-Id: Idd24be4fbba636375637ff72b1ba5ee32eb76215
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18573
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Maintainer: Andreas Sandberg <andreas.sandberg@arm.com>
This commit is contained in:
Gabe Black
2019-05-01 20:16:56 -07:00
parent 8666440499
commit 1a631bd79b

View File

@@ -195,7 +195,7 @@ class PortProxy
* Write object T to address. Writes sizeof(T) bytes.
*/
template <typename T>
void write(Addr address, T data) const;
void write(Addr address, const T &data) const;
/**
* Read sizeof(T) bytes from address and return as object T.
@@ -256,7 +256,7 @@ PortProxy::read(Addr address) const
template <typename T>
void
PortProxy::write(Addr address, T data) const
PortProxy::write(Addr address, const T &data) const
{
writeBlob(address, &data, sizeof(T));
}