derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MIPS: Get rid of cruft in the fault classes.

Browse Source 
Get rid of Fault classes left over from when this file was copied from Alpha,
and rename ArithmeticOverflowFault to be IntegerOverflowFault and get rid of
the old IntegerOverflowFault stub. The Integer version is what's actually in
the manual, but the Arithmetic version had the implementation.
This commit is contained in:
Gabe Black
2011-09-19 06:17:19 -07:00
parent 7e704c9f51
commit 110c59b414
5 changed files with 15 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/arch/mips/faults.cc
View File

@@ -51,9 +51,6 @@ typedef MipsFaultBase::FaultVals FaultVals;
template <> FaultVals MipsFault<MachineCheckFault>::vals =
{ "Machine Check", 0x0401 };
template <> FaultVals MipsFault<AlignmentFault>::vals =
{ "Alignment", 0x0301 };
template <> FaultVals MipsFault<ResetFault>::vals =
#if FULL_SYSTEM
{ "Reset Fault", 0xBFC00000};
@@ -79,11 +76,8 @@ template <> FaultVals MipsFault<ReservedInstructionFault>::vals =
template <> FaultVals MipsFault<ThreadFault>::vals =
{ "Thread Fault", 0x00F1 };
template <> FaultVals MipsFault<ArithmeticFault>::vals =
{ "Arithmetic Overflow Exception", 0x180 };
template <> FaultVals MipsFault<UnimplementedOpcodeFault>::vals =
{ "opdec", 0x0481 };
template <> FaultVals MipsFault<IntegerOverflowFault>::vals =
{ "Integer Overflow Exception", 0x180 };
template <> FaultVals MipsFault<InterruptFault>::vals =
{ "interrupt", 0x0180 };
@@ -97,30 +91,9 @@ template <> FaultVals MipsFault<BreakpointFault>::vals =
template <> FaultVals MipsFault<ItbInvalidFault>::vals =
{ "Invalid TLB Entry Exception (I-Fetch/LW)", 0x0180 };
template <> FaultVals MipsFault<ItbPageFault>::vals =
{ "itbmiss", 0x0181 };
template <> FaultVals MipsFault<ItbMissFault>::vals =
{ "itbmiss", 0x0181 };
template <> FaultVals MipsFault<ItbAcvFault>::vals =
{ "iaccvio", 0x0081 };
template <> FaultVals MipsFault<ItbRefillFault>::vals =
{ "TLB Refill Exception (I-Fetch/LW)", 0x0180 };
template <> FaultVals MipsFault<NDtbMissFault>::vals =
{ "dtb_miss_single", 0x0201 };
template <> FaultVals MipsFault<PDtbMissFault>::vals =
{ "dtb_miss_double", 0x0281 };
template <> FaultVals MipsFault<DtbPageFault>::vals =
{ "dfault", 0x0381 };
template <> FaultVals MipsFault<DtbAcvFault>::vals =
{ "dfault", 0x0381 };
template <> FaultVals MipsFault<DtbInvalidFault>::vals =
{ "Invalid TLB Entry Exception (Store)", 0x0180 };
@@ -130,12 +103,6 @@ template <> FaultVals MipsFault<DtbRefillFault>::vals =
template <> FaultVals MipsFault<TLBModifiedFault>::vals =
{ "TLB Modified Exception", 0x0180 };
template <> FaultVals MipsFault<FloatEnableFault>::vals =
{ "float_enable_fault", 0x0581 };
template <> FaultVals MipsFault<IntegerOverflowFault>::vals =
{ "Integer Overflow Fault", 0x0501 };
template <> FaultVals MipsFault<DspStateDisabledFault>::vals =
{ "DSP Disabled Fault", 0x001a };
@@ -190,7 +157,7 @@ MipsFaultBase::setExceptionState(ThreadContext *tc, uint8_t excCode)
}
void
ArithmeticFault::invoke(ThreadContext *tc, StaticInstPtr inst)
IntegerOverflowFault::invoke(ThreadContext *tc, StaticInstPtr inst)
{
DPRINTF(MipsPRA, "%s encountered.\n", name());
setExceptionState(tc, 0xC);

62
src/arch/mips/faults.hh
View File

@@ -91,12 +91,6 @@ class NonMaskableInterrupt : public MipsFault<NonMaskableInterrupt>
bool isNonMaskableInterrupt() {return true;}
};
class AlignmentFault : public MipsFault<AlignmentFault>
{
public:
bool isAlignmentFault() {return true;}
};
class AddressErrorFault : public MipsFault<AddressErrorFault>
{
public:
@@ -118,37 +112,11 @@ class StoreAddressErrorFault : public MipsFault<StoreAddressErrorFault>
#endif
};
class UnimplementedOpcodeFault : public MipsFault<UnimplementedOpcodeFault> {};
class TLBRefillIFetchFault : public MipsFault<TLBRefillIFetchFault>
{
public:
void invoke(ThreadContext * tc,
StaticInstPtr inst = StaticInst::nullStaticInstPtr);
};
class TLBInvalidIFetchFault : public MipsFault<TLBInvalidIFetchFault>
{
public:
void invoke(ThreadContext * tc,
StaticInstPtr inst = StaticInst::nullStaticInstPtr);
};
class NDtbMissFault : public MipsFault<NDtbMissFault> {};
class PDtbMissFault : public MipsFault<PDtbMissFault> {};
class DtbPageFault : public MipsFault<DtbPageFault> {};
class DtbAcvFault : public MipsFault<DtbAcvFault> {};
static inline Fault genMachineCheckFault()
{
return new MachineCheckFault;
}
static inline Fault genAlignmentFault()
{
return new AlignmentFault;
}
class ResetFault : public MipsFault<ResetFault>
{
public:
@@ -173,20 +141,6 @@ class SoftResetFault : public MipsFault<SoftResetFault>
StaticInstPtr inst = StaticInst::nullStaticInstPtr);
};
class DebugSingleStep : public MipsFault<DebugSingleStep>
{
public:
void invoke(ThreadContext * tc,
StaticInstPtr inst = StaticInst::nullStaticInstPtr);
};
class DebugInterrupt : public MipsFault<DebugInterrupt>
{
public:
void invoke(ThreadContext * tc,
StaticInstPtr inst = StaticInst::nullStaticInstPtr);
};
class CoprocessorUnusableFault : public MipsFault<CoprocessorUnusableFault>
{
protected:
@@ -213,7 +167,7 @@ class ThreadFault : public MipsFault<ThreadFault>
StaticInstPtr inst = StaticInst::nullStaticInstPtr);
};
class ArithmeticFault : public MipsFault<ArithmeticFault>
class IntegerOverflowFault : public MipsFault<IntegerOverflowFault>
{
protected:
bool skipFaultingInstruction() {return true;}
@@ -287,15 +241,6 @@ class DtbRefillFault : public MipsFault<DtbRefillFault>
#endif
};
class ItbPageFault : public MipsFault<ItbPageFault>
{
public:
#if FULL_SYSTEM
void invoke(ThreadContext * tc,
StaticInstPtr inst = StaticInst::nullStaticInstPtr);
#endif
};
class ItbInvalidFault : public MipsFault<ItbInvalidFault>
{
public:
@@ -347,11 +292,6 @@ class DtbInvalidFault : public MipsFault<DtbInvalidFault>
#endif
};
class FloatEnableFault : public MipsFault<FloatEnableFault> {};
class ItbMissFault : public MipsFault<ItbMissFault> {};
class ItbAcvFault : public MipsFault<ItbAcvFault> {};
class IntegerOverflowFault : public MipsFault<IntegerOverflowFault> {};
class DspStateDisabledFault : public MipsFault<DspStateDisabledFault>
{
public:

6
src/arch/mips/isa/decoder.isa
View File

@@ -214,7 +214,7 @@ decode OPCODE_HI default Unknown::unknown() {
Rd = result = Rs + Rt;
if (FULL_SYSTEM &&
findOverflow(32, result, Rs, Rt)) {
fault = new ArithmeticFault();
fault = new IntegerOverflowFault();
}
}});
0x1: addu({{ Rd.sw = Rs.sw + Rt.sw;}});
@@ -223,7 +223,7 @@ decode OPCODE_HI default Unknown::unknown() {
Rd = result = Rs - Rt;
if (FULL_SYSTEM &&
findOverflow(32, result, Rs, ~Rt)) {
fault = new ArithmeticFault();
fault = new IntegerOverflowFault();
}
}});
0x3: subu({{ Rd.sw = Rs.sw - Rt.sw; }});
@@ -327,7 +327,7 @@ decode OPCODE_HI default Unknown::unknown() {
Rt = result = Rs + imm;
if (FULL_SYSTEM &&
findOverflow(32, result, Rs, imm)) {
fault = new ArithmeticFault();
fault = new IntegerOverflowFault();
}
}});
0x1: addiu({{ Rt.sw = Rs.sw + imm; }});

8
src/arch/mips/isa/formats/unimp.isa
View File

@@ -186,7 +186,7 @@ output exec {{
panic("attempt to execute unimplemented instruction '%s' "
"(inst 0x%08x, opcode 0x%x, binary:%s)", mnemonic, machInst, OPCODE,
inst2string(machInst));
return new UnimplementedOpcodeFault;
return NoFault;
}
Fault
@@ -202,7 +202,7 @@ output exec {{
panic("attempt to execute unimplemented instruction '%s' "
"(inst %#08x, opcode %#x, binary:%s)",
mnemonic, machInst, OPCODE, inst2string(machInst));
return new UnimplementedOpcodeFault;
return NoFault;
}
}
@@ -219,7 +219,7 @@ output exec {{
panic("attempt to execute unimplemented instruction '%s' "
"(inst %#08x, opcode %#x, binary:%s)",
mnemonic, machInst, OPCODE, inst2string(machInst));
return new UnimplementedOpcodeFault;
return NoFault;
}
}
@@ -236,7 +236,7 @@ output exec {{
panic("attempt to execute unimplemented instruction '%s' "
"(inst %#08x, opcode %#x, binary:%s)",
mnemonic, machInst, OPCODE, inst2string(machInst));
return new UnimplementedOpcodeFault;
return NoFault;
}
}

5
src/arch/mips/tlb.cc
View File

@@ -387,7 +387,10 @@ TLB::translateData(RequestPtr req, ThreadContext *tc, bool write)
if (req->getVaddr() & (req->getSize() - 1)) {
DPRINTF(TLB, "Alignment Fault on %#x, size = %d", req->getVaddr(),
req->getSize());
return new AlignmentFault();
if (write)
return new StoreAddressErrorFault(req->getVaddr());
else
return new AddressErrorFault(req->getVaddr());
}