Clean up private/public linking

2024-11-21 12:42:12 +01:00
parent ffc94a73cb
commit 6d6c8c595f
4 changed files with 8 additions and 7 deletions
--- a/extensions/standards/LPDDR5/DRAMSys/configuration/memspec/MemSpecLPDDR5.h
+++ b/extensions/standards/LPDDR5/DRAMSys/configuration/memspec/MemSpecLPDDR5.h
@@ -39,8 +39,6 @@
 #include <DRAMSys/configuration/memspec/MemSpec.h>
 #include <systemc>

-#include <nlohmann/json.hpp>
-
 namespace DRAMSys
 {

--- a/src/configuration/DRAMSys/config/McConfig.h
+++ b/src/configuration/DRAMSys/config/McConfig.h
@@ -39,8 +39,6 @@
 #include "DRAMSys/util/json.h"

 #include <optional>
-#include <string>
-#include <utility>

 namespace DRAMSys::Config
 {
--- a/src/libdramsys/CMakeLists.txt
+++ b/src/libdramsys/CMakeLists.txt
@@ -107,8 +107,9 @@ target_link_libraries(libdramsys
    PUBLIC
        SystemC::systemc
        DRAMSys::config
-        SQLite::SQLite3
        $<$<TARGET_EXISTS:DRAMPower>:DRAMPower>
+    PRIVATE
+        SQLite::SQLite3

 )

--- a/src/simulator/CMakeLists.txt
+++ b/src/simulator/CMakeLists.txt
@@ -54,12 +54,16 @@ add_library(simulator
    simulator/util.cpp
 )

-target_include_directories(simulator PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
+target_include_directories(simulator
+    PUBLIC
+        ${CMAKE_CURRENT_SOURCE_DIR}
+)

 target_link_libraries(simulator
    PUBLIC
-        Threads::Threads
        libdramsys
+    PRIVATE
+        Threads::Threads
 )

 add_library(DRAMSys::simulator ALIAS simulator)