Some warnings eliminated.

9 warnings to go, all from external code (e.g., systemc lib).

DRAMSys/library/src/controller/scheduler/Fr_Fcfs_read_priority.cpp

@@ -108,6 +108,7 @@ std::pair<Command, gp *> FR_FCFS_RP::getNextRequest(Bank bank)
     }
 
     reportFatal("FR_FCFS_RP", "Never should go here ...");
+    return pair<Command, tlm::tlm_generic_payload *>(Command::NOP, NULL);
 }
 
 // There is a hazard if a read is found which will be scheduled before a write

DRAMSys/library/src/simulation/TracePlayer.cpp

@@ -40,9 +40,9 @@
 
 TracePlayer::TracePlayer(TracePlayerListener *listener) :
     payloadEventQueue(this, &TracePlayer::peqCallback),
+    numberOfTransactions(0),
     transactionsSent(0),
     transactionsReceived(0),
-    numberOfTransactions(0),
     listener(listener),
     finished(false)
 {

DRAMSys/traceAnalyzer/businessObjects/transaction.cpp

@@ -39,8 +39,9 @@
 
 using namespace std;
 Transaction::Transaction(ID id, unsigned int address, unsigned int burstlength,
-                         int thread, unsigned int channel, unsigned int bank, unsigned int bankgroup,
-                         unsigned int row, unsigned int column, Timespan span, Timespan spanOnDataStrobe)
+                         unsigned int thread, unsigned int channel, unsigned int bank,
+                         unsigned int bankgroup, unsigned int row, unsigned int column, Timespan span,
+                         Timespan spanOnDataStrobe)
     : address(address), burstlength(burstlength), thread(thread), channel(channel),
       bank(bank), bankgroup(bankgroup), row(row), column(column), span(span),
       spanOnDataStrobe(spanOnDataStrobe), id(id) {}

DRAMSys/traceAnalyzer/businessObjects/transaction.h

@@ -56,9 +56,9 @@ private:
     std::vector<std::shared_ptr<Phase>> phases;
 
 public:
-    Transaction(ID id, unsigned int address, unsigned int burstlength, int thread,
-                unsigned int channel, unsigned int bank, unsigned int bankgroup,
-                unsigned int row, unsigned int column, Timespan span,
+    Transaction(ID id, unsigned int address, unsigned int burstlength,
+                unsigned int thread, unsigned int channel, unsigned int bank,
+                unsigned int bankgroup, unsigned int row, unsigned int column, Timespan span,
                 Timespan spanOnDataStrobe);
 
     void draw(QPainter *painter, const QwtScaleMap &xMap, const QwtScaleMap &yMap,
@@ -77,7 +77,7 @@ public:
     {
         return burstlength;
     }
-    int Thread()
+    unsigned int Thread()
     {
         return thread;
     }