Before this commit: * SEV events were not waking neither WFE (wrong) nor futex WAIT (correct) * locked memory events (LLSC) due to LDXR and STXR were waking up both WFE (correct) and futex WAIT (wrong) This commit fixes all wrong behaviours mentioned above. The fact that LLSC events were waking up futexes leads to deadlocks, as shown in the test case described at: https://gem5.atlassian.net/browse/GEM5-537 because threads woken up by SVE are not removed from the waiter list for the futex address they are sleeping on. A previous fix atttempt was done at: 1531b56d605d47252dc0620bb3e755b7cf84df97 in which only sleeping threads are woken up. But that is not sufficient, because the futex sleeping thread that was being wrongly woken up on SEV can start to sleep on a second futex. As an example, consider the case where 4 threads are fighting over two critical sections protected by futex1 and futex2 addresses. In this case, one thread wakes up the other thread after it is done with the section. Suppose the following sequence of events: * thread1 is awake and all others are suspended on futex1 * thread1 SEV wakes thread2 from the futex1 while in the critical region 1. This is the wrong behaviour that this patch prevents, because now thread2 is still in the sleeper list for futex1 * thread1 then futex wakes tread3, then proceeds to critical region 2. * thread3 wakes up, but because thread2 has critical region, it sleeps again. * thread2 finishes its work, futex wakes thread3, and then proceeds to futex2 When it reaches futex2, thread1 is still working there, so it sleeps on futex2. * thread3 futex wakes thread2, because it is still wrongly on the sleeper list of futex1. But thread2 is in futex2 now. If it weren't for this mistake, it should have awaken the final thread4 instead. Outcome: thread4 sleeps forever, no other thread ever wakes it, because all other threads have woken from futex1 and awoken another thread. The problem is fixed by adding the waitingTcs unordered_set FutexMap, which is basically an inverse map to FutexMap, which tracks (addr, tgid) -> ThreadContext. This allows us allow to quickly check if a given ThreadContext is waiting on a futex in any address. Then the SEV wakeup code path now checks if the thread is k Change-Id: Icec5e30b041f53e5aa3b6e0d291e77bc0e865984 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/29777 Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Reviewed-by: Brandon Potter <Brandon.Potter@amd.com> Maintainer: Jason Lowe-Power <power.jg@gmail.com> Maintainer: Brandon Potter <Brandon.Potter@amd.com> Tested-by: kokoro <noreply+kokoro@google.com>
198 lines
5.2 KiB
C++
198 lines
5.2 KiB
C++
/*
|
|
* Copyright (c) 2017 Advanced Micro Devices, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are
|
|
* met: redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer;
|
|
* redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution;
|
|
* neither the name of the copyright holders nor the names of its
|
|
* contributors may be used to endorse or promote products derived from
|
|
* this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <sim/futex_map.hh>
|
|
|
|
FutexKey::FutexKey(uint64_t addr_in, uint64_t tgid_in)
|
|
: addr(addr_in), tgid(tgid_in) {}
|
|
|
|
bool
|
|
FutexKey::operator==(const FutexKey &in) const
|
|
{
|
|
return addr == in.addr && tgid == in.tgid;
|
|
}
|
|
|
|
namespace std {
|
|
size_t hash<FutexKey>::operator()(const FutexKey& in) const
|
|
{
|
|
size_t hash = 65521;
|
|
for (int i = 0; i < sizeof(uint64_t) / sizeof(size_t); i++) {
|
|
hash ^= (size_t)(in.addr >> sizeof(size_t) * i) ^
|
|
(size_t)(in.tgid >> sizeof(size_t) * i);
|
|
}
|
|
return hash;
|
|
}
|
|
}
|
|
|
|
WaiterState::WaiterState(ThreadContext* _tc, int _bitmask)
|
|
: tc(_tc), bitmask(_bitmask) { }
|
|
|
|
bool
|
|
WaiterState::checkMask(int wakeup_bitmask) const
|
|
{
|
|
return bitmask & wakeup_bitmask;
|
|
}
|
|
|
|
void
|
|
FutexMap::suspend(Addr addr, uint64_t tgid, ThreadContext *tc)
|
|
{
|
|
suspend_bitset(addr, tgid, tc, 0xffffffff);
|
|
}
|
|
|
|
int
|
|
FutexMap::wakeup(Addr addr, uint64_t tgid, int count)
|
|
{
|
|
FutexKey key(addr, tgid);
|
|
auto it = find(key);
|
|
|
|
if (it == end())
|
|
return 0;
|
|
|
|
int woken_up = 0;
|
|
auto &waiterList = it->second;
|
|
|
|
while (!waiterList.empty() && woken_up < count) {
|
|
// Threads may be woken up by access to locked
|
|
// memory addresses outside of syscalls, so we
|
|
// must only count threads that were actually
|
|
// woken up by this syscall.
|
|
auto& tc = waiterList.front().tc;
|
|
tc->activate();
|
|
woken_up++;
|
|
waiterList.pop_front();
|
|
waitingTcs.erase(tc);
|
|
}
|
|
|
|
if (waiterList.empty())
|
|
erase(it);
|
|
|
|
return woken_up;
|
|
}
|
|
|
|
void
|
|
FutexMap::suspend_bitset(Addr addr, uint64_t tgid, ThreadContext *tc,
|
|
int bitmask)
|
|
{
|
|
FutexKey key(addr, tgid);
|
|
auto it = find(key);
|
|
|
|
if (it == end()) {
|
|
WaiterList waiterList {WaiterState(tc, bitmask)};
|
|
insert({key, waiterList});
|
|
} else {
|
|
it->second.push_back(WaiterState(tc, bitmask));
|
|
}
|
|
waitingTcs.emplace(tc);
|
|
|
|
/** Suspend the thread context */
|
|
tc->suspend();
|
|
}
|
|
|
|
int
|
|
FutexMap::wakeup_bitset(Addr addr, uint64_t tgid, int bitmask)
|
|
{
|
|
FutexKey key(addr, tgid);
|
|
auto it = find(key);
|
|
|
|
if (it == end())
|
|
return 0;
|
|
|
|
int woken_up = 0;
|
|
|
|
auto &waiterList = it->second;
|
|
auto iter = waiterList.begin();
|
|
|
|
while (iter != waiterList.end()) {
|
|
WaiterState& waiter = *iter;
|
|
|
|
if (waiter.checkMask(bitmask)) {
|
|
waiter.tc->activate();
|
|
iter = waiterList.erase(iter);
|
|
waitingTcs.erase(waiter.tc);
|
|
woken_up++;
|
|
} else {
|
|
++iter;
|
|
}
|
|
}
|
|
|
|
if (waiterList.empty())
|
|
erase(it);
|
|
|
|
return woken_up;
|
|
}
|
|
|
|
int
|
|
FutexMap::requeue(Addr addr1, uint64_t tgid, int count, int count2, Addr addr2)
|
|
{
|
|
FutexKey key1(addr1, tgid);
|
|
auto it1 = find(key1);
|
|
|
|
if (it1 == end())
|
|
return 0;
|
|
|
|
int woken_up = 0;
|
|
auto &waiterList1 = it1->second;
|
|
|
|
while (!waiterList1.empty() && woken_up < count) {
|
|
waiterList1.front().tc->activate();
|
|
waiterList1.pop_front();
|
|
woken_up++;
|
|
}
|
|
|
|
WaiterList tmpList;
|
|
int requeued = 0;
|
|
|
|
while (!waiterList1.empty() && requeued < count2) {
|
|
auto w = waiterList1.front();
|
|
waiterList1.pop_front();
|
|
tmpList.push_back(w);
|
|
requeued++;
|
|
}
|
|
|
|
FutexKey key2(addr2, tgid);
|
|
auto it2 = find(key2);
|
|
|
|
if (it2 == end() && requeued > 0) {
|
|
insert({key2, tmpList});
|
|
} else {
|
|
it2->second.insert(it2->second.end(),
|
|
tmpList.begin(), tmpList.end());
|
|
}
|
|
|
|
if (waiterList1.empty())
|
|
erase(it1);
|
|
|
|
return woken_up + requeued;
|
|
}
|
|
|
|
bool
|
|
FutexMap::is_waiting(ThreadContext *tc)
|
|
{
|
|
return waitingTcs.find(tc) != waitingTcs.end();
|
|
}
|