This path fix build failed when gem5's path contains Non-ASCII characters. build_tools/marshal.py embed "abspath" and "modpath" into the generated c++ file. However, if either of them contains Non-ASCII characters, marshal.py will throw an exception. This can be fixed if we set a suitable $LANG for gem5py. For example, we can simply set $LANG=en_US.UTF-8 in src/SConscript to fix this. This patch fixes this bug by passing the host's $LANG environment variable to gem5py. Because for users who may use Non-ASCII characters, their $LANG is generally set to their native language (e.g. zh_CN.UTF-8, en_US.UTF-8, etc.), which contains Non-ASCII characters. Also, it is more reasonable to use the host $LANG than to directly hard-code the $LANG used by gem5py into a language that supports non-ASCII characters. Change-Id: Ia0343cbd6995af3a9e43bf217ad3f186d5633fed Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/58369 Reviewed-by: Gabe Black <gabe.black@gmail.com> Maintainer: Gabe Black <gabe.black@gmail.com> Tested-by: kokoro <noreply+kokoro@google.com>
98 lines
4.6 KiB
Python
98 lines
4.6 KiB
Python
# Copyright (c) 2013, 2015-2017 ARM Limited
|
|
# All rights reserved.
|
|
#
|
|
# The license below extends only to copyright in the software and shall
|
|
# not be construed as granting a license to any other intellectual
|
|
# property including but not limited to intellectual property relating
|
|
# to a hardware implementation of the functionality of the software
|
|
# licensed hereunder. You may use the software subject to the license
|
|
# terms below provided that you ensure that this notice is replicated
|
|
# unmodified and in its entirety in all distributions of the software,
|
|
# modified or unmodified, in source code or in binary form.
|
|
#
|
|
# Copyright (c) 2011 Advanced Micro Devices, Inc.
|
|
# Copyright (c) 2009 The Hewlett-Packard Development Company
|
|
# Copyright (c) 2004-2005 The Regents of The University of Michigan
|
|
# All rights reserved.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions are
|
|
# met: redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer;
|
|
# redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in the
|
|
# documentation and/or other materials provided with the distribution;
|
|
# neither the name of the copyright holders nor the names of its
|
|
# contributors may be used to endorse or promote products derived from
|
|
# this software without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
import os
|
|
|
|
from gem5_python_paths import extra_python_paths
|
|
|
|
def EnvDefaults(env):
|
|
# export TERM so that clang reports errors in color
|
|
use_vars = set([ 'AS', 'AR', 'CC', 'CXX', 'HOME', 'LD_LIBRARY_PATH',
|
|
'LIBRARY_PATH', 'PATH', 'PKG_CONFIG_PATH', 'PROTOC',
|
|
'PYTHONPATH', 'RANLIB', 'TERM', 'PYTHON_CONFIG',
|
|
'CCFLAGS_EXTRA', 'GEM5PY_CCFLAGS_EXTRA',
|
|
'GEM5PY_LINKFLAGS_EXTRA', 'LINKFLAGS_EXTRA', 'LANG'])
|
|
|
|
use_prefixes = [
|
|
"ASAN_", # address sanitizer symbolizer path and settings
|
|
"CCACHE_", # ccache (caching compiler wrapper) configuration
|
|
"CCC_", # clang static analyzer configuration
|
|
"DISTCC_", # distcc (distributed compiler wrapper) config
|
|
"INCLUDE_SERVER_", # distcc pump server settings
|
|
"M5", # M5 configuration (e.g., path to kernels)
|
|
"NIX_", # wrapped binaries if using nix package manager
|
|
]
|
|
|
|
for key,val in sorted(os.environ.items()):
|
|
if key in use_vars or \
|
|
any([key.startswith(prefix) for prefix in use_prefixes]):
|
|
env['ENV'][key] = val
|
|
|
|
# These variables from the environment override/become SCons variables,
|
|
# with a default if they weren't in the host environment.
|
|
var_overrides = {
|
|
'CC': env['CC'],
|
|
'CXX': env['CXX'],
|
|
'PROTOC': 'protoc',
|
|
'PYTHON_CONFIG': [ 'python3-config', 'python-config' ],
|
|
'CCFLAGS_EXTRA': '',
|
|
'GEM5PY_CCFLAGS_EXTRA': '',
|
|
'GEM5PY_LINKFLAGS_EXTRA': '',
|
|
'LINKFLAGS_EXTRA': '',
|
|
}
|
|
for key,default in var_overrides.items():
|
|
env[key] = env['ENV'].get(key, default)
|
|
|
|
# Tell scons to avoid implicit command dependencies to avoid issues
|
|
# with the param wrappes being compiled twice (see
|
|
# https://github.com/SCons/scons/issues/2811
|
|
env['IMPLICIT_COMMAND_DEPENDENCIES'] = 0
|
|
env.Decider('MD5-timestamp')
|
|
|
|
# add useful python code PYTHONPATH so it can be used by subprocesses
|
|
# as well
|
|
env.AppendENVPath('PYTHONPATH', extra_python_paths)
|
|
|
|
# Default duplicate option is to use hard links, but this messes up
|
|
# when you use emacs to edit a file in the target dir, as emacs moves
|
|
# file to file~ then copies to file, breaking the link. Symbolic
|
|
# (soft) links work better.
|
|
env.SetOption('duplicate', 'soft-copy')
|