Bobby R. Bruce
2bc5a8b71a
misc: Run pre-commit run on all files in repo
...
The following command was run:
```
pre-commit run --all-files
```
This ensures all the files in the repository are formatted to pass our
checks.
Change-Id: Ia2fe3529a50ad925d1076a612d60a4280adc40de
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/62572
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com >
Maintainer: Jason Lowe-Power <power.jg@gmail.com >
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
2022-08-24 21:47:07 +00:00
Gabe Black
17afe4e7ab
scons: Fix checking the --install-hooks option in the "git" tool.
...
The option should be checked with 'install_hooks' and not
'install-hooks', even though the option is '--install-hooks' to the
user.
This bug was due to an incorrect review suggestion from me on this
original change:
https://gem5-review.googlesource.com/c/public/gem5/+/50410
JIRA: https://gem5.atlassian.net/browse/GEM5-1091
Change-Id: Ifb4526307bea015de1fe73d3d685477be711b7cb
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/50628
Maintainer: Gabe Black <gabe.black@gmail.com >
Reviewed-by: Eric Ye <ericye@google.com >
Reviewed-by: Hoa Nguyen <hoanguyen@ucdavis.edu >
Tested-by: kokoro <noreply+kokoro@google.com >
2021-09-19 06:02:03 +00:00
Eric Ye
e61f62b478
scons: Allow clean non-interactive builds
...
On a clean build, the git tool will wait for input() before installing
git hooks. Allow bypassing this via a command-line flag, making it
possible to perform a clean build non-interactively.
Bug: 199780674
Test: build_gem5 --install-hooks
Change-Id: I48be2c1a7c2335a2f4f6359adf582ca8b0ae5939
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/50410
Reviewed-by: Gabe Black <gabe.black@gmail.com >
Maintainer: Gabe Black <gabe.black@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
2021-09-17 17:23:02 +00:00
Gabe Black
2e27ed2351
python,scons: Move readCommand and compareVersions into site_scons.
...
These functions are only used by scons, so it makes sense to move them
to site_scons/gem5_scons/util.py.
Change-Id: If2b3995f208cb71adf3c59aac4eabe378c47f94f
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/41599
Reviewed-by: Gabe Black <gabe.black@gmail.com >
Maintainer: Gabe Black <gabe.black@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
2021-05-10 23:33:22 +00:00
Andreas Sandberg
d06a193c13
scons: Remove Python 2.7 compatibility code
...
Remove the dependency on six and most 'import x from __future__'. A
few instances of imports from the future have been left in place to
ensure that Python 2.7 users still get an error message when invoking
scons.
Change-Id: I366275a6040f0084e91198b5b5c2a648bffbf2d2
Signed-off-by: Andreas Sandberg <andreas.sandberg@arm.com >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39585
Tested-by: kokoro <noreply+kokoro@google.com >
Reviewed-by: Gabe Black <gabe.black@gmail.com >
Maintainer: Gabe Black <gabe.black@gmail.com >
2021-01-22 15:29:12 +00:00
Hoa Nguyen
8da27ca382
scons: Fix the scons script failing to install git hooks
...
A recent change,
https://gem5-review.googlesource.com/c/public/gem5/+/38616 ,
removed the 'root' environment variable, while the git hooks
installation script relies on the variable. This commit
addresses this problem.
Change-Id: I2d27861794021a6a60ef8668461e4127cb1db261
Signed-off-by: Hoa Nguyen <hoanguyen@ucdavis.edu >
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/38655
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com >
Maintainer: Jason Lowe-Power <power.jg@gmail.com >
Tested-by: kokoro <noreply+kokoro@google.com >
2020-12-23 02:37:27 +00:00
Gabe Black
1a2ced4b00
scons: Use six.input instead of raw_input.
...
raw_input is not defined in python 3.x and has been replaced by "input".
The "six" compatiblity module defines its own "input" method which
figures out which to use under the covers.
Change-Id: I13a885dd45ec0160c7b46e334b06aae239e3c836
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27948
Reviewed-by: Giacomo Travaglini <giacomo.travaglini@arm.com >
Maintainer: Gabe Black <gabeblack@google.com >
Tested-by: kokoro <noreply+kokoro@google.com >
2020-04-20 22:49:11 +00:00
Gabe Black
4ab786dbec
scons: Import "sys" which is used in an exception handler.
...
If the call to "raw_input" fails (it does in python 3.x), then the
"except" runs and will also fail because sys hasn't been imported.
Change-Id: Ibf5778a893a5bd8aad17f4aee544ddcfe5085cab
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27947
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com >
Maintainer: Gabe Black <gabeblack@google.com >
Tested-by: kokoro <noreply+kokoro@google.com >
2020-04-20 22:49:11 +00:00
Gabe Black
a39c8db854
scons: Fixes to improve python 3 support.
...
Some simple fixes to improve python 3 compatability in scons.
Change-Id: I89aba6ed9d73ee733307c57e033c636029d9cb7a
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/23264
Reviewed-by: Jason Lowe-Power <jason@lowepower.com >
Maintainer: Jason Lowe-Power <jason@lowepower.com >
Tested-by: kokoro <noreply+kokoro@google.com >
2019-12-07 00:03:14 +00:00
Siddhesh Poyarekar
5c3983215a
scons: Import print_function from future
...
Scons on Fedora 27 imports print_function from the future[1] as a
result of which a gem5 build errors out with a syntax error. Make all
the scons scripts that use the print statement import the print_function
from future and replace the statements with print function calls.
[1] 34cf3bdb17siddhesh.poyarekar@gmail.com >
Reviewed-on: https://gem5-review.googlesource.com/8321
Reviewed-by: Gabe Black <gabeblack@google.com >
Reviewed-by: Anthony Gutierrez <anthony.gutierrez@amd.com >
Maintainer: Gabe Black <gabeblack@google.com >
2018-03-06 19:45:34 +00:00
Gabe Black
902b3e34be
scons: Pull style hook management out of the main SConstruct.
...
Put the code which supports style hooks for mercurial and git into two
scons "tools".
Change-Id: I3ffed85a177be4f9e458fff7b1cf16a3a479914e
Reviewed-on: https://gem5-review.googlesource.com/5563
Reviewed-by: Gabe Black <gabeblack@google.com >
Maintainer: Gabe Black <gabeblack@google.com >
2017-11-10 13:17:00 +00:00
