4 Commits

Author	SHA1	Message	Date
Gabe Black	c110695a44	util: Use the std namespace for memcpy and memset in the m5 util. ... The C++ versions of those functions are technically in the std namespace, and while they may work without it (the C version leaking through from somewhere?), they should still use it. Change-Id: Ib53a7f0c41d7f5776221e7661c616ea51e8ed528 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/31834 Tested-by: kokoro <noreply+kokoro@google.com> Maintainer: Bobby R. Bruce <bbruce@ucdavis.edu> Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br>	2020-12-21 23:47:59 +00:00
Gabe Black	cef72adabc	util: Standardize console output in the m5 writefile command. ... When the command reports an error, it should then exit(2) and not just return as if everything worked. When printing the number of bytes written or the file being opened, it should write this non-error message to cout, and not cerr. Also used proper capitalization and punctuation in a couple messages. Change-Id: I2c0d6592357965ed2eee8f090c8b3d530b354b9f Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27627 Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Reviewed-by: Pouya Fotouhi <pfotouhi@ucdavis.edu> Maintainer: Jason Lowe-Power <power.jg@gmail.com> Tested-by: kokoro <noreply+kokoro@google.com>	2020-07-27 08:29:51 +00:00
Gabe Black	8a4fcdee4d	util: Make m5 commands return a bool instead of calling usage. ... By delegating actually calling usage() elsewhere, we can remove a dependency from the commands themselves, and also make testing easier since we won't exit() every time we call a command with bad arguments. Change-Id: I6b8e2cb77ce0456b16673f10349362cc53218bba Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27565 Reviewed-by: Gabe Black <gabeblack@google.com> Maintainer: Gabe Black <gabeblack@google.com> Tested-by: kokoro <noreply+kokoro@google.com>	2020-07-27 08:28:42 +00:00
Gabe Black	ff82cba034	util: Split up the commands into separate files in the m5 util. ... This way each individual command can have a unit test written for it, covering how it gathers its arguments and puts them passes them to the underlying dispatch function. Change-Id: Ia629c412c8906fc6f5ae02c509ed630755cee45c Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27564 Reviewed-by: Gabe Black <gabeblack@google.com> Maintainer: Gabe Black <gabeblack@google.com> Tested-by: kokoro <noreply+kokoro@google.com>	2020-07-27 08:28:24 +00:00