From fc0a043950a828c1f513bfe421f33eeb70a6aa83 Mon Sep 17 00:00:00 2001 From: anoop Date: Fri, 1 Dec 2023 22:01:19 +0100 Subject: [PATCH] mem-ruby: Unused L3CacheCntrl freed (#598) Seems like the MOESI_AMD_Base-L3Cache.sm file is unused in the VIPER protocol. It's confusing to have it in the GPU_VIPER.slicc file. --- configs/ruby/GPU_VIPER.py | 1 + src/mem/ruby/protocol/GPU_VIPER.slicc | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/ruby/GPU_VIPER.py b/configs/ruby/GPU_VIPER.py index d853c2ef54..96d86f38d3 100644 --- a/configs/ruby/GPU_VIPER.py +++ b/configs/ruby/GPU_VIPER.py @@ -345,6 +345,7 @@ class L3Cache(RubyCache): self.replacement_policy = TreePLRURP() +# unused in GPU_VIPER; see git blame for discussion class L3Cntrl(L3Cache_Controller, CntrlBase): def create(self, options, ruby_system, system): self.version = self.versionCount() diff --git a/src/mem/ruby/protocol/GPU_VIPER.slicc b/src/mem/ruby/protocol/GPU_VIPER.slicc index 196058b0d8..8a09fb0580 100644 --- a/src/mem/ruby/protocol/GPU_VIPER.slicc +++ b/src/mem/ruby/protocol/GPU_VIPER.slicc @@ -8,4 +8,4 @@ include "GPU_VIPER-msg.sm"; include "GPU_VIPER-TCP.sm"; include "GPU_VIPER-SQC.sm"; include "GPU_VIPER-TCC.sm"; -include "MOESI_AMD_Base-L3cache.sm"; +include "MOESI_AMD_Base-L3cache.sm"; // unused in GPU_VIPER; see git blame for discussion