From fb4eb86711599351dab72fbd7b5d241fe3a35f77 Mon Sep 17 00:00:00 2001
From: Gabe Black <gabeblack@google.com>
Date: Sat, 18 Mar 2023 06:23:57 -0700
Subject: [PATCH] base: Flip the default for ListenSocket::accept(bool
 nodelay).

This option was almost always overridden from false to true anyway,
except in one place (in the ethertap device) which was likely just by
accident.

This will give external users a chance to remove the option without
changing behavior, so that the option can be removed entirely in a
later change.

Change-Id: I77add40b8131b91997b2aecbfff6c7de0ee9ead9
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69157
Reviewed-by: Yu-hsin Wang <yuhsingw@google.com>
Tested-by: kokoro <noreply+kokoro@google.com>
Maintainer: Gabe Black <gabeblack@google.com>
---
 src/base/socket.hh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/base/socket.hh b/src/base/socket.hh
index f3b2760518..af4a6511dd 100644
--- a/src/base/socket.hh
+++ b/src/base/socket.hh
@@ -104,7 +104,7 @@ class ListenSocket
     ListenSocket();
     virtual ~ListenSocket();
 
-    virtual int accept(bool nodelay = false);
+    virtual int accept(bool nodelay = true);
 
     virtual bool listen(int port, bool reuse = true);