From f7cf47bc313945509020fd5b430262801e492f31 Mon Sep 17 00:00:00 2001 From: Daecheol You Date: Thu, 1 Sep 2022 13:49:56 +0900 Subject: [PATCH] mem-ruby: bug fix for Finish_CopyBack_Stale I made a mistake in the change below: https://gem5-review.googlesource.com/c/public/gem5/+/58413 Checking the requestor in the sharer list for eviction should be removed now. If the sharer count is zero, the requestor can't be in the sharer list. Change-Id: I304d2dd7df1aff4907801664a260c35c490a2136 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/62991 Maintainer: Jason Lowe-Power Tested-by: kokoro Reviewed-by: Jason Lowe-Power --- src/mem/ruby/protocol/chi/CHI-cache-actions.sm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mem/ruby/protocol/chi/CHI-cache-actions.sm b/src/mem/ruby/protocol/chi/CHI-cache-actions.sm index 2c47ac9cbb..6425aa6712 100644 --- a/src/mem/ruby/protocol/chi/CHI-cache-actions.sm +++ b/src/mem/ruby/protocol/chi/CHI-cache-actions.sm @@ -900,7 +900,7 @@ action(Finish_CopyBack_Stale, desc="") { // if it was the last known sharer and we don't have the data do the same // the Initiate_Evict if ((is_HN == false) && (tbe.dir_sharers.count() == 0) && - tbe.dir_sharers.isElement(tbe.requestor) && (tbe.dataValid == false)) { + (tbe.dataValid == false)) { tbe.actions.push(Event:SendEvict); } }