From f484341215a89893c654044e09ba6a3b0df84b68 Mon Sep 17 00:00:00 2001
From: Gabe Black <gabe.black@gmail.com>
Date: Sat, 27 Feb 2021 03:39:41 -0800
Subject: [PATCH] cpu: Get rid of the unused eaSrcsReady method.

This method wasn't used by anything, and also made very unsafe
assumptions about what different source registers were used for.

Change-Id: I8f58aa70e139d3895499e04c86d8de2530e17d5a
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/42095
Reviewed-by: Matthew Poremba <matthew.poremba@amd.com>
Maintainer: Gabe Black <gabe.black@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>
---
 src/cpu/o3/dyn_inst.hh      |  3 ---
 src/cpu/o3/dyn_inst_impl.hh | 17 -----------------
 2 files changed, 20 deletions(-)

diff --git a/src/cpu/o3/dyn_inst.hh b/src/cpu/o3/dyn_inst.hh
index 3df13b7fd2..4083721ce9 100644
--- a/src/cpu/o3/dyn_inst.hh
+++ b/src/cpu/o3/dyn_inst.hh
@@ -1024,9 +1024,6 @@ class BaseO3DynInst : public ExecContext, public RefCounted
     ThreadContext *tcBase() const override { return thread->getTC(); }
 
   public:
-    /** Returns whether or not the eff. addr. source registers are ready. */
-    bool eaSrcsReady() const;
-
     /** Is this instruction's memory access strictly ordered? */
     bool strictlyOrdered() const { return instFlags[IsStrictlyOrdered]; }
     void strictlyOrdered(bool so) { instFlags[IsStrictlyOrdered] = so; }
diff --git a/src/cpu/o3/dyn_inst_impl.hh b/src/cpu/o3/dyn_inst_impl.hh
index 5e4d3c1759..7bb9dde238 100644
--- a/src/cpu/o3/dyn_inst_impl.hh
+++ b/src/cpu/o3/dyn_inst_impl.hh
@@ -202,23 +202,6 @@ BaseO3DynInst<Impl>::markSrcRegReady(RegIndex src_idx)
     markSrcRegReady();
 }
 
-template <class Impl>
-bool
-BaseO3DynInst<Impl>::eaSrcsReady() const
-{
-    // For now I am assuming that src registers 1..n-1 are the ones that the
-    // EA calc depends on.  (i.e. src reg 0 is the source of the data to be
-    // stored)
-
-    for (int i = 1; i < numSrcRegs(); ++i) {
-        if (!regs.readySrcIdx(i))
-            return false;
-    }
-
-    return true;
-}
-
-
 
 template <class Impl>
 void