From e7ae5290f56cb8b729b36ff882ea9861e7cb91e7 Mon Sep 17 00:00:00 2001 From: Yen-lin Lai Date: Thu, 13 Apr 2023 10:45:58 +0800 Subject: [PATCH] base: Fix VNC server initialization In a previous commit, the initialization of dataFd to -1 is removed. Add it back so VNC server can properly accept connection. Fixes: 67fb75d659 ("base,cpu,dev,sim: Pull common logic into ListenSocket::listen().") Change-Id: I4246d1fddc766cb190a04d4f984fc1ce73af3fb0 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69757 Tested-by: kokoro Reviewed-by: Gabe Black Maintainer: Gabe Black --- src/base/vnc/vncserver.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/base/vnc/vncserver.cc b/src/base/vnc/vncserver.cc index f34241968e..4b1ddae307 100644 --- a/src/base/vnc/vncserver.cc +++ b/src/base/vnc/vncserver.cc @@ -117,7 +117,7 @@ VncServer::DataEvent::process(int revent) */ VncServer::VncServer(const Params &p) : VncInput(p), listenEvent(NULL), dataEvent(NULL), number(p.number), - listener(p.port.build(p.name)), + dataFd(-1), listener(p.port.build(p.name)), sendUpdate(false), supportsRawEnc(false), supportsResizeEnc(false) { if (p.port)